From: Shannon Zhao <zhaoshenglong@huawei.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>, xen-devel@lists.xen.org
Cc: wei.liu2@citrix.com, andrew.cooper3@citrix.com,
ian.jackson@eu.citrix.com, julien.grall@arm.com,
jbeulich@suse.com, roger.pau@citrix.com
Subject: Re: [PATCH v3 12/19] libacpi: Build DSDT for PVH guests
Date: Wed, 14 Sep 2016 12:13:39 +0800 [thread overview]
Message-ID: <57D8CE73.20501@huawei.com> (raw)
In-Reply-To: <1473274769-19129-13-git-send-email-boris.ostrovsky@oracle.com>
On 2016/9/8 2:59, Boris Ostrovsky wrote:
> PVH guests require DSDT with only ACPI INFO (Xen-specific) and Processor
> objects. We separate ASL's ACPI INFO definition into dsdt_acpi_info.asl so
> that it can be included in ASLs for both HVM and PVH2.
>
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> ---
> Changes in v3:
> * Added comment to dsdt_acpi_info.asl indicating that the structure
> there must match struct acpi_info
> * Use QEMU_NONE in mk_dsdt.c
> * Makefile tweaks
>
> tools/libacpi/Makefile | 13 ++++++++++---
> tools/libacpi/dsdt.asl | 20 --------------------
> tools/libacpi/dsdt_acpi_info.asl | 26 ++++++++++++++++++++++++++
> tools/libacpi/mk_dsdt.c | 8 ++++++++
> 4 files changed, 44 insertions(+), 23 deletions(-)
> create mode 100644 tools/libacpi/dsdt_acpi_info.asl
>
> diff --git a/tools/libacpi/Makefile b/tools/libacpi/Makefile
> index 6325cd0..12b081e 100644
> --- a/tools/libacpi/Makefile
> +++ b/tools/libacpi/Makefile
> @@ -18,7 +18,7 @@ include $(XEN_ROOT)/tools/firmware/Rules.mk
> MK_DSDT = $(ACPI_BUILD_DIR)/mk_dsdt
>
> # Sources to be generated
> -C_SRC = $(addprefix $(ACPI_BUILD_DIR)/, dsdt_anycpu.c dsdt_15cpu.c dsdt_anycpu_qemu_xen.c)
> +C_SRC = $(addprefix $(ACPI_BUILD_DIR)/, dsdt_anycpu.c dsdt_15cpu.c dsdt_anycpu_qemu_xen.c dsdt_pvh.c)
> H_SRC = $(addprefix $(ACPI_BUILD_DIR)/, ssdt_s3.h ssdt_s4.h ssdt_pm.h ssdt_tpm.h)
>
Hi Bros,
It looks like you forgot to add 'C_SRC-$(CONFIG_X86)' here. Will you add
it in your next version?
Thanks,
--
Shannon
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-09-14 4:13 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 18:59 [PATCH v3 00/19] Make ACPI builder available to components other than hvmloader Boris Ostrovsky
2016-09-07 18:59 ` [PATCH v3 01/19] acpi: Re-license ACPI builder files from GPLv2 to LGPLv2.1 Boris Ostrovsky
2016-09-07 19:48 ` Boris Ostrovsky
2016-09-07 18:59 ` [PATCH v3 02/19] acpi/hvmloader: Collect processor and NUMA info in hvmloader Boris Ostrovsky
2016-09-08 13:41 ` Jan Beulich
2016-09-07 18:59 ` [PATCH v3 03/19] acpi/hvmloader: Set TIS header address " Boris Ostrovsky
2016-09-07 18:59 ` [PATCH v3 04/19] acpi/hvmloader: Make providing IOAPIC in MADT optional Boris Ostrovsky
2016-09-07 18:59 ` [PATCH v3 05/19] acpi/hvmloader: Build WAET optionally Boris Ostrovsky
2016-09-07 18:59 ` [PATCH v3 06/19] acpi/hvmloader: Replace mem_alloc() and virt_to_phys() with memory ops Boris Ostrovsky
2016-09-08 13:54 ` Jan Beulich
2016-09-07 18:59 ` [PATCH v3 07/19] acpi/hvmloader: Translate all addresses when assigning addresses in ACPI tables Boris Ostrovsky
2016-09-07 18:59 ` [PATCH v3 08/19] acpi/hvmloader: Link ACPI object files directly Boris Ostrovsky
2016-09-08 13:56 ` Jan Beulich
2016-09-07 18:59 ` [PATCH v3 09/19] acpi/hvmloader: Include file/paths adjustments Boris Ostrovsky
2016-09-08 14:05 ` Jan Beulich
2016-09-08 18:29 ` Boris Ostrovsky
2016-09-07 18:59 ` [PATCH v3 10/19] acpi: Move ACPI code to tools/libacpi Boris Ostrovsky
2016-09-07 18:59 ` [PATCH v3 11/19] x86: Allow LAPIC-only emulation_flags for HVM guests Boris Ostrovsky
2016-09-07 18:59 ` [PATCH v3 12/19] libacpi: Build DSDT for PVH guests Boris Ostrovsky
2016-09-08 14:09 ` Jan Beulich
2016-09-14 4:13 ` Shannon Zhao [this message]
2016-09-14 12:47 ` Boris Ostrovsky
2016-09-07 18:59 ` [PATCH v3 13/19] acpi: Makefile should better tolerate interrupts Boris Ostrovsky
2016-09-08 14:15 ` Jan Beulich
2016-09-08 18:51 ` Boris Ostrovsky
2016-09-09 8:03 ` Jan Beulich
2016-09-09 13:07 ` Boris Ostrovsky
2016-09-09 13:29 ` Jan Beulich
2016-09-09 13:56 ` Boris Ostrovsky
2016-09-09 14:13 ` Ian Jackson
2016-09-09 14:31 ` Boris Ostrovsky
2016-09-09 14:33 ` Ian Jackson
2016-09-09 14:38 ` Boris Ostrovsky
2016-09-09 15:20 ` Jan Beulich
2016-09-09 16:05 ` Boris Ostrovsky
2016-09-09 16:11 ` Jan Beulich
2016-09-07 18:59 ` [PATCH v3 14/19] libxc/libxl: Allow multiple ACPI modules Boris Ostrovsky
2016-09-15 10:13 ` Wei Liu
2016-09-07 18:59 ` [PATCH v3 15/19] libxl/acpi: Add ACPI e820 entry Boris Ostrovsky
2016-09-15 10:13 ` Wei Liu
2016-09-07 18:59 ` [PATCH v3 16/19] libxl/pvhv2: Include APIC page in MMIO hole for PVHv2 guests Boris Ostrovsky
2016-09-15 10:13 ` Wei Liu
2016-09-07 18:59 ` [PATCH v3 17/19] ilibxl: Initialize domain build info before calling libxl__domain_make Boris Ostrovsky
2016-09-15 10:13 ` Wei Liu
2016-09-07 18:59 ` [PATCH v3 18/19] libxl/acpi: Build ACPI tables for HVMlite guests Boris Ostrovsky
2016-09-08 14:20 ` Jan Beulich
2016-09-08 18:53 ` Boris Ostrovsky
2016-09-09 8:05 ` Jan Beulich
2016-09-09 13:11 ` Boris Ostrovsky
2016-09-09 13:50 ` Ian Jackson
2016-09-09 14:02 ` Boris Ostrovsky
2016-09-07 18:59 ` [PATCH v3 19/19] libxc/xc_dom_core: Copy ACPI tables to guest space Boris Ostrovsky
2016-09-15 10:13 ` Wei Liu
2016-09-14 15:21 ` [PATCH v3 00/19] Make ACPI builder available to components other than hvmloader Boris Ostrovsky
2016-09-15 10:18 ` Wei Liu
2016-09-15 10:20 ` Julien Grall
2016-09-15 10:22 ` Wei Liu
2016-09-15 12:39 ` Boris Ostrovsky
2016-09-15 13:48 ` Julien Grall
2016-09-15 14:07 ` Boris Ostrovsky
2016-09-15 14:21 ` Jan Beulich
2016-09-15 15:28 ` Boris Ostrovsky
2016-09-15 16:05 ` Jan Beulich
2016-09-15 16:40 ` Boris Ostrovsky
2016-09-16 6:45 ` Jan Beulich
2016-09-16 12:41 ` Boris Ostrovsky
2016-09-16 15:22 ` Lars Kurth
2016-09-16 15:53 ` Boris Ostrovsky
2016-09-19 15:30 ` Ian Jackson
2016-09-19 15:42 ` Boris Ostrovsky
2016-09-19 15:49 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57D8CE73.20501@huawei.com \
--to=zhaoshenglong@huawei.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=roger.pau@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).