From: Joao Martins <joao.m.martins@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v4 5/5] x86/time: extend "tsc" param with "stable:socket"
Date: Mon, 19 Sep 2016 17:11:39 +0100 [thread overview]
Message-ID: <57E00E3B.2070106@oracle.com> (raw)
In-Reply-To: <57DFDA1A020000780010FED3@prv-mh.provo.novell.com>
On 09/19/2016 11:29 AM, Jan Beulich wrote:
>>>> On 14.09.16 at 19:37, <joao.m.martins@oracle.com> wrote:
>> --- a/docs/misc/xen-command-line.markdown
>> +++ b/docs/misc/xen-command-line.markdown
>> @@ -270,7 +270,9 @@ If set, override Xen's default choice for the platform timer.
>> Having TSC as platform timer requires being explicitly set. This is because
>> TSC can only be safely used if CPU hotplug isn't performed on the system. In
>> some platforms, "maxcpus" parameter may require further adjustment to the
>> -number of online cpus.
>> +number of online cpus. When running under platforms that can guarantee a
>
> ... running on platforms ...
>
>> +monotonic TSC across sockets you require adjusting "tsc" command line parameter
>
> ... you may want to adjust the ...
>
>> +parameter to "stable:sockets".
>
> Redundant "parameter" (I guess the one on the earlier line was meant
> to get moved due to line length). Also you say "sockets" here but ...
>
>> @@ -1508,7 +1510,7 @@ pages) must also be specified via the tbuf\_size parameter.
>> > `= <integer>`
>>
>> ### tsc
>> -> `= unstable | skewed`
>> +> `= unstable | skewed | stable:socket`
>
> "socket" here - the two really should match.
Correct, I will fix this parameter name mismatch, and the spelling mistakes you
pointed out above.
>> --- a/xen/arch/x86/time.c
>> +++ b/xen/arch/x86/time.c
>> @@ -477,6 +477,10 @@ uint64_t ns_to_acpi_pm_tick(uint64_t ns)
>> /************************************************************
>> * PLATFORM TIMER 4: TSC
>> */
>> +static unsigned int __read_mostly tsc_flags;
>
> __initdata instead of __read_mostly
OK.
Joao
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-09-19 16:10 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 17:37 [PATCH v4 0/5] x86/time: PVCLOCK_TSC_STABLE_BIT support Joao Martins
2016-09-14 17:37 ` [PATCH v4 1/5] x86/time: refactor init_platform_time() Joao Martins
2016-09-14 17:37 ` [PATCH v4 2/5] x86/time: implement tsc as clocksource Joao Martins
2016-09-19 10:13 ` Jan Beulich
2016-09-19 16:11 ` Joao Martins
2016-09-19 16:25 ` Jan Beulich
2016-09-19 17:54 ` Joao Martins
2016-09-20 7:13 ` Jan Beulich
2016-09-20 10:15 ` Joao Martins
2016-09-20 10:23 ` Joao Martins
2016-09-20 13:55 ` Jan Beulich
2016-09-20 16:17 ` Joao Martins
2016-09-21 9:14 ` Joao Martins
2016-09-21 9:20 ` Joao Martins
2016-09-21 9:45 ` Jan Beulich
2016-09-21 13:30 ` Joao Martins
2016-09-14 17:37 ` [PATCH v4 3/5] x86/time: refactor read_platform_stime() Joao Martins
2016-09-19 10:15 ` Jan Beulich
2016-09-19 16:11 ` Joao Martins
2016-09-14 17:37 ` [PATCH v4 4/5] x86/time: implement PVCLOCK_TSC_STABLE_BIT Joao Martins
2016-09-19 10:22 ` Jan Beulich
2016-09-19 16:11 ` Joao Martins
2016-09-14 17:37 ` [PATCH v4 5/5] x86/time: extend "tsc" param with "stable:socket" Joao Martins
2016-09-19 10:29 ` Jan Beulich
2016-09-19 16:11 ` Joao Martins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57E00E3B.2070106@oracle.com \
--to=joao.m.martins@oracle.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).