From: Julien Grall <julien.grall@linaro.org>
To: Manish Jaggi <mjaggi@caviumnetworks.com>, xen-devel@lists.xenproject.org
Cc: Andre.Przywara@arm.com, julien.grall@arm.com,
sstabellini@kernel.org, Manish Jaggi <mjaggi@cavium.com>
Subject: Re: [PATCH v6 3/5] ARM: ITS: Deny hardware domain access to ITS
Date: Tue, 10 Oct 2017 14:55:35 +0100 [thread overview]
Message-ID: <6177403c-c76f-f17e-1e30-7b5dda2e3e47@linaro.org> (raw)
In-Reply-To: <4ff249f3-3326-e0a2-dfd9-0983a59163a0@caviumnetworks.com>
On 10/10/17 14:53, Manish Jaggi wrote:
> Hi Julien,
>
> On 10/10/2017 7:09 PM, Julien Grall wrote:
>> Hi Manish,
>>
>> On 10/10/17 13:52, mjaggi@caviumnetworks.com wrote:
>>> From: Manish Jaggi <mjaggi@cavium.com>
>>>
>>> This patch extends the gicv3_iomem_deny_access functionality by adding
>>> support for ITS region as well. Add function gicv3_its_deny_access.
>>>
>>> Reviewed-by: Andre Przywara <andre.przywara@arm.com>
>>> Acked-by: Julien Grall <julien.grall@arm.com>
>>
>> Please state after "---" when you modified a patch and keep the tags
>> to at least check if the reviewer is happy with it.
>>
>> It is one of the reason I like the changelog in each patch. It helps
>> to know what changed in a specific one. It helps me to decide whether
>> I am happy with you keeping my tag and avoid to fully review yet
>> another time the patch.
>>
>> In that case, it is fine to keep it.
> For this patch please ack it.
I didn't ask to remove it :). Just pointed out that you should be more
mindful when keeping an acked-by/reviewed-by.
> Changelog:
> I have added
> - a check on return value for gicv3_its_deny_access(d);
> - used its_data->size in place of GICV3_ITS_SIZE
> - remove extra space in printk
Thank you for the changelog!
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-10-10 13:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 12:52 [PATCH v6 0/5] ARM: ACPI: ITS: Add ITS Support for ACPI hardware domain mjaggi
2017-10-10 12:52 ` [PATCH v6 1/5] ARM: ITS: Introduce common function add_to_host_its_list mjaggi
2017-10-10 12:52 ` [PATCH v6 2/5] ARM: ITS: Populate host_its_list from ACPI MADT Table mjaggi
2017-10-10 13:41 ` Julien Grall
2017-10-10 12:52 ` [PATCH v6 3/5] ARM: ITS: Deny hardware domain access to ITS mjaggi
2017-10-10 13:39 ` Julien Grall
2017-10-10 13:53 ` Manish Jaggi
2017-10-10 13:55 ` Julien Grall [this message]
2017-10-10 12:52 ` [PATCH v6 4/5] ARM: Update Formula to compute MADT size using new callbacks in gic_hw_operations mjaggi
2017-10-10 13:44 ` Julien Grall
2017-10-10 12:52 ` [PATCH v6 5/5] ARM: ITS: Expose ITS in the MADT table mjaggi
2017-10-10 13:47 ` Julien Grall
2017-10-10 19:15 ` Stefano Stabellini
2017-10-10 19:24 ` Julien Grall
2017-10-10 20:07 ` Stefano Stabellini
2017-10-10 20:15 ` Julien Grall
2017-10-10 15:09 ` [PATCH v6 0/5] ARM: ACPI: ITS: Add ITS Support for ACPI hardware domain Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6177403c-c76f-f17e-1e30-7b5dda2e3e47@linaro.org \
--to=julien.grall@linaro.org \
--cc=Andre.Przywara@arm.com \
--cc=julien.grall@arm.com \
--cc=mjaggi@cavium.com \
--cc=mjaggi@caviumnetworks.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).