From: Julien Grall <julien.grall@linaro.org>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
Jan Beulich <JBeulich@suse.com>,
Adrian Pop <apop@bitdefender.com>
Cc: Julien Grall <julien.grall@arm.com>, xen-devel@lists.xen.org
Subject: Re: [PATCH for-4.10 v2] x86/hvm: Fix altp2m_vcpu_enable_notify error handling
Date: Thu, 16 Nov 2017 14:57:12 +0000 [thread overview]
Message-ID: <65c6111b-af2c-8b5b-2acb-abfa4e03665e@linaro.org> (raw)
In-Reply-To: <47c6b40c-6bda-e62e-a2b0-cc29694056d8@citrix.com>
Hi,
On 15/11/17 14:16, Andrew Cooper wrote:
> On 15/11/17 14:10, Jan Beulich wrote:
>>>>> On 15.11.17 at 14:47, <apop@bitdefender.com> wrote:
>>> The altp2m_vcpu_enable_notify subop handler might skip calling
>>> rcu_unlock_domain() after rcu_lock_current_domain(). Albeit since both
>>> rcu functions are no-ops when run on the current domain, this doesn't
>>> really have repercussions.
>>>
>>> The second change is adding a missing break that would have potentially
>>> enabled #VE for the current domain even if it had intended to enable it
>>> for another one (not a supported functionality).
>> Thanks, much better.
>>
>>> Signed-off-by: Adrian Pop <apop@bitdefender.com>
>>> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> Reviewed-by: Jan Beulich <jbeulich@suse.com>
>
> FOAD, Requesting a release ack for this change.
Release-acked-by: Julien Grall <julien.grall@linaro.org>
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2017-11-16 14:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-15 13:47 [PATCH v2] x86/hvm: Fix altp2m_vcpu_enable_notify error handling Adrian Pop
2017-11-15 14:10 ` Jan Beulich
2017-11-15 14:16 ` [PATCH for-4.10 " Andrew Cooper
2017-11-16 14:57 ` Julien Grall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65c6111b-af2c-8b5b-2acb-abfa4e03665e@linaro.org \
--to=julien.grall@linaro.org \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=apop@bitdefender.com \
--cc=julien.grall@arm.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).