Re: [PATCH] x86/HVM: fix interaction between internal and extern emulation

From: Paul Durrant <Paul.Durrant@citrix.com>
To: 'Jan Beulich' <JBeulich@suse.com>
Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>,
	Julien Grall <julien.grall@arm.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] x86/HVM: fix interaction between internal and extern emulation
Date: Tue, 28 Nov 2017 13:20:19 +0000	[thread overview]
Message-ID: <65ddb64bb73c489ea30139b52a087461@AMSPEX02CL03.citrite.net> (raw)
In-Reply-To: <5A1D5EB30200007800192BF7@prv-mh.provo.novell.com>

> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@suse.com]
> Sent: 28 November 2017 12:04
> To: Paul Durrant <Paul.Durrant@citrix.com>
> Cc: Julien Grall <julien.grall@arm.com>; Andrew Cooper
> <Andrew.Cooper3@citrix.com>; xen-devel <xen-
> devel@lists.xenproject.org>
> Subject: RE: [PATCH] x86/HVM: fix interaction between internal and extern
> emulation
> 
> >>> On 28.11.17 at 12:58, <Paul.Durrant@citrix.com> wrote:
> >>  -----Original Message-----
> >> From: Xen-devel [mailto:xen-devel-bounces@lists.xenproject.org] On
> Behalf
> >> Of Paul Durrant
> >> Sent: 28 November 2017 11:31
> >> To: 'Jan Beulich' <JBeulich@suse.com>
> >> Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>; Julien Grall
> >> <julien.grall@arm.com>; xen-devel <xen-devel@lists.xenproject.org>
> >> Subject: Re: [Xen-devel] [PATCH] x86/HVM: fix interaction between
> internal
> >> and extern emulation
> >>
> >> > -----Original Message-----
> >> > From: Jan Beulich [mailto:JBeulich@suse.com]
> >> > Sent: 28 November 2017 11:26
> >> > To: Paul Durrant <Paul.Durrant@citrix.com>
> >> > Cc: Julien Grall <julien.grall@arm.com>; Andrew Cooper
> >> > <Andrew.Cooper3@citrix.com>; xen-devel <xen-
> >> > devel@lists.xenproject.org>
> >> > Subject: RE: [PATCH] x86/HVM: fix interaction between internal and
> extern
> >> > emulation
> >> >
> >> > >>> On 28.11.17 at 12:06, <Paul.Durrant@citrix.com> wrote:
> >> > > Yes, it appears that mmio_retry is only set when the underlying
> >> emulation
> >> > > returned X86EMUL_OKAY but not all reps were completed. If the
> >> > underlying
> >> > > emulation did not return X86EMUL_RETRY then I can't figure out why
> >> > > vio->io_completion should need to be set to anything other than
> >> > > HVMIO_no_completion since any other return value indicates there
> >> should
> >> > be
> >> > > nothing pending.
> >> >
> >> > So am I getting it right that you're suggesting to remove the
> >> > mmio_retry part of the condition in hvm_emulate_one_insn()?
> >> > That looks like it might work (I was previously only considering
> >> > to get rid of mmio_retry altogether, and that didn't look like a
> >> > viable route).
> >>
> >> Yes, that's what I'm suggesting. I really can't see why it is needed. It
> > could
> >> have been a mistake in my original patches or a semantic change in a
> >> subsequent patch, but it certainly looks wrong in current context.
> >> Andrew has just sent me his xtf repro so I'll give the change a go with
> > that.
> >
> > Yes, this patch fixed the problem for me. I'll do some more tests to check
> > for collateral damage now... If it's all good, do you want me to submit it or
> > do you want to send it as a v2 of your patch?
> 
> It's yours, so please submit it (perhaps nevertheless as v2). Feel
> free to add my R-b right away if no other change turns out
> necessary.

Ok. Will do. Thanks,

  Paul

> 
> Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel