xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: George Dunlap <george.dunlap@eu.citrix.com>
To: xen-devel@lists.xensource.com
Cc: george.dunlap@eu.citrix.com
Subject: [PATCH 1 of 3] xl: Replace memset with libxl_device_pci_init
Date: Fri, 11 May 2012 15:11:59 +0100	[thread overview]
Message-ID: <66ee1a4de61a886cad47.1336745519@kodo2> (raw)
In-Reply-To: <patchbomb.1336745518@kodo2>

Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>

diff -r ba3d30d721ee -r 66ee1a4de61a tools/libxl/xl_cmdimpl.c
--- a/tools/libxl/xl_cmdimpl.c	Fri May 11 14:19:50 2012 +0100
+++ b/tools/libxl/xl_cmdimpl.c	Fri May 11 14:45:30 2012 +0100
@@ -2264,7 +2264,7 @@ static void pcidetach(const char *dom, c
 
     find_domain(dom);
 
-    memset(&pcidev, 0x00, sizeof(pcidev));
+    libxl_device_pci_init(&pcidev);
     
     config = xlu_cfg_init(stderr, "command line");
     if (!config) { perror("xlu_cfg_inig"); exit(-1); }
@@ -2309,7 +2309,7 @@ static void pciattach(const char *dom, c
 
     find_domain(dom);
 
-    memset(&pcidev, 0x00, sizeof(pcidev));
+    libxl_device_pci_init(&pcidev);
 
     config = xlu_cfg_init(stderr, "command line");
     if (!config) { perror("xlu_cfg_inig"); exit(-1); }

  reply	other threads:[~2012-05-11 14:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-11 14:11 [PATCH 0 of 3] xl: Some clean-up George Dunlap
2012-05-11 14:11 ` George Dunlap [this message]
2012-05-11 14:12 ` [PATCH 2 of 3] xl: Call xlu_cfg_destroy in the pciattach and pcidetach George Dunlap
2012-05-11 14:12 ` [PATCH 3 of 3] xl: Call xlu_cfg_destroy in main_cpupoolcreate George Dunlap
2012-05-11 16:34 ` [PATCH 0 of 3] xl: Some clean-up Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=66ee1a4de61a886cad47.1336745519@kodo2 \
    --to=george.dunlap@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).