From: Anoob Soman <anoob.soman@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: andrew.cooper3@citrix.com, wei.liu2@citrix.com,
ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH 5/5] hvmloader: Use iPXE ROM loaded from a standalone file
Date: Mon, 19 Mar 2018 14:24:20 +0000 [thread overview]
Message-ID: <6821cfcd-9f0d-08d6-d03c-945d82335c52@citrix.com> (raw)
In-Reply-To: <5AABB7DC02000078001B2B48@prv-mh.provo.novell.com>
On 16/03/18 11:26, Jan Beulich wrote:
>>
>> + /* Physical address of iPXE ROM, loaded by domain builder
>> + * when using ROMBIOS
>> + */
>> + unsigned int *ipxe_rom_addresss;
> Comment style. And can the pointer be to const?
I will fixup the comment style and but making ipxe_rom_address a pointer
to const will require codes changes in hvmloader/rombios.c,
hvmloader/optionroms.c to make all function that use ipxe_rom_address
const as well. Are you fine with changing these files/functions.
-Anoob
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-03-19 14:24 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-15 17:31 Make iPXE a standalone ROM Anoob Soman
2018-03-15 17:31 ` [PATCH 1/5] tools/firmware: Build ipxe as " Anoob Soman
2018-03-16 11:18 ` Jan Beulich
2018-03-16 11:21 ` Andrew Cooper
2018-03-18 1:30 ` Doug Goldstein
2018-03-19 7:48 ` Jan Beulich
2018-03-19 13:52 ` Doug Goldstein
2018-03-15 17:31 ` [PATCH 2/5] tools/firmware: #define IPXE_PATH Anoob Soman
2018-03-21 15:18 ` Wei Liu
2018-03-26 15:53 ` Anoob Soman
2018-03-15 17:31 ` [PATCH 3/5] libxc: Allow loading of firmware modules for HVM guest Anoob Soman
2018-03-18 1:32 ` Doug Goldstein
2018-03-19 14:31 ` Anoob Soman
2018-03-21 15:17 ` Wei Liu
2018-03-26 15:51 ` Anoob Soman
2018-03-15 17:31 ` [PATCH 4/5] libxl: Load iPXE ROM from a file Anoob Soman
2018-03-18 1:34 ` Doug Goldstein
2018-03-21 15:25 ` Wei Liu
2018-03-26 15:51 ` Anoob Soman
2018-03-15 17:31 ` [PATCH 5/5] hvmloader: Use iPXE ROM loaded from a standalone file Anoob Soman
2018-03-16 11:26 ` Jan Beulich
2018-03-16 11:44 ` Andrew Cooper
2018-03-17 16:54 ` Doug Goldstein
2018-03-19 14:24 ` Anoob Soman [this message]
2018-03-19 15:21 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6821cfcd-9f0d-08d6-d03c-945d82335c52@citrix.com \
--to=anoob.soman@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).