From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
Xen-devel <xen-devel@lists.xen.org>
Cc: "Sergey Dyasli" <sergey.dyasli@citrix.com>,
"Kevin Tian" <kevin.tian@intel.com>,
"Wei Liu" <wei.liu2@citrix.com>,
"Jun Nakajima" <jun.nakajima@intel.com>,
"Jan Beulich" <JBeulich@suse.com>,
"Paul Durrant" <paul.durrant@citrix.com>,
"Suravee Suthikulpanit" <suravee.suthikulpanit@amd.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH 3/6] x86: Handle the Xen MSRs via the new guest_{rd, wr}msr() infrastructure
Date: Mon, 26 Feb 2018 14:43:09 -0500 [thread overview]
Message-ID: <6b1992c4-48cd-2f82-71dc-0877e10f029d@oracle.com> (raw)
In-Reply-To: <1519666519-16311-4-git-send-email-andrew.cooper3@citrix.com>
On 02/26/2018 12:35 PM, Andrew Cooper wrote:
> Dispatch from the guest_{rd,wr}msr() functions, after falling through from the
> !is_viridian_domain() case.
>
> Rename {rd,wr}msr_hypervisor_regs() to guest_{rd,wr}msr_xen() for consistency,
> and because the _regs suffix isn't very appropriate.
>
> Update them to take a vcpu pointer rather than presuming that they act on
> current, and switch to using X86EMUL_* return values.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Jun Nakajima <jun.nakajima@intel.com>
> CC: Paul Durrant <paul.durrant@citrix.com>
> CC: Kevin Tian <kevin.tian@intel.com>
> CC: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> CC: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> CC: Wei Liu <wei.liu2@citrix.com>
> CC: Roger Pau Monné <roger.pau@citrix.com>
> CC: Sergey Dyasli <sergey.dyasli@citrix.com>
> ---
> xen/arch/x86/hvm/svm/svm.c | 25 ++++---------------------
> xen/arch/x86/hvm/vmx/vmx.c | 24 ++++--------------------
> xen/arch/x86/msr.c | 8 ++++++++
> xen/arch/x86/pv/emul-priv-op.c | 6 ------
> xen/arch/x86/traps.c | 33 ++++++++++++++++-----------------
> xen/include/asm-x86/processor.h | 4 ++--
> 6 files changed, 34 insertions(+), 66 deletions(-)
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-02-26 19:43 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 17:35 [PATCH 0/6] x86: Switch some bits of MSR handing over to the new infrastructure Andrew Cooper
2018-02-26 17:35 ` [PATCH 1/6] x86/vmx: Simplfy the default cases in vmx_msr_{read, write}_intercept() Andrew Cooper
2018-02-27 1:25 ` Tian, Kevin
2018-02-27 12:43 ` Roger Pau Monné
2018-02-27 13:47 ` Andrew Cooper
2018-02-27 13:47 ` Roger Pau Monné
2018-02-26 17:35 ` [PATCH 2/6] x86/hvm: Handle viridian MSRs via the new guest_{rd, wr}msr() infrastructure Andrew Cooper
2018-02-26 19:17 ` Boris Ostrovsky
2018-02-27 1:27 ` Tian, Kevin
2018-02-27 14:13 ` Roger Pau Monné
2018-02-28 18:14 ` Andrew Cooper
2018-02-27 14:38 ` Paul Durrant
2018-02-28 18:22 ` Andrew Cooper
2018-03-01 11:08 ` Paul Durrant
2018-02-28 16:40 ` Jan Beulich
2018-02-28 18:32 ` Andrew Cooper
2018-03-01 9:58 ` Jan Beulich
2018-03-01 12:29 ` Andrew Cooper
2018-03-01 12:50 ` Jan Beulich
2018-02-26 17:35 ` [PATCH 3/6] x86: Handle the Xen " Andrew Cooper
2018-02-26 19:43 ` Boris Ostrovsky [this message]
2018-02-27 1:28 ` Tian, Kevin
2018-02-27 14:30 ` Roger Pau Monné
2018-02-28 16:45 ` Jan Beulich
2018-02-26 17:35 ` [PATCH 4/6] x86/hvm: Constify the read side of vlapic handling Andrew Cooper
2018-02-27 14:36 ` Roger Pau Monné
2018-02-28 16:48 ` Jan Beulich
2018-02-26 17:35 ` [PATCH 5/6] x86/hvm: Handle x2apic MSRs the new guest_{rd, wr}msr() infrastructure Andrew Cooper
2018-02-27 15:01 ` Roger Pau Monné
2018-02-28 16:58 ` Jan Beulich
2018-02-26 17:35 ` [PATCH 6/6] x86/msr: Blacklist various MSRs which guests definitely shouldn't be using Andrew Cooper
2018-02-27 15:15 ` Roger Pau Monné
2018-03-01 11:07 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b1992c4-48cd-2f82-71dc-0877e10f029d@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=paul.durrant@citrix.com \
--cc=roger.pau@citrix.com \
--cc=sergey.dyasli@citrix.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).