Re: [PATCH] Xen: Force non-irq keyhandler to be run in tasklet when receive a debugkey from serial port

["Lan, Tianyu" <tianyu.lan@intel.com>]

On 10/24/2016 10:31 PM, Jan Beulich wrote:
>>>> On 24.10.16 at 16:15, <tianyu.lan@intel.com> wrote:
>
>>
>> On 10/24/2016 9:54 PM, Jan Beulich wrote:
>>>>>> On 24.10.16 at 15:29, <tianyu.lan@intel.com> wrote:
>>>> On 10/24/2016 8:19 AM, Konrad Rzeszutek Wilk wrote:
>>>>> On Sat, Oct 22, 2016 at 07:23:03PM +0800, Lan Tianyu wrote:
>>>>>> __serial_rx() runs in either irq handler or timer handler and non-irq
>>>>>> keyhandler should not run in these contexts. So always force non-irq
>>>>>> keyhandler to run in tasklet when receive a debugkey from serial port
>>>>>
>>>>> If the machine is hung with an IRQ handler being stuck, and
>>>>> one does 'Ctrl-Ax3` followed by 'C' .. which would not be invoked
>>>>> (as it is not an IRQ handler??
>>>>
>>>> If serial port's interrupt still works in this case, the 'C'
>>>> keyhandler kexec_crash() will be invoked in a tasklet. This behavior was
>>>> changed by my patches if includes this patch.
>>
>> Sorry. A typo. I meant the behavior wasn't changed by my patches.
>
> How was it not? The softirq machinery didn't get invoked in that case
> prior to your patch, afaict.
>

Which softirq? You mean addiing process_pending_softirqs() in the
dump_timerq()?

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel