Re: [PATCH 01/14] fuzz/x86_emulate: Remove redundant AFL hook

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 25/08/17 17:43, George Dunlap wrote:
> You don't need __AFL_INIT if you have __AFL_LOOP.
>
> Signed-off-by: George Dunlap <george.dunlap@citrix.com>

Really?  Is that covered in any documentation?

I got the contrary impression from whichever version of AFL I was using
when I put this in, and a quick look over the afl-fuzz source doesn't
appear to equate them in any way.

~Andrew

> ---
> CC: Ian Jackson <ian.jackson@citrix.com>
> CC: Wei Liu <wei.liu2@citrix.com>
> CC: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Jan Beulich <jbeulich@suse.com>
> ---
>  tools/fuzz/x86_instruction_emulator/afl-harness.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/tools/fuzz/x86_instruction_emulator/afl-harness.c b/tools/fuzz/x86_instruction_emulator/afl-harness.c
> index 154869336a..1a79ff228e 100644
> --- a/tools/fuzz/x86_instruction_emulator/afl-harness.c
> +++ b/tools/fuzz/x86_instruction_emulator/afl-harness.c
> @@ -63,8 +63,6 @@ int main(int argc, char **argv)
>          exit(-1);
>  
>  #ifdef __AFL_HAVE_MANUAL_CONTROL
> -    __AFL_INIT();
> -
>      while ( __AFL_LOOP(1000) )
>  #endif
>      {


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel