From: Julien Grall <julien.grall@linaro.org>
To: Ian Jackson <ian.jackson@eu.citrix.com>,
Anthony PERARD <anthony.perard@citrix.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH] tools/Makefile: unset MAKELEVEL before building QEMU
Date: Fri, 20 Oct 2017 10:52:56 +0100 [thread overview]
Message-ID: <6d33666c-d722-c09e-2e69-ae3c028374e4@linaro.org> (raw)
In-Reply-To: <23016.49812.479723.573787@mariner.uk.xensource.com>
Hi,
On 19/10/17 16:19, Ian Jackson wrote:
> Anthony PERARD writes ("[PATCH] tools/Makefile: unset MAKELEVEL before building QEMU"):
>> Since QEMU commits aef45d51d1204f3335fb99de6658e0c5612c2b67
>> "build: automatically handle GIT submodule checkout for dtc"
>> the QEMU makefiles rely on the variable MAKELEVEL to make a decision on
>> whether to update some git submodules or not. Since we call QEMU build
>> from within the Xen one, MAKELEVEL would already be greater than 0 and
>> the git submodules would not be updated and QEMU would fail to build.
>>
>> Fix this by removing MAKELEVEL from the environment before trying to
>> build QEMU.
>
> Urgh.
>
> I think this is a bug in the qemu makefiles. But also, use of git
> submodules is a bug in itself. None of that is likely to be fixed.
>
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Release-acked-by: Julien Grall <julien.grall@linaro.org>
Cheers,
>
> Ian.
>
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2017-10-20 9:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 14:29 [PATCH] tools/Makefile: unset MAKELEVEL before building QEMU Anthony PERARD
2017-10-19 15:19 ` Ian Jackson
2017-10-20 9:52 ` Julien Grall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d33666c-d722-c09e-2e69-ae3c028374e4@linaro.org \
--to=julien.grall@linaro.org \
--cc=anthony.perard@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).