* [PATCH for-4.21] tools/tests/domid: don't pass -E to sed
@ 2025-10-20 13:40 Jan Beulich
2025-10-20 15:00 ` Andrew Cooper
2025-10-20 15:57 ` Oleksii Kurochko
0 siblings, 2 replies; 3+ messages in thread
From: Jan Beulich @ 2025-10-20 13:40 UTC (permalink / raw)
To: xen-devel@lists.xenproject.org
Cc: Anthony PERARD, Oleksii Kurochko, Denis Mukhin
Even the 2018 edition of The Open Group Base Specifications Issue 7 [1]
doesn't name -E as a standard option; only Issue 8 [2] does. As we can
easily avoid anything "extended" about the expression used, drop the -E,
escape the parentheses, and replace the sole + by *.
[1] https://pubs.opengroup.org/onlinepubs/9699919799/
[2] https://pubs.opengroup.org/onlinepubs/9799919799/
Fixes: b3d31533a047 ("tools/tests: introduce unit tests for domain ID allocator")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/tools/tests/domid/Makefile
+++ b/tools/tests/domid/Makefile
@@ -10,8 +10,8 @@ include $(XEN_ROOT)/tools/Rules.mk
TESTS := test-domid
define list-c-headers
-$(shell sed -n -E \
- 's/^[ \t]*# *include[ \t]*[<"]([^">]+)[">].*/\1/p' $(1) 2>/dev/null)
+$(shell sed -n \
+ 's/^[ \t]*# *include[ \t]*[<"]\([^">]*\)[">].*/\1/p' $(1) 2>/dev/null)
endef
# NB: $1 cannot be a list
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH for-4.21] tools/tests/domid: don't pass -E to sed
2025-10-20 13:40 [PATCH for-4.21] tools/tests/domid: don't pass -E to sed Jan Beulich
@ 2025-10-20 15:00 ` Andrew Cooper
2025-10-20 15:57 ` Oleksii Kurochko
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Cooper @ 2025-10-20 15:00 UTC (permalink / raw)
To: Jan Beulich, xen-devel@lists.xenproject.org
Cc: Anthony PERARD, Oleksii Kurochko, Denis Mukhin
On 20/10/2025 2:40 pm, Jan Beulich wrote:
> Even the 2018 edition of The Open Group Base Specifications Issue 7 [1]
> doesn't name -E as a standard option; only Issue 8 [2] does. As we can
> easily avoid anything "extended" about the expression used, drop the -E,
> escape the parentheses, and replace the sole + by *.
>
> [1] https://pubs.opengroup.org/onlinepubs/9699919799/
> [2] https://pubs.opengroup.org/onlinepubs/9799919799/
>
> Fixes: b3d31533a047 ("tools/tests: introduce unit tests for domain ID allocator")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH for-4.21] tools/tests/domid: don't pass -E to sed
2025-10-20 13:40 [PATCH for-4.21] tools/tests/domid: don't pass -E to sed Jan Beulich
2025-10-20 15:00 ` Andrew Cooper
@ 2025-10-20 15:57 ` Oleksii Kurochko
1 sibling, 0 replies; 3+ messages in thread
From: Oleksii Kurochko @ 2025-10-20 15:57 UTC (permalink / raw)
To: Jan Beulich, xen-devel@lists.xenproject.org; +Cc: Anthony PERARD, Denis Mukhin
[-- Attachment #1: Type: text/plain, Size: 1063 bytes --]
On 10/20/25 3:40 PM, Jan Beulich wrote:
> Even the 2018 edition of The Open Group Base Specifications Issue 7 [1]
> doesn't name -E as a standard option; only Issue 8 [2] does. As we can
> easily avoid anything "extended" about the expression used, drop the -E,
> escape the parentheses, and replace the sole + by *.
>
> [1]https://pubs.opengroup.org/onlinepubs/9699919799/
> [2]https://pubs.opengroup.org/onlinepubs/9799919799/
>
> Fixes: b3d31533a047 ("tools/tests: introduce unit tests for domain ID allocator")
> Signed-off-by: Jan Beulich<jbeulich@suse.com>
Release-Acked-by: Oleksii Kurochko<oleksii.kurochko@gmail.com>
~ Oleksii
>
> --- a/tools/tests/domid/Makefile
> +++ b/tools/tests/domid/Makefile
> @@ -10,8 +10,8 @@ include $(XEN_ROOT)/tools/Rules.mk
> TESTS := test-domid
>
> define list-c-headers
> -$(shell sed -n -E \
> - 's/^[ \t]*# *include[ \t]*[<"]([^">]+)[">].*/\1/p' $(1) 2>/dev/null)
> +$(shell sed -n \
> + 's/^[ \t]*# *include[ \t]*[<"]\([^">]*\)[">].*/\1/p' $(1) 2>/dev/null)
> endef
>
> # NB: $1 cannot be a list
[-- Attachment #2: Type: text/html, Size: 1926 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-20 15:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-20 13:40 [PATCH for-4.21] tools/tests/domid: don't pass -E to sed Jan Beulich
2025-10-20 15:00 ` Andrew Cooper
2025-10-20 15:57 ` Oleksii Kurochko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).