xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@linaro.org>
To: mjaggi@caviumnetworks.com, xen-devel@lists.xenproject.org
Cc: Andre.Przywara@arm.com, julien.grall@arm.com,
	sstabellini@kernel.org, Manish Jaggi <mjaggi@cavium.com>
Subject: Re: [PATCH v5 5/5] ARM: ITS: Expose ITS in the MADT table
Date: Tue, 10 Oct 2017 11:17:54 +0100	[thread overview]
Message-ID: <6e9eceb8-d9fc-69f6-4961-59a207dccdae@linaro.org> (raw)
In-Reply-To: <1507616218-2478-6-git-send-email-mjaggi@caviumnetworks.com>

Hi Manish,

On 10/10/17 07:16, mjaggi@caviumnetworks.com wrote:
> From: Manish Jaggi <mjaggi@cavium.com>
> 
> Add gicv3_its_make_hwdom_madt to update hwdom MADT ITS information.
> 
> Reviewed-by: Andre Przywara <andre.przywara@arm.com>
> Signed-off-by: Manish Jaggi <mjaggi@cavium.com>
> ---
>   xen/arch/arm/gic-v3-its.c        | 19 +++++++++++++++++++
>   xen/arch/arm/gic-v3.c            |  2 ++
>   xen/include/asm-arm/gic_v3_its.h |  8 ++++++++
>   3 files changed, 29 insertions(+)
> 
> diff --git a/xen/arch/arm/gic-v3-its.c b/xen/arch/arm/gic-v3-its.c
> index 7746ae8..3fa592c 100644
> --- a/xen/arch/arm/gic-v3-its.c
> +++ b/xen/arch/arm/gic-v3-its.c
> @@ -1062,6 +1062,25 @@ void gicv3_its_acpi_init(void)
>       acpi_table_parse_madt(ACPI_MADT_TYPE_GENERIC_TRANSLATOR,
>                             gicv3_its_acpi_probe, 0);
>   }
> +
> +unsigned long gicv3_its_make_hwdom_madt(const struct domain *d, void *base_ptr)
> +{
> +    unsigned long i = 0;

vgic_v3_its_count(..) return an unsigned int. So no need to use unsigned 
long here.

With that fixed:

Acked-by: Julien Grall <julien.grall@linaro.org>

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

      reply	other threads:[~2017-10-10 10:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-10  6:16 [PATCH v5 0/5] ARM: ACPI: ITS: Add ITS Support for ACPI hardware domain mjaggi
2017-10-10  6:16 ` [PATCH v5 1/5] ARM: ITS: Introduce common function add_to_host_its_list mjaggi
2017-10-10  6:16 ` [PATCH v5 2/5] ARM: ITS: Populate host_its_list from ACPI MADT Table mjaggi
2017-10-10 10:04   ` Julien Grall
2017-10-10  6:16 ` [PATCH v5 3/5] ARM: ITS: Deny hardware domain access to ITS mjaggi
2017-10-10 10:11   ` Julien Grall
2017-10-10  6:16 ` [PATCH v5 4/5] ARM: Update Formula to compute MADT size using new callbacks in gic_hw_operations mjaggi
2017-10-10  9:10   ` Andre Przywara
2017-10-10 10:14   ` Julien Grall
2017-10-10 10:33     ` Manish Jaggi
2017-10-10 10:42       ` Julien Grall
2017-10-10  6:16 ` [PATCH v5 5/5] ARM: ITS: Expose ITS in the MADT table mjaggi
2017-10-10 10:17   ` Julien Grall [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6e9eceb8-d9fc-69f6-4961-59a207dccdae@linaro.org \
    --to=julien.grall@linaro.org \
    --cc=Andre.Przywara@arm.com \
    --cc=julien.grall@arm.com \
    --cc=mjaggi@cavium.com \
    --cc=mjaggi@caviumnetworks.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).