From: Julien Grall <julien.grall@arm.com>
To: Sergej Proskurin <proskurin@sec.in.tum.de>, xen-devel@lists.xen.org
Cc: Andre Przywara <andre.przywara@arm.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Steve Capper <Steve.Capper@arm.com>,
Wei Chen <Wei.Chen@linaro.org>
Subject: Re: [PATCH v2 5/6] xen/arm: traps: Avoid unnecessary VA -> IPA translation in abort handlers
Date: Wed, 27 Jul 2016 18:40:42 +0100 [thread overview]
Message-ID: <6fd4f736-53dd-3b99-99f2-66f5a944492e@arm.com> (raw)
In-Reply-To: <651849e6-6e39-9340-eb64-77e521a9f212@sec.in.tum.de>
On 27/07/16 18:28, Sergej Proskurin wrote:
> Hi Julien,
Hello Sergej,
Please reply to all (or at least CC me) when answering to xen-devel.
Otherwise your mail may be missed or the answer may be delayed because I
filter any mail where I am not the recipients (a lot of people do this
on the ML).
>
> On 07/27/2016 07:09 PM, Julien Grall wrote:
>> @@ -2442,7 +2458,7 @@ static void do_trap_data_abort_guest(struct cpu_user_regs *regs,
>> info.gva = READ_SYSREG64(FAR_EL2);
>> #endif
>>
>> - if ( dabt.s1ptw )
>> + if ( hpfar_is_valid(hsr.iabt.s1ptw, fsc) )
>
> I belive this should be:
>
> hpfar_is_valid(hsr.*dabt*.s1ptw, fsc)
You are right, I did not spot it during my testing because the field is
exactly the same bits in the HSR.
>
>> info.gpa = get_faulting_ipa(info.gva);
>> else
>> {
>> @@ -2451,7 +2467,7 @@ static void do_trap_data_abort_guest(struct cpu_user_regs *regs,
>> return; /* Try again */
>> }
>>
>> - switch ( dabt.dfsc & ~FSC_LL_MASK )
>> + switch ( fsc )
>> {
>> case FSC_FLT_PERM:
>> {
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-07-27 17:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-27 17:09 [PATCH v2 0/6] xen/arm: Simplify do_trap_*_abort_guest Julien Grall
2016-07-27 17:09 ` [PATCH v2 1/6] xen/arm: traps: Simplify the switch in do_trap_*_abort_guest Julien Grall
2016-07-28 19:41 ` Stefano Stabellini
2016-07-27 17:09 ` [PATCH v2 2/6] xen/arm: Provide macros to help creating workaround helpers Julien Grall
2016-07-28 19:42 ` Stefano Stabellini
2016-07-27 17:09 ` [PATCH v2 3/6] xen/arm: Use check_workaround to handle the erratum 766422 Julien Grall
2016-07-28 19:43 ` Stefano Stabellini
2016-07-27 17:09 ` [PATCH v2 4/6] xen/arm: traps: MMIO should only be emulated for fault translation Julien Grall
2016-07-27 17:09 ` [PATCH v2 5/6] xen/arm: traps: Avoid unnecessary VA -> IPA translation in abort handlers Julien Grall
2016-07-27 17:28 ` Sergej Proskurin
2016-07-27 17:40 ` Julien Grall [this message]
2016-08-17 2:19 ` Shanker Donthineni
2016-08-17 11:11 ` Julien Grall
2016-08-17 20:08 ` Shanker Donthineni
2016-08-18 12:02 ` Julien Grall
2016-07-27 17:09 ` [PATCH v2 6/6] xen/arm: arm64: Add Cortex-A57 erratum 834220 workaround Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fd4f736-53dd-3b99-99f2-66f5a944492e@arm.com \
--to=julien.grall@arm.com \
--cc=Steve.Capper@arm.com \
--cc=Wei.Chen@linaro.org \
--cc=andre.przywara@arm.com \
--cc=proskurin@sec.in.tum.de \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).