xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Juergen Gross <juergen.gross@ts.fujitsu.com>
To: xen-devel@lists.xensource.com
Subject: [PATCH] Avoid panic when adjusting sedf parameters
Date: Thu, 17 Nov 2011 13:33:34 +0100	[thread overview]
Message-ID: <7167eaa187b3cd996637.1321533214@nehalem1> (raw)

[-- Attachment #1: Type: text/plain, Size: 233 bytes --]

When using sedf scheduler in a cpupool the system might panic when setting
sedf scheduling parameters for a domain.

Signed-off-by: juergen.gross@ts.fujitsu.com


1 file changed, 4 insertions(+)
xen/common/sched_sedf.c |    4 ++++



[-- Attachment #2: xen-staging.hg.patch --]
[-- Type: text/x-patch, Size: 1214 bytes --]

# HG changeset patch
# User Juergen Gross <juergen.gross@ts.fujitsu.com>
# Date 1321533195 -3600
# Node ID 7167eaa187b3cd996637b1f995707ff9196d00d3
# Parent  fd3567cafe1c7ccd0ddba0ad7fb067d435e13529
Avoid panic when adjusting sedf parameters

When using sedf scheduler in a cpupool the system might panic when setting
sedf scheduling parameters for a domain.

Signed-off-by: juergen.gross@ts.fujitsu.com

diff -r fd3567cafe1c -r 7167eaa187b3 xen/common/sched_sedf.c
--- a/xen/common/sched_sedf.c	Tue Nov 15 14:50:18 2011 +0100
+++ b/xen/common/sched_sedf.c	Thu Nov 17 13:33:15 2011 +0100
@@ -1304,6 +1304,8 @@ static void sedf_dump_cpu_state(const st
     rcu_read_lock(&domlist_read_lock);
     for_each_domain ( d )
     {
+        if ( (d->cpupool ? d->cpupool->sched : &sched_sedf_def) != ops )
+            continue;
         for_each_vcpu(d, ed)
         {
             if ( !__task_on_queue(ed) && (ed->processor == i) )
@@ -1369,6 +1371,8 @@ static int sedf_adjust_weights(struct cp
     rcu_read_lock(&domlist_read_lock);
     for_each_domain( d )
     {
+        if ( c != d->cpupool )
+            continue;
         for_each_vcpu ( d, p )
         {
             if ( (cpu = p->processor) >= nr_cpus )

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

             reply	other threads:[~2011-11-17 12:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-17 12:33 Juergen Gross [this message]
2011-11-17 12:43 ` [PATCH] Avoid panic when adjusting sedf parameters George Dunlap
2011-11-17 13:07   ` Juergen Gross
  -- strict thread matches above, loose matches on Subject: below --
2011-11-17 13:03 Juergen Gross
2011-11-17 13:30 ` Jan Beulich
2011-11-17 13:48   ` Keir Fraser
2011-11-17 14:02     ` Juergen Gross
2011-11-17 13:52   ` Keir Fraser
2011-11-17 14:04     ` Juergen Gross
2011-11-17 14:32       ` Jan Beulich
2011-11-17 14:41         ` Juergen Gross
2011-11-17 14:29     ` Jan Beulich
2011-11-17 14:37 Juergen Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7167eaa187b3cd996637.1321533214@nehalem1 \
    --to=juergen.gross@ts.fujitsu.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).