From: Julien Grall <julien.grall@linaro.org>
To: Manish Jaggi <mjaggi@caviumnetworks.com>,
xen-devel@lists.xen.org, marc.zyngier@arm.com,
sstabellini@kernel.org, andre.przywara@linaro.org
Cc: manish.jaggi@cavium.com
Subject: Re: [PATCH 03/10] arm64: Add ICV_BPR1_EL1 handler
Date: Thu, 1 Feb 2018 10:55:35 +0000 [thread overview]
Message-ID: <75e4ca19-85c0-79d6-73e5-9ae4a4422a62@linaro.org> (raw)
In-Reply-To: <f7bd2403-a9cd-c434-80f7-1b5df50cfdde@caviumnetworks.com>
Hi Manish,
On 01/02/18 08:57, Manish Jaggi wrote:
> On 01/25/2018 10:14 PM, Julien Grall wrote:
>> Hi Manish,
>>
>> On 16/01/18 15:42, mjaggi@caviumnetworks.com wrote:
>>> From: Manish Jaggi <manish.jaggi@cavium.com>
>>>
>>> Add a handler for reading/writing the guest's view of the ICC_BPR1_EL1
>>> register, which is located in the ICH_VMCR_EL2.BPR1 field.
>>
>> This commit (and likely the followings) is coming from Linux, right?
>> If it matches commit from Linux, then you need to keep tags and point
>> to the Linux commit. See commit 7762c2d6f4 in Xen as an example to how
>> to do it.
>>
>> If you make changes for Xen, then write "Adapted for Xen...".
> ok
>>
>> But looking at the patch the major difference is you use Xen coding
>> style. The rest is pretty much use Xen name for access register and
>> adding missing define.
>>
>> I think it would be beneficial for Xen to re-use Linux code. The
>> compatibility layer should be very limited. Stefano any opinions?
> So when you mean linux code, you refer to a patch or importing the code
> file from linux ?
Importing the code from Linux. And then a patch to adapt for Xen (it
should be fairly small).
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-02-01 10:55 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 15:42 [RFC PATCH 00/10] arm64: Mediate access to GICv3 sysregs at EL2 mjaggi
2018-01-16 15:42 ` [RFC PATCH 01/10] Add CONFIG_VGIC_ERRATA mjaggi
2018-01-25 13:48 ` Julien Grall
2018-02-21 15:17 ` Manish Jaggi
2018-02-21 15:56 ` Julien Grall
2018-01-16 15:42 ` [RFC PATCH 02/10] arm64: Add hook to handle guest GICv3 sysreg accesses mjaggi
2018-01-25 16:17 ` Julien Grall
2018-01-25 18:07 ` Julien Grall
2018-02-01 8:51 ` Manish Jaggi
2018-02-01 10:54 ` Julien Grall
2018-02-26 6:42 ` Manish Jaggi
2018-02-26 6:58 ` Manish Jaggi
2018-02-26 10:43 ` Julien Grall
2018-01-16 15:42 ` [PATCH 03/10] arm64: Add ICV_BPR1_EL1 handler mjaggi
2018-01-25 16:44 ` Julien Grall
2018-02-01 8:57 ` Manish Jaggi
2018-02-01 10:55 ` Julien Grall [this message]
2018-01-16 15:42 ` [PATCH 04/10] arm64: Add ICV_IGRPEN1_EL1 handler mjaggi
2018-01-16 15:43 ` [PATCH 05/10] arm64: Add accessors for the ICH_APxRn_EL2 registers mjaggi
2018-01-16 15:43 ` [PATCH 06/10] Expose gicv3_ich_read/write_lr mjaggi
2018-01-25 16:52 ` Julien Grall
2018-02-01 8:54 ` Manish Jaggi
2018-01-16 15:43 ` [PATCH 07/10] arm64: Add ICV_IAR1_EL1 handler mjaggi
2018-01-16 15:43 ` [PATCH 08/10] Add ICV_EOIR1_EL1 handler mjaggi
2018-01-16 15:43 ` [PATCH 09/10] arm64: Add a handler for ICV_HPPIR1_EL1 mjaggi
2018-01-16 15:43 ` [PATCH 10/10] Enable Trapping of Group1 registers which is controlled by command line mjaggi
2018-01-25 17:00 ` Julien Grall
2018-02-01 8:53 ` Manish Jaggi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75e4ca19-85c0-79d6-73e5-9ae4a4422a62@linaro.org \
--to=julien.grall@linaro.org \
--cc=andre.przywara@linaro.org \
--cc=manish.jaggi@cavium.com \
--cc=marc.zyngier@arm.com \
--cc=mjaggi@caviumnetworks.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).