From: Paul Durrant <Paul.Durrant@citrix.com>
To: 'Jan Beulich' <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v3] x86/hvm: remove default ioreq server
Date: Wed, 8 Aug 2018 10:39:18 +0000 [thread overview]
Message-ID: <762f1ad90c794a358c848fb3f5f9c9f2@AMSPEX02CL03.citrite.net> (raw)
In-Reply-To: <5B6AC1D102000078001DBEDC@prv1-mh.provo.novell.com>
> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@suse.com]
> Sent: 08 August 2018 11:11
> To: Paul Durrant <Paul.Durrant@citrix.com>
> Cc: xen-devel <xen-devel@lists.xenproject.org>
> Subject: Re: [PATCH v3] x86/hvm: remove default ioreq server
>
> >>> On 07.08.18 at 17:42, <paul.durrant@citrix.com> wrote:
> > My recent patch [1] to qemu-xen-traditional removes the last use of the
> > 'default' ioreq server in Xen. (This is a catch-all ioreq server that is
> > used if no explicitly registered I/O range is targetted).
> >
> > This patch can be applied once that patch is committed, to remove the
> > (>100 lines of) redundant code in Xen.
> >
> > NOTE: The removal of the special case for HVM_PARAM_DM_DOMAIN in
> > hvm_allow_set_param() is not directly related to removal of
> > default ioreq servers. It could have been cleaned up at any time
> > after commit 9a422c03 "x86/hvm: stop passing explicit domid to
> > hvm_create_ioreq_server()". It is now added to the new
> > deprecated sets introduced by this patch.
> >
> > [1] https://lists.xenproject.org/archives/html/xen-devel/2018-
> 08/msg00270.html
> >
> > Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
> > Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
Thanks.
> with one more cosmetic adjustment:
>
> > --- a/xen/include/public/hvm/params.h
> > +++ b/xen/include/public/hvm/params.h
> > @@ -81,9 +81,13 @@
> > #define HVM_PARAM_PAE_ENABLED 4
> >
> > #define HVM_PARAM_IOREQ_PFN 5
> > -
> > #define HVM_PARAM_BUFIOREQ_PFN 6
> > +
> > +#ifdef __XEN__
> > +/* These parameters is deprecated and its meaning is undefined */
> > +#define HVM_PARAM_DM_DOMAIN 13
> > #define HVM_PARAM_BUFIOREQ_EVTCHN 26
> > +#endif
>
> The comment was only partly switched to plural.
>
Oh, so it was. I guess this can be fixed on commit unless you'd prefer I send a v4.
Paul
> Jan
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-08-08 10:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-07 15:42 [PATCH v3] x86/hvm: remove default ioreq server Paul Durrant
2018-08-08 10:11 ` Jan Beulich
2018-08-08 10:39 ` Paul Durrant [this message]
2018-08-08 10:48 ` Jan Beulich
2018-08-08 11:38 ` Andrew Cooper
2018-08-08 11:50 ` Jan Beulich
2018-08-27 13:22 ` Jan Beulich
2018-09-03 9:50 ` Paul Durrant
2018-09-03 10:02 ` Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=762f1ad90c794a358c848fb3f5f9c9f2@AMSPEX02CL03.citrite.net \
--to=paul.durrant@citrix.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).