From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@citrix.com>
Subject: Re: [PATCH v2 04/10] xen: credit2: only reset credit on
 reset condition
Date: Fri, 30 Sep 2016 12:28:41 +0100
Message-ID: <764d297c-854e-a33c-4e7b-191ab0027469@citrix.com>
References: <147520253247.22544.10673844222866363947.stgit@Solace.fritz.box>
 <147520402650.22544.2188671255927985759.stgit@Solace.fritz.box>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta6.messagelabs.com ([193.109.254.103])
 by lists.xenproject.org with esmtp (Exim 4.84_2)
 (envelope-from <prvs=074692794=George.Dunlap@citrix.com>)
 id 1bpvzi-0004rB-2x
 for xen-devel@lists.xenproject.org; Fri, 30 Sep 2016 11:28:46 +0000
In-Reply-To: <147520402650.22544.2188671255927985759.stgit@Solace.fritz.box>
List-Unsubscribe: <https://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <https://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Dario Faggioli <dario.faggioli@citrix.com>, xen-devel@lists.xenproject.org
Cc: George Dunlap <george.dunlap@eu.citrix.com>, Anshul Makkar <anshul.makkar@citrix.com>
List-Id: xen-devel@lists.xenproject.org

T24gMzAvMDkvMTYgMDM6NTMsIERhcmlvIEZhZ2dpb2xpIHdyb3RlOgo+IFRoZSBjb25kaXRpb24g
Zm9yIGEgQ3JlZGl0MiBzY2hlZHVsaW5nIGVwb2NoIGNvbWluZyB0byBhbgo+IGVuZCBpcyB0aGF0
IHRoZSB2Y3B1IGF0IHRoZSBmcm9udCBvZiB0aGUgcnVucXVldWUgaGFzIG5lZ2F0aXZlCj4gY3Jl
ZGl0cy4gSG93ZXZlciwgaXQgaXMgcG9zc2libGUsIHRoYXQgcnVucV9jYW5kaWRhdGUoKSBkb2Vz
Cj4gbm90IGFjdHVhbGx5IHJldHVybiB0byB0aGUgc2NoZWR1bGVyIHRoZSBmaXJzdCB2Y3B1IGlu
IHRoZQo+IHJ1bnF1ZXVlIChlLmcuLCBiZWNhdXNlIHN1Y2ggdmNwdSBjYW4ndCBydW4gb24gdGhl
IGNwdSB0aGF0Cj4gaXMgZ29pbmcgdGhyb3VnaCB0aGUgc2NoZWR1bGVyLCBiZWNhdXNlIG9mIGhh
cmQtYWZmaW5pdHkpLgo+IAo+IElmIHRoYXQgaGFwcGVucywgd2Ugc2hvdWxkIG5vdCB0cmlnZ2Vy
IGEgY3JlZGl0IHJlc2V0LCBvciB3ZQo+IHJpc2sgYWx0ZXJpbmcgdGhlIGxlbmdodCBvZiBhIHNj
aGVkdWxlciBlcG9jaCwgd3J0IHdoYXQgdGhlCj4gb3JpZ2luYWwgaWRlYSBvZiB0aGUgYWxnb3Jp
dGhtIHdhcy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBEYXJpbyBGYWdnaW9saSA8ZGFyaW8uZmFnZ2lv
bGlAY2l0cml4LmNvbT4KClJldmlld2VkLWJ5OiBHZW9yZ2UgRHVubGFwIDxnZW9yZ2UuZHVubGFw
QGNpdHJpeC5jb20+Cgo+IC0tLQo+IENjOiBHZW9yZ2UgRHVubGFwIDxnZW9yZ2UuZHVubGFwQGV1
LmNpdHJpeC5jb20+Cj4gQ2M6IEFuc2h1bCBNYWtrYXIgPGFuc2h1bC5tYWtrYXJAY2l0cml4LmNv
bT4KPiAtLS0KPiBDaGFuZ2VzIGZyb20gdjE6Cj4gICogbmV3IHBhdGNoLCBjb250YWluaW5nIHBh
cnQgb2Ygd2hhdCB3YXMgaW4gcGF0Y2ggNTsKPiAgKiAod3J0IHYxIHBhdGNoIDUpICdwb3MnIHBh
cmFtZXRlciB0byBydW5xX2NhbmRpZGF0ZSByZW5hbWVkICdza2lwcGVkJywgYXMKPiAgICByZXF1
ZXN0ZWQgZHVyaW5nIHJldmlldy4KPiAtLS0KPiAgeGVuL2NvbW1vbi9zY2hlZF9jcmVkaXQyLmMg
fCAgIDMzICsrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLQo+ICAxIGZpbGUgY2hhbmdl
ZCwgMjggaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEveGVu
L2NvbW1vbi9zY2hlZF9jcmVkaXQyLmMgYi94ZW4vY29tbW9uL3NjaGVkX2NyZWRpdDIuYwo+IGlu
ZGV4IDM5ODY0NDEuLjcyZTMxYjUgMTAwNjQ0Cj4gLS0tIGEveGVuL2NvbW1vbi9zY2hlZF9jcmVk
aXQyLmMKPiArKysgYi94ZW4vY29tbW9uL3NjaGVkX2NyZWRpdDIuYwo+IEBAIC0yMjQ0LDEyICsy
MjQ0LDE1IEBAIHZvaWQgX19kdW1wX2V4ZWNzdGF0ZSh2b2lkICp1bnVzZWQpOwo+ICBzdGF0aWMg
c3RydWN0IGNzY2hlZDJfdmNwdSAqCj4gIHJ1bnFfY2FuZGlkYXRlKHN0cnVjdCBjc2NoZWQyX3J1
bnF1ZXVlX2RhdGEgKnJxZCwKPiAgICAgICAgICAgICAgICAgc3RydWN0IGNzY2hlZDJfdmNwdSAq
c2N1cnIsCj4gLSAgICAgICAgICAgICAgIGludCBjcHUsIHNfdGltZV90IG5vdykKPiArICAgICAg
ICAgICAgICAgaW50IGNwdSwgc190aW1lX3Qgbm93LAo+ICsgICAgICAgICAgICAgICB1bnNpZ25l
ZCBpbnQgKnNraXBwZWQpCj4gIHsKPiAgICAgIHN0cnVjdCBsaXN0X2hlYWQgKml0ZXI7Cj4gICAg
ICBzdHJ1Y3QgY3NjaGVkMl92Y3B1ICpzbmV4dCA9IE5VTEw7Cj4gICAgICBzdHJ1Y3QgY3NjaGVk
Ml9wcml2YXRlICpwcnYgPSBDU0NIRUQyX1BSSVYocGVyX2NwdShzY2hlZHVsZXIsIGNwdSkpOwo+
ICAKPiArICAgICpza2lwcGVkID0gMDsKPiArCj4gICAgICAvKiBEZWZhdWx0IHRvIGN1cnJlbnQg
aWYgcnVubmFibGUsIGlkbGUgb3RoZXJ3aXNlICovCj4gICAgICBpZiAoIHZjcHVfcnVubmFibGUo
c2N1cnItPnZjcHUpICkKPiAgICAgICAgICBzbmV4dCA9IHNjdXJyOwo+IEBAIC0yMjczLDcgKzIy
NzYsMTAgQEAgcnVucV9jYW5kaWRhdGUoc3RydWN0IGNzY2hlZDJfcnVucXVldWVfZGF0YSAqcnFk
LAo+ICAKPiAgICAgICAgICAvKiBPbmx5IGNvbnNpZGVyIHZjcHVzIHRoYXQgYXJlIGFsbG93ZWQg
dG8gcnVuIG9uIHRoaXMgcHJvY2Vzc29yLiAqLwo+ICAgICAgICAgIGlmICggIWNwdW1hc2tfdGVz
dF9jcHUoY3B1LCBzdmMtPnZjcHUtPmNwdV9oYXJkX2FmZmluaXR5KSApCj4gKyAgICAgICAgewo+
ICsgICAgICAgICAgICAoKnNraXBwZWQpKys7Cj4gICAgICAgICAgICAgIGNvbnRpbnVlOwo+ICsg
ICAgICAgIH0KPiAgCj4gICAgICAgICAgLyoKPiAgICAgICAgICAgKiBJZiBhIHZjcHUgaXMgbWVh
bnQgdG8gYmUgcGlja2VkIHVwIGJ5IGFub3RoZXIgcHJvY2Vzc29yLCBhbmQgc3VjaAo+IEBAIC0y
MjgyLDYgKzIyODgsNyBAQCBydW5xX2NhbmRpZGF0ZShzdHJ1Y3QgY3NjaGVkMl9ydW5xdWV1ZV9k
YXRhICpycWQsCj4gICAgICAgICAgaWYgKCBzdmMtPnRpY2tsZWRfY3B1ICE9IC0xICYmIHN2Yy0+
dGlja2xlZF9jcHUgIT0gY3B1ICYmCj4gICAgICAgICAgICAgICBjcHVtYXNrX3Rlc3RfY3B1KHN2
Yy0+dGlja2xlZF9jcHUsICZycWQtPnRpY2tsZWQpICkKPiAgICAgICAgICB7Cj4gKyAgICAgICAg
ICAgICgqc2tpcHBlZCkrKzsKPiAgICAgICAgICAgICAgU0NIRURfU1RBVF9DUkFOSyhkZWZlcnJl
ZF90b190aWNrbGVkX2NwdSk7Cj4gICAgICAgICAgICAgIGNvbnRpbnVlOwo+ICAgICAgICAgIH0K
PiBAQCAtMjI5MSw2ICsyMjk4LDcgQEAgcnVucV9jYW5kaWRhdGUoc3RydWN0IGNzY2hlZDJfcnVu
cXVldWVfZGF0YSAqcnFkLAo+ICAgICAgICAgIGlmICggc3ZjLT52Y3B1LT5wcm9jZXNzb3IgIT0g
Y3B1Cj4gICAgICAgICAgICAgICAmJiBzbmV4dC0+Y3JlZGl0ICsgQ1NDSEVEMl9NSUdSQVRFX1JF
U0lTVCA+IHN2Yy0+Y3JlZGl0ICkKPiAgICAgICAgICB7Cj4gKyAgICAgICAgICAgICgqc2tpcHBl
ZCkrKzsKPiAgICAgICAgICAgICAgU0NIRURfU1RBVF9DUkFOSyhtaWdyYXRlX3Jlc2lzdGVkKTsK
PiAgICAgICAgICAgICAgY29udGludWU7Cj4gICAgICAgICAgfQo+IEBAIC0yMzA4LDExICsyMzE2
LDEyIEBAIHJ1bnFfY2FuZGlkYXRlKHN0cnVjdCBjc2NoZWQyX3J1bnF1ZXVlX2RhdGEgKnJxZCwK
PiAgICAgIHsKPiAgICAgICAgICBzdHJ1Y3Qgewo+ICAgICAgICAgICAgICB1bnNpZ25lZCB2Y3B1
OjE2LCBkb206MTY7Cj4gLSAgICAgICAgICAgIHVuc2lnbmVkIHRpY2tsZWRfY3B1Owo+ICsgICAg
ICAgICAgICB1bnNpZ25lZCB0aWNrbGVkX2NwdSwgc2tpcHBlZDsKPiAgICAgICAgICB9IGQ7Cj4g
ICAgICAgICAgZC5kb20gPSBzbmV4dC0+dmNwdS0+ZG9tYWluLT5kb21haW5faWQ7Cj4gICAgICAg
ICAgZC52Y3B1ID0gc25leHQtPnZjcHUtPnZjcHVfaWQ7Cj4gICAgICAgICAgZC50aWNrbGVkX2Nw
dSA9IHNuZXh0LT50aWNrbGVkX2NwdTsKPiArICAgICAgICBkLnNraXBwZWQgPSAqc2tpcHBlZDsK
PiAgICAgICAgICBfX3RyYWNlX3ZhcihUUkNfQ1NDSEVEMl9SVU5RX0NBTkRJREFURSwgMSwKPiAg
ICAgICAgICAgICAgICAgICAgICBzaXplb2YoZCksCj4gICAgICAgICAgICAgICAgICAgICAgKHVu
c2lnbmVkIGNoYXIgKikmZCk7Cj4gQEAgLTIzMzYsNiArMjM0NSw3IEBAIGNzY2hlZDJfc2NoZWR1
bGUoCj4gICAgICBzdHJ1Y3QgY3NjaGVkMl9ydW5xdWV1ZV9kYXRhICpycWQ7Cj4gICAgICBzdHJ1
Y3QgY3NjaGVkMl92Y3B1ICogY29uc3Qgc2N1cnIgPSBDU0NIRUQyX1ZDUFUoY3VycmVudCk7Cj4g
ICAgICBzdHJ1Y3QgY3NjaGVkMl92Y3B1ICpzbmV4dCA9IE5VTEw7Cj4gKyAgICB1bnNpZ25lZCBp
bnQgc2tpcHBlZF92Y3B1cyA9IDA7Cj4gICAgICBzdHJ1Y3QgdGFza19zbGljZSByZXQ7Cj4gIAo+
ICAgICAgU0NIRURfU1RBVF9DUkFOSyhzY2hlZHVsZSk7Cj4gQEAgLTIzODUsNyArMjM5NSw3IEBA
IGNzY2hlZDJfc2NoZWR1bGUoCj4gICAgICAgICAgc25leHQgPSBDU0NIRUQyX1ZDUFUoaWRsZV92
Y3B1W2NwdV0pOwo+ICAgICAgfQo+ICAgICAgZWxzZQo+IC0gICAgICAgIHNuZXh0ID0gcnVucV9j
YW5kaWRhdGUocnFkLCBzY3VyciwgY3B1LCBub3cpOwo+ICsgICAgICAgIHNuZXh0ID0gcnVucV9j
YW5kaWRhdGUocnFkLCBzY3VyciwgY3B1LCBub3csICZza2lwcGVkX3ZjcHVzKTsKPiAgCj4gICAg
ICAvKiBJZiBzd2l0Y2hpbmcgZnJvbSBhIG5vbi1pZGxlIHJ1bm5hYmxlIHZjcHUsIHB1dCBpdAo+
ICAgICAgICogYmFjayBvbiB0aGUgcnVucXVldWUuICovCj4gQEAgLTI0MDksOCArMjQxOSwyMSBA
QCBjc2NoZWQyX3NjaGVkdWxlKAo+ICAgICAgICAgICAgICBfX3NldF9iaXQoX19DU0ZMQUdfc2No
ZWR1bGVkLCAmc25leHQtPmZsYWdzKTsKPiAgICAgICAgICB9Cj4gIAo+IC0gICAgICAgIC8qIENo
ZWNrIGZvciB0aGUgcmVzZXQgY29uZGl0aW9uICovCj4gLSAgICAgICAgaWYgKCBzbmV4dC0+Y3Jl
ZGl0IDw9IENTQ0hFRDJfQ1JFRElUX1JFU0VUICkKPiArICAgICAgICAvKgo+ICsgICAgICAgICAq
IFRoZSByZXNldCBjb25kaXRpb24gaXMgImhhcyBhIHNjaGVkdWxlciBlcG9jaCBjb21lIHRvIGFu
IGVuZD8iLgo+ICsgICAgICAgICAqIFRoZSB3YXkgdGhpcyBpcyBlbmZvcmNlZCBpcyBjaGVja2lu
ZyB3aGV0aGVyIHRoZSB2Y3B1IGF0IHRoZSB0b3AKPiArICAgICAgICAgKiBvZiB0aGUgcnVucXVl
dWUgaGFzIG5lZ2F0aXZlIGNyZWRpdHMuIFRoaXMgbWVhbnMgdGhlIGVwb2NocyBoYXZlCj4gKyAg
ICAgICAgICogdmFyaWFibGUgbGVuZ2h0LCBhcyBpbiBvbmUgZXBvY2ggZXhwb3JlcyB3aGVuOgo+
ICsgICAgICAgICAqICAxKSB0aGUgdmNwdSBhdCB0aGUgdG9wIG9mIHRoZSBydW5xdWV1ZSBoYXMg
ZXhlY3V0ZWQgZm9yCj4gKyAgICAgICAgICogICAgIGFyb3VuZCAxMCBtcyAod2l0aCBkZWZhdWx0
IHBhcmFtZXRlcnMpOwo+ICsgICAgICAgICAqICAyKSBubyBvdGhlciB2Y3B1IHdpdGggaGlnaGVy
IGNyZWRpdHMgd2FudHMgdG8gcnVuLgo+ICsgICAgICAgICAqCj4gKyAgICAgICAgICogSGVyZSwg
d2hlcmUgd2Ugd2FudCB0byBjaGVjayBmb3IgcmVzZXQsIHdlIG5lZWQgdG8gbWFrZSBzdXJlIHRo
ZQo+ICsgICAgICAgICAqIHByb3BlciB2Y3B1IGlzIGJlaW5nIHVzZWQuIEluIGZhY3QsIHJ1bnF1
ZXVlX2NhbmRpZGF0ZSgpIG1heSBoYXZlCj4gKyAgICAgICAgICogbm90IHJldHVybmVkIHRoZSBm
aXJzdCB2Y3B1IGluIHRoZSBydW5xdWV1ZSwgZm9yIHZhcmlvdXMgcmVhc29ucwo+ICsgICAgICAg
ICAqIChlLmcuLCBhZmZpbml0eSkuIE9ubHkgdHJpZ2dlciBhIHJlc2V0IHdoZW4gaXQgZG9lcy4K
PiArICAgICAgICAgKi8KPiArICAgICAgICBpZiAoIHNraXBwZWRfdmNwdXMgPT0gMCAmJiBzbmV4
dC0+Y3JlZGl0IDw9IENTQ0hFRDJfQ1JFRElUX1JFU0VUICkKPiAgICAgICAgICB7Cj4gICAgICAg
ICAgICAgIHJlc2V0X2NyZWRpdChvcHMsIGNwdSwgbm93LCBzbmV4dCk7Cj4gICAgICAgICAgICAg
IGJhbGFuY2VfbG9hZChvcHMsIGNwdSwgbm93KTsKPiAKCgpfX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZl
bEBsaXN0cy54ZW4ub3JnCmh0dHBzOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK