xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "Håkon Alstadheim" <hakon@alstadheim.priv.no>
To: xen-devel@lists.xenproject.org
Subject: Re: [PATCH V1 1/1] Xen/libxl: Perform PCI reset using 'reset' SysFS attribute
Date: Thu, 14 Dec 2017 22:31:43 +0100	[thread overview]
Message-ID: <76649b03-0dde-dd37-28bd-f29b340aa009@alstadheim.priv.no> (raw)
In-Reply-To: <59839a62-9cc4-b3a1-d765-bc372378d976@Oracle.COM>



Den 14. des. 2017 21:22, skrev Govinda Tatti:
> 
>>>> In which case, xl needs to be backwards-compatible with kernels that
>>>> don't have your new feature: it will have to check for %s/reset, and
>>>> if it's not there, then try %/do_flr.
>>> I think this fix was planned more than a year back and even we pushed
>>> libxl
>>> fix
>>> ("do_flr" SysFSattribute) but linux kernel fix was not integrated for
>>> some
>>> reason.
>>> Now, we are revisitingboth linux kernel and libxl changes. In
>>> other-words,
>>> "do_flr" change is not being usedtoday since we don't have required code
>>> changes
>>> in the linux kernel.
>> Are you saying do_flr doesn't exist at all in any version of Linux,
>> and as such the line you're removing is currently pointless?
> Yes, that's correct. In other-words, it will not break any existing code
> or functionality.

Except for people, like me, running unofficial patches to linux. It
should be OK to assume they are watching this thread.

> 
> Cheers
> GOVINDA
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xenproject.org
> https://lists.xenproject.org/mailman/listinfo/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2017-12-14 21:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-07 22:26 [PATCH V1 0/1] Xen/Tools: PCI reset using 'reset' SysFS attribute Govinda Tatti
2017-12-07 22:26 ` [PATCH V1 1/1] Xen/libxl: Perform " Govinda Tatti
2017-12-13  1:11   ` Govinda Tatti
2017-12-13 14:01   ` George Dunlap
2017-12-13 21:05     ` Govinda Tatti
2017-12-14 10:31       ` George Dunlap
2017-12-14 20:22         ` Govinda Tatti
2017-12-14 21:31           ` Håkon Alstadheim [this message]
2017-12-18 18:33             ` Govinda Tatti
2017-12-20 21:39               ` Håkon Alstadheim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=76649b03-0dde-dd37-28bd-f29b340aa009@alstadheim.priv.no \
    --to=hakon@alstadheim.priv.no \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).