From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v2 3/5] xen/livepatch/ARM32: Don't load and crash on livepatches loaded with wrong alignment. Date: Wed, 26 Jul 2017 23:27:37 +0100 Message-ID: <77f98fa5-d14b-7f32-afd2-2d11563ae4ae@citrix.com> References: <20170726194756.20265-1-konrad@kernel.org> <20170726194756.20265-4-konrad@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1daUmT-0003xV-1X for xen-devel@lists.xenproject.org; Wed, 26 Jul 2017 22:27:49 +0000 In-Reply-To: <20170726194756.20265-4-konrad@kernel.org> Content-Language: en-GB List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Konrad Rzeszutek Wilk , xen-devel@lists.xenproject.org, julien.grall@arm.com, sstabellini@kernel.org Cc: jbeulich@suse.com List-Id: xen-devel@lists.xenproject.org T24gMjYvMDcvMjAxNyAyMDo0NywgS29ucmFkIFJ6ZXN6dXRlayBXaWxrIHdyb3RlOgo+IGRpZmYg LS1naXQgYS94ZW4vYXJjaC9hcm0vYXJtNjQvbGl2ZXBhdGNoLmMgYi94ZW4vYXJjaC9hcm0vYXJt NjQvbGl2ZXBhdGNoLmMKPiBpbmRleCAyMjQ3YjkyNWEwLi43YjM2MjEwY2NkIDEwMDY0NAo+IC0t LSBhL3hlbi9hcmNoL2FybS9hcm02NC9saXZlcGF0Y2guYwo+ICsrKyBiL3hlbi9hcmNoL2FybS9h cm02NC9saXZlcGF0Y2guYwo+IEBAIC04Niw2ICs4NiwxMiBAQCBib29sIGFyY2hfbGl2ZXBhdGNo X3N5bWJvbF9kZW55KGNvbnN0IHN0cnVjdCBsaXZlcGF0Y2hfZWxmICplbGYsCj4gICAgICByZXR1 cm4gZmFsc2U7Cj4gIH0KPiAgCj4gK2Jvb2wgYXJjaF9saXZlcGF0Y2hfdmVyaWZ5X2FsaWdubWVu dChjb25zdCBzdHJ1Y3QgbGl2ZXBhdGNoX2VsZl9zZWMgKnNlYykKPiArewoKU2VtYW50aWNhbGx5 LCAidmVyaWZ5X2FsaWdubWVudCIgaW1wbGllcyAidGhlIGFsaWdubWVudCBpcyBjb3JyZWN0Iiwg YnV0CnRoZSByZXR1cm4gdmFsdWUgaXMgdGhlIG9wcG9zaXRlLgoKSSdkIHJlY29tbWVuZCBpbnZl cnRpbmcgdGhlIHNlbnNlIG9mIHRoZXNlIGZ1bmN0aW9ucywgcmV0dXJuaW5nIHRydWUgZm9yCng4 Ni9hcm02NCwgYW5kID09IDAgZm9yIGFybTMyLi4uCgo+ICsgICAgLyogVW5hbGlnbmVkIGFjY2Vz cyBvbiBBUk0gNjQgaXMgT0suICovCj4gKyAgICByZXR1cm4gZmFsc2U7Cj4gK30KPiArCj4gIGVu dW0gYWFyY2g2NF9yZWxvY19vcCB7Cj4gICAgICBSRUxPQ19PUF9OT05FLAo+ICAgICAgUkVMT0Nf T1BfQUJTLAo+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvbGl2ZXBhdGNoLmMgYi94ZW4vYXJj aC94ODYvbGl2ZXBhdGNoLmMKPiBpbmRleCA0MDZlYjkxMGNjLi5iM2NiZGFjOWI3IDEwMDY0NAo+ IC0tLSBhL3hlbi9hcmNoL3g4Ni9saXZlcGF0Y2guYwo+ICsrKyBiL3hlbi9hcmNoL3g4Ni9saXZl cGF0Y2guYwo+IEBAIC0xNDgsNiArMTQ4LDEyIEBAIGJvb2wgYXJjaF9saXZlcGF0Y2hfc3ltYm9s X2RlbnkoY29uc3Qgc3RydWN0IGxpdmVwYXRjaF9lbGYgKmVsZiwKPiAgICAgIHJldHVybiBmYWxz ZTsKPiAgfQo+ICAKPiArYm9vbCBhcmNoX2xpdmVwYXRjaF92ZXJpZnlfYWxpZ25tZW50KGNvbnN0 IHN0cnVjdCBsaXZlcGF0Y2hfZWxmX3NlYyAqc2VjKQo+ICt7Cj4gKyAgICAvKiBVbmFsaWduZWQg YWNjZXNzIG9uIHg4NiBpcyBmaW5lLiAqLwo+ICsgICAgcmV0dXJuIGZhbHNlOwo+ICt9Cj4gKwo+ ICBpbnQgYXJjaF9saXZlcGF0Y2hfcGVyZm9ybV9yZWwoc3RydWN0IGxpdmVwYXRjaF9lbGYgKmVs ZiwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IHN0cnVjdCBsaXZlcGF0 Y2hfZWxmX3NlYyAqYmFzZSwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0 IHN0cnVjdCBsaXZlcGF0Y2hfZWxmX3NlYyAqcmVsYSkKPiBkaWZmIC0tZ2l0IGEveGVuL2NvbW1v bi9saXZlcGF0Y2guYyBiL3hlbi9jb21tb24vbGl2ZXBhdGNoLmMKPiBpbmRleCA0MGZmNmIzYTI3 Li4xM2Q4ZjI1YTRiIDEwMDY0NAo+IC0tLSBhL3hlbi9jb21tb24vbGl2ZXBhdGNoLmMKPiArKysg Yi94ZW4vY29tbW9uL2xpdmVwYXRjaC5jCj4gQEAgLTQ3Miw2ICs0NzIsMTMgQEAgc3RhdGljIGlu dCBjaGVja19zZWN0aW9uKGNvbnN0IHN0cnVjdCBsaXZlcGF0Y2hfZWxmICplbGYsCj4gICAgICAg ICAgcmV0dXJuIC1FSU5WQUw7Cj4gICAgICB9Cj4gIAo+ICsgICAgaWYgKCBhcmNoX2xpdmVwYXRj aF92ZXJpZnlfYWxpZ25tZW50KHNlYykgKQo+ICsgICAgewo+ICsgICAgICAgIGRwcmludGsoWEVO TE9HX0VSUiwgTElWRVBBVENIICIlczogJXMgaXMgbm90IGFsaWduZWQgcHJvcGVybHkhXG4iLAo+ ICsgICAgICAgICAgICAgICBlbGYtPm5hbWUsIHNlYy0+bmFtZSk7CgpJdCBhbHNvIG1lYW5zIHRo aXMgd291bGQgcmVhZCBhcwoKaWYgKCAhYXJjaF9saXZlcGF0Y2hfdmVyaWZ5X2FsaWdubWVudChz ZWMpICkKewogICAgIiRibGFoIG5vdCBwcm9wZXJseSBhbGlnbmVkIgoKd2hpY2ggaXMgYWxzbyB0 aGUgdXN1YWwgd2F5IGFyb3VuZCB0byB0aGluay4KCihBbHNvLCBib29sIGZ1bmN0aW9ucyBhbmQg aW50IGZ1bmN0aW9ucyByZWFsbHkgZG8gaGF2ZSBvcHBvc2l0ZSBzdWNjZXNzCmNhc2VzLCBhbmQg c2hvdWxkIGJlIGtlcHQgdGhhdCB3YXkuKQoKfkFuZHJldwoKPiArICAgICAgICByZXR1cm4gLUVJ TlZBTDsKPiArICAgIH0KPiArCj4gICAgICByZXR1cm4gMDsKPiAgfQo+ICAKCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBs aXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHBzOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2 ZWwK