From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juergen Gross Subject: Re: [PATCH v4 3/4] xenstore: rework of transaction handling Date: Fri, 31 Mar 2017 13:03:36 +0200 Message-ID: <7ba7d13a-dc19-16e3-0eb5-c22d3167a0bd@suse.com> References: <20170330131148.8711-1-jgross@suse.com> <20170330154117.n6hh7av6udqitwhf@citrix.com> <19f2dc33-8a59-804e-c50e-2946e8d9faa4@suse.com> <20170331110020.ox6jpmnubt7uflul@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ctuLE-0006A6-AF for xen-devel@lists.xenproject.org; Fri, 31 Mar 2017 11:03:40 +0000 In-Reply-To: <20170331110020.ox6jpmnubt7uflul@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Wei Liu Cc: xen-devel@lists.xenproject.org, ian.jackson@eu.citrix.com List-Id: xen-devel@lists.xenproject.org T24gMzEvMDMvMTcgMTM6MDAsIFdlaSBMaXUgd3JvdGU6Cj4gT24gVGh1LCBNYXIgMzAsIDIwMTcg YXQgMDY6NDE6MTFQTSArMDIwMCwgSnVlcmdlbiBHcm9zcyB3cm90ZToKPiBbLi4uXQo+Pj4KPj4+ PiAgCQlub2RlLT5nZW5lcmF0aW9uID0gZ2VuZXJhdGlvbisrOwo+Pj4+IC0JCXJldHVybjsKPj4+ PiArCQlpZiAoY29ubiAmJiAhY29ubi0+dHJhbnNhY3Rpb24pCj4+Pj4gKwkJCXdybF9hcHBseV9k ZWJpdF9kaXJlY3QoY29ubik7Cj4+Pj4gKwl9Cj4+Pj4gKwo+Pj4+ICsJaWYgKCFjb25uIHx8ICFj b25uLT50cmFuc2FjdGlvbikgewo+Pj4+ICsJCWlmIChrZXkpCj4+Pj4gKwkJCXNldF90ZGJfa2V5 KG5vZGUtPm5hbWUsIGtleSk7Cj4+Pj4gKwkJcmV0dXJuIDA7Cj4+Pj4gIAl9Cj4+Pj4gIAo+Pj4+ ICAJdHJhbnMgPSBjb25uLT50cmFuc2FjdGlvbjsKPj4+PiAgCj4+Pj4gLQlub2RlLT5nZW5lcmF0 aW9uID0gZ2VuZXJhdGlvbiArIHRyYW5zLT50cmFuc19nZW4rKzsKPj4+PiArCXRyYW5zX25hbWUg PSB0cmFuc2FjdGlvbl9nZXRfbm9kZV9uYW1lKG5vZGUsIHRyYW5zLCBub2RlLT5uYW1lKTsKPj4+ PiArCWlmICghdHJhbnNfbmFtZSkKPj4+PiArCQlnb3RvIG5vbWVtOwo+Pj4+ICAKPj4+PiAtCWxp c3RfZm9yX2VhY2hfZW50cnkoaSwgJnRyYW5zLT5jaGFuZ2VzLCBsaXN0KSB7Cj4+Pj4gLQkJaWYg KHN0cmVxKGktPm5vZGUsIG5vZGUtPm5hbWUpKSB7Cj4+Pj4gLQkJCWlmIChyZWN1cnNlKQo+Pj4+ IC0JCQkJaS0+cmVjdXJzZSA9IHJlY3Vyc2U7Cj4+Pj4gLQkJCXJldHVybjsKPj4+PiAtCQl9Cj4+ Pj4gLQl9Cj4+Pj4gLQo+Pj4+IC0JaSA9IHRhbGxvYyh0cmFucywgc3RydWN0IGNoYW5nZWRfbm9k ZSk7Cj4+Pj4gKwlpID0gZmluZF9hY2Nlc3NlZF9ub2RlKHRyYW5zLCBub2RlLT5uYW1lKTsKPj4+ PiAgCWlmICghaSkgewo+Pj4+IC0JCS8qIEFsbCB3ZSBjYW4gZG8gaXMgbGV0IHRoZSB0cmFuc2Fj dGlvbiBmYWlsLiAqLwo+Pj4+IC0JCWdlbmVyYXRpb24rKzsKPj4+PiAtCQlyZXR1cm47Cj4+Pj4g KwkJaSA9IHRhbGxvY196ZXJvKHRyYW5zLCBzdHJ1Y3QgYWNjZXNzZWRfbm9kZSk7Cj4+Pj4gKwkJ aWYgKCFpKQo+Pj4+ICsJCQlnb3RvIG5vbWVtOwo+Pj4+ICsJCWktPm5vZGUgPSB0YWxsb2Nfc3Ry ZHVwKGksIG5vZGUtPm5hbWUpOwo+Pj4+ICsJCWlmICghaS0+bm9kZSkKPj4+PiArCQkJZ290byBu b21lbTsKPj4+PiArCj4+Pj4gKwkJaW50cm9kdWNlID0gdHJ1ZTsKPj4+PiArCQlpLT50YV9ub2Rl ID0gZmFsc2U7Cj4+Pj4gKwo+Pj4+ICsJCS8qIFdlIGhhdmUgdG8gdmVyaWZ5IHJlYWQgbm9kZXMg b25seSBpZiB3ZSBkaWRuJ3Qgd3JpdGUgdGhlbS4gKi8KPj4+PiArCQlpZiAodHlwZSA9PSBOT0RF X0FDQ0VTU19SRUFEKSB7Cj4+Pj4gKwkJCWktPmdlbmVyYXRpb24gPSBub2RlLT5nZW5lcmF0aW9u Owo+Pj4+ICsJCQlpLT5jaGVja19nZW4gPSB0cnVlOwo+Pj4+ICsJCQlpZiAobm9kZS0+Z2VuZXJh dGlvbiAhPSBOT19HRU5FUkFUSU9OKSB7Cj4+Pj4gKwkJCQlzZXRfdGRiX2tleSh0cmFuc19uYW1l LCAmbG9jYWxfa2V5KTsKPj4+PiArCQkJCXJldCA9IHdyaXRlX25vZGVfcmF3KGNvbm4sICZsb2Nh bF9rZXksIG5vZGUpOwo+Pj4+ICsJCQkJaWYgKHJldCkKPj4+PiArCQkJCQlnb3RvIGVycjsKPj4+ PiArCQkJCWktPnRhX25vZGUgPSB0cnVlOwo+Pj4+ICsJCQl9Cj4+Pj4gKwkJfQo+Pj4KPj4+IEkg dGhpbmsgdGhlIGN1cnJlbnQgY29kZSBzdHJ1Y3R1cmUgaXMgYSBiaXQgY29uZnVzaW5nLgo+Pj4K Pj4+IEZvciB3cml0ZSB0eXBlcywgdGhlIGNhbGwgdG8gd3JpdGVfbm9kZV9yYXcgaXMgb3V0c2lk ZSBvZiB0aGlzIGZ1bmN0aW9uCj4+PiBidXQgZm9yIHJlYWQgdHlwZSBpdCBpcyBpbnNpZGUgdGhp cyBmdW5jdGlvbi4KPj4KPj4gVGhpcyBpcyBkdWUgdG8gdGhlIGRpZmZlcmVudCBwdXJwb3NlIG9m IHdyaXRlX25vZGVfcmF3KCkgaW4gYm90aAo+PiBjYXNlczoKPj4KPj4gSW4gdGhlIHJlYWQgY2Fz ZSB3ZSB3cml0ZSBhbiBfYWRkaXRpb25hbF8gbm9kZSBpbnRvIHRoZSB0cmFuc2FjdGlvbiwKPj4g d2hpbGUgaW4gdGhlIHdyaXRlIGNhc2UgaXQgaXMganVzdCB0aGUgdXNlcidzIG9wZXJhdGlvbi4K Pj4KPj4+Cj4+Pj4gKwkJbGlzdF9hZGRfdGFpbCgmaS0+bGlzdCwgJnRyYW5zLT5hY2Nlc3NlZCk7 Cj4+Pj4gIAl9Cj4+Pj4gLQlpLT5ub2RlID0gdGFsbG9jX3N0cmR1cChpLCBub2RlLT5uYW1lKTsK Pj4+PiAtCWlmICghaS0+bm9kZSkgewo+Pj4+IC0JCS8qIEFsbCB3ZSBjYW4gZG8gaXMgbGV0IHRo ZSB0cmFuc2FjdGlvbiBmYWlsLiAqLwo+Pj4+IC0JCWdlbmVyYXRpb24rKzsKPj4+PiArCj4+Pj4g KwlpZiAodHlwZSAhPSBOT0RFX0FDQ0VTU19SRUFEKQo+Pj4+ICsJCWktPm1vZGlmaWVkID0gdHJ1 ZTsKPj4+PiArCj4+Pj4gKwlpZiAoaW50cm9kdWNlICYmIHR5cGUgPT0gTk9ERV9BQ0NFU1NfREVM RVRFKQo+Pj4+ICsJCS8qIE5vdGhpbmcgdG8gZGVsZXRlLiAqLwo+Pj4+ICsJCXJldHVybiAtMTsK Pj4+PiArCj4+Pj4gKwlpZiAoa2V5KSB7Cj4+Pj4gKwkJc2V0X3RkYl9rZXkodHJhbnNfbmFtZSwg a2V5KTsKPj4+PiArCQlpZiAodHlwZSA9PSBOT0RFX0FDQ0VTU19XUklURSkKPj4+PiArCQkJaS0+ dGFfbm9kZSA9IHRydWU7Cj4+Pj4gKwkJaWYgKHR5cGUgPT0gTk9ERV9BQ0NFU1NfREVMRVRFKQo+ Pj4+ICsJCQlpLT50YV9ub2RlID0gZmFsc2U7Cj4+Pgo+Pj4gVGhlIHNhbWUgY2F2ZWF0IG1hZGUg bWUgd29uZGVyIGlmIHRhX25vZGUgd2FzIHJlYWxseSB3aGF0IGl0IG1lYW50IHRvCj4+PiBiZSBi ZWNhdXNlIEkgY291bGRuJ3QgZmluZCB3aGVyZSB3cml0ZV9ub2RlX3JhdyB3YXMuCj4+Pgo+Pj4g Q2FuIEkgc3VnZ2VzdCB5b3UgbWFrZSB0aGVtIGNvbnNpc3RlbnQ/IEVpdGhlciBsaWZ0IHRoZSB3 cml0ZV9ub2RlX3Jhdwo+Pj4gZm9yIHJlYWQgdG8gcmVhZF9ub2RlIG9yIHB1c2ggZG93biB0aGUg d3JpdGVfbm9kZV9yYXcgaW4gZGVsZXRlX25vZGUgYW5kCj4+PiB3cml0ZV9ub2RlIGhlcmU/Cj4+ Pgo+Pj4gSWYgSSBtaXN1bmRlcnN0YW5kIGhvdyB0aGlzIHdvcmtzLCBwbGVhc2UgdGVsbCBtZS4u Lgo+Pgo+PiBBcyBJIGFscmVhZHkgc2FpZDogaW4gdGhlIHJlYWQgY2FzZSB3cml0aW5nIHRoZSBu b2RlIGlzIGRlcGVuZGluZwo+PiBvbiB0aGUgY29udGV4dCBhbmQgbGlmdGluZyBpdCB1cCB3b3Vs ZCBzZWVtIHJhdGhlciBzdHJhbmdlOiB3aHkKPj4gc2hvdWxkIHJlYWRpbmcgYSBub2RlIGNvbnRh aW4gYSB3cml0ZV9ub2RlX3JhdygpIGNhbGw/Cj4+Cj4+IEluIHRoZSB3cml0ZSBjYXNlIEkgYmVs aWV2ZSB3ZSBzaG91bGQga2VlcCB3cml0ZV9ub2RlX3JhdygpIHdoZXJlCj4+IGl0IGJlbG9uZ3M6 IGluIHRoZSBhcHByb3ByaWF0ZSBmdW5jdGlvbiBtb2RpZnlpbmcgdGhlIG5vZGUuCj4+Cj4+IEFs bCBhY3Rpb25zIGluIGFjY2Vzc19ub2RlKCkgYXJlIHRyYW5zYWN0aW9uIHNwZWNpZmljIGFuZCBf YWRkaXRpb25hbF8KPj4gaW4gdGhlIHRyYW5zYWN0aW9uIGNhc2UuCj4gCj4gCj4gT0ssIG15IGxp bmUgb2YgcmVhc29uaW5nIGlzIHRoYXQgd2hhdGV2ZXIgREIgb3BlcmF0aW9uIGlzIG5lY2Vzc2Fy eSB0bwo+IG1ha2UgYSBmdW5jdGlvbmFsaXR5IHdvcmsgc2hvdWxkIGJlIGNvbnNpc3RlbnQuIFRo YXQgbWVhbnMgZXZlbiBoYXZpbmcgYQo+IERCIHdyaXRlIGluIHJlYWQgaXMgT0suICBCdXQgSSB0 aGluayB5b3VyIGV4cGxhbmF0aW9uIGlzIGZpbmUsIHRvby4KPiAKPiBNYXkgSSB0aGVuIHN1Z2dl c3QgYWRkaW5nIHRoZSBmb2xsb3dpbmcgdG8gdGhlIHdyaXRlIGZvciByZWFkIHR5cGUgaW4KPiBh Y2Nlc3Nfbm9kZT8KPiAKPiAgIC8qIEFkZGl0aW9uYWwgdHJhbnNhY3Rpb24tc3BlY2lmaWMgbm9k ZSBmb3IgcmVhZCB0eXBlLiBXZSBvbmx5IGhhdmUgdG8gCj4gICAgKiB2ZXJpZnkgcmVhZCBub2Rl cyBvbmx5IGlmIHdlIGRpZG4ndCB3cml0ZSB0aGVtLgo+ICAgICoKPiAgICAqIFRoZSBub2RlIGlz IGNyZWF0ZWQgYW5kIHdyaXR0ZW4gdG8gREIgaGVyZSB0byBkaXN0aW5ndWlzaCBmcm9tIHRoZQo+ ICAgICogd3JpdGUgdHlwZXMuCj4gICAgKi8KCldpbGwgZG8uCgpUaGFua3MsCgoKSnVlcmdlbgoK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZl bCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cHM6Ly9saXN0cy54ZW4u b3JnL3hlbi1kZXZlbAo=