From: Paul Durrant <Paul.Durrant@citrix.com>
To: 'Jan Beulich' <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2] x86/hvm: remove default ioreq server
Date: Tue, 7 Aug 2018 14:45:15 +0000 [thread overview]
Message-ID: <7c15aa42369a4923a0df12df5eaa88d0@AMSPEX02CL03.citrite.net> (raw)
In-Reply-To: <5B69AD0902000078001DB9D4@prv1-mh.provo.novell.com>
> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@suse.com]
> Sent: 07 August 2018 15:31
> To: Paul Durrant <Paul.Durrant@citrix.com>
> Cc: xen-devel <xen-devel@lists.xenproject.org>
> Subject: Re: [PATCH v2] x86/hvm: remove default ioreq server
>
> >>> On 07.08.18 at 16:02, <paul.durrant@citrix.com> wrote:
> > --- a/xen/arch/x86/hvm/hvm.c
> > +++ b/xen/arch/x86/hvm/hvm.c
> > @@ -4093,12 +4093,15 @@ static int hvm_allow_set_param(struct domain
> *d,
> > case HVM_PARAM_CONSOLE_EVTCHN:
> > case HVM_PARAM_X87_FIP_WIDTH:
> > break;
> > + /* The following parameters are deprecated. */
> > + case HVM_PARAM_BUFIOREQ_EVTCHN:
> > + rc = -EPERM;
> > + break;
> > /*
> > * The following parameters must not be set by the guest
> > * since the domain may need to be paused.
> > */
> > case HVM_PARAM_IDENT_PT:
> > - case HVM_PARAM_DM_DOMAIN:
> > case HVM_PARAM_ACPI_S_STATE:
> > /* The remaining parameters should not be set by the guest. */
> > default:
>
> So why again don't you add DM_DOMAIN alongside BUFIOREQ_EVTCHN
> above (and remove it from hvm_set_param()), and then also to
> hvm_allow_get_param()'s new deprecated group, plus respective
> treatment in public/hvm/params.h? I can't find any use of this
> except in the get/set functions here, and your qemu-trad patch
> removes the sole use ("set" request) there.
>
Ok, yes I'll add it too.
Paul
> Jan
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
prev parent reply other threads:[~2018-08-07 14:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-07 14:02 [PATCH v2] x86/hvm: remove default ioreq server Paul Durrant
2018-08-07 14:30 ` Jan Beulich
2018-08-07 14:45 ` Paul Durrant [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c15aa42369a4923a0df12df5eaa88d0@AMSPEX02CL03.citrite.net \
--to=paul.durrant@citrix.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).