From: Julien Grall <julien.grall@arm.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH 1/4] arm: acpi/boot.c is only used during initialisation
Date: Wed, 31 Aug 2016 14:54:15 +0100 [thread overview]
Message-ID: <7da54d38-c29f-66a7-1b18-34f1252b0abf@arm.com> (raw)
In-Reply-To: <20160831134520.GD21282@citrix.com>
On 31/08/16 14:45, Wei Liu wrote:
> On Wed, Aug 31, 2016 at 02:25:59PM +0100, Julien Grall wrote:
>> Hi Wei,
>>
>> On 30/08/16 13:01, Wei Liu wrote:
>>> That file should contain code and data used during initialisation only.
>>>
>>> Mark it as such in build system and correctly annotate enabled_cpus.
>>> This is required to enable gcov support on ARM.
>>
>> I am not sure to understand the requirement here. Does it mean it is not
>> possible to have a mix of init code and runtime code?
>>
>
> No. That's still allowed.
>
> "This is required to enable gcov support on ARM" is remnant that should
> be deleted, because strictly speaking if we don't change boot.o to
> boot.init.o, the resulting binary should still work.
>
> Please consider this patch a general cleanup.
I had a similar clean up in my todo list :).
> Can I keep your RoB?
Sure.
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-08-31 13:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 12:01 [PATCH 0/4] Fix gcov build Wei Liu
2016-08-30 12:01 ` [PATCH 1/4] arm: acpi/boot.c is only used during initialisation Wei Liu
2016-08-31 13:25 ` Julien Grall
2016-08-31 13:45 ` Wei Liu
2016-08-31 13:54 ` Julien Grall [this message]
2016-08-30 12:01 ` [PATCH 2/4] arm64: use "b" to branch to start_xen Wei Liu
2016-08-30 13:28 ` Konrad Rzeszutek Wilk
2016-08-31 13:40 ` Julien Grall
2016-08-30 12:01 ` [PATCH 3/4] xen: fix gcov compilation Wei Liu
2016-08-30 12:57 ` Ian Jackson
2016-08-30 12:59 ` Jan Beulich
2016-08-30 13:30 ` Wei Liu
2016-08-30 12:01 ` [PATCH 4/4] xen: add a gcov Kconfig option Wei Liu
2016-08-30 12:56 ` Jan Beulich
2016-08-30 13:06 ` Wei Liu
2016-08-30 16:49 ` Doug Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7da54d38-c29f-66a7-1b18-34f1252b0abf@arm.com \
--to=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).