[PATCH] tools/hotplug: remove 4 from default runlevel in xencommons

[PATCH] tools/hotplug: remove 4 from default runlevel in xencommons

[Olaf Hering]

# HG changeset patch
# User Olaf Hering <olaf@aepfle.de>
# Date 1328807859 -3600
# Node ID 7dadba19566dc9e1dfaf7202ab92b998999a143f
# Parent  c42517c528976cc5d6d6ac867f844e855b4abf34
tools/hotplug: remove 4 from default runlevel in xencommons

LSB defines runlevel 4 as "reserved for local use, default is
normal/full multiuser"

The current behaviour of insserv in openSuSE 11.4 and SLES11SP2 is that
xencommons gets a symlink in /etc/init.d/rc4.d/ due to the 4 in the
Default-Start: line. As a result insserv will print a warning:

insserv: warning: current stop runlevel(s) (2 3 5) of script `xencommons' overwrites defaults (2 3 4 5).

Since the local admin is responsible to create all symlinks manually in
/etc/init.d/rc4.d/ the xencommons script should not automatically enable
itself in runlevel 4.

So, remove the 4 from Default-Start: line.

Note: This change will not automatically remove old/stale xencommon
symlinks in /etc/init.d/rc4.d/ during a package upgrade.

Signed-off-by: Olaf Hering <olaf@aepfle.de>

diff -r c42517c52897 -r 7dadba19566d tools/hotplug/Linux/init.d/xencommons
--- a/tools/hotplug/Linux/init.d/xencommons
+++ b/tools/hotplug/Linux/init.d/xencommons
@@ -12,7 +12,7 @@
 # Should-Start:
 # Required-Stop:     $syslog $remote_fs
 # Should-Stop:
-# Default-Start:     2 3 4 5
+# Default-Start:     2 3 5
 # Default-Stop:      0 1 6
 # Short-Description: Start/stop xenstored and xenconsoled
 # Description:       Starts and stops the daemons neeeded for xl/xend

Re: [PATCH] tools/hotplug: remove 4 from default runlevel in xencommons

[Ian Jackson]

Olaf Hering writes ("[Xen-devel] [PATCH] tools/hotplug: remove 4 from default runlevel in xencommons"):
> tools/hotplug: remove 4 from default runlevel in xencommons

Thanks for the comprehensive explanation.

Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>