Re: [PATCH v3 6/6] x86/viridian: implement the crash MSRs

[Paul Durrant <Paul.Durrant@citrix.com>]

> -----Original Message-----
> From: Wei Liu [mailto:wei.liu2@citrix.com]
> Sent: 22 March 2017 11:10
> To: Jan Beulich <JBeulich@suse.com>
> Cc: Paul Durrant <Paul.Durrant@citrix.com>; Wei Liu <wei.liu2@citrix.com>;
> Andrew Cooper <Andrew.Cooper3@citrix.com>; Ian Jackson
> <Ian.Jackson@citrix.com>; xen-devel@lists.xenproject.org
> Subject: Re: [Xen-devel] [PATCH v3 6/6] x86/viridian: implement the crash
> MSRs
> 
> On Wed, Mar 22, 2017 at 05:07:30AM -0600, Jan Beulich wrote:
> > >>> On 21.03.17 at 19:17, <paul.durrant@citrix.com> wrote:
> > > --- a/tools/libxl/libxl.h
> > > +++ b/tools/libxl/libxl.h
> > > @@ -288,6 +288,12 @@
> > >  #define LIBXL_HAVE_SCHED_CREDIT2_PARAMS 1
> > >
> > >  /*
> > > + * LIBXL_HAVE_CRASH_CTL indicates that the 'crash_ctl' value
> > > + * is present in the viridian enlightenment enumeration.
> > > + */
> > > +#define LIBXL_HAVE_CRASH_CTL 1
> >
> > I was about to commit this together with 1, 3, and 4, when this
> > define caught my eye: Isn't the name a little too generic? I.e.
> > LIBXL_HAVE_VIRIDIAN_CRASH_CTL perhaps?
> >
> 
> That's fine by me.
>

Ok with me too.

  Paul
 
> > Jan
> >

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel