From: Julien Grall <julien.grall@arm.com>
To: Sergej Proskurin <proskurin@sec.in.tum.de>,
xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH v6 10/14] arm/guest_access: Rename vgic_access_guest_memory
Date: Tue, 18 Jul 2017 11:28:33 +0100 [thread overview]
Message-ID: <7fc5ef7d-01f9-27c7-4b76-c29d3f55535c@arm.com> (raw)
In-Reply-To: <24ea6712-8dfc-cc20-6178-154087a088e5@sec.in.tum.de>
On 18/07/17 09:42, Sergej Proskurin wrote:
> Hi Julien,
>
>
> On 07/17/2017 05:43 PM, Julien Grall wrote:
>> Hi Sergej,
>>
>> On 06/07/17 12:50, Sergej Proskurin wrote:
>>> This commit renames the function vgic_access_guest_memory to
>>> access_guest_memory_by_ipa. As the function name suggests, the functions
>>> expects an ipa as argument. Thus, to make the function's purpose more
>>
>> s/ipa/IPA/
>>
>>> clearly, we have also renamed the argument gva into ipa. All invocations
>>
>> The argument is call gpa not gva. gpa stands for "Guest Physical
>> Address" which is the name commonly used in Xen. IPA is the ARM naming.
>>
>
> Thanks. I have mistyped that one.
>
>> So I am not convinced of the usefulness of this rename.
>>
>
> I Agree. As you have suggested to use access_guest_memory_by_ipa as
> function name, I just wanted to be consistent. How about renaming the
> function to access_guest_memory_by_gpa instead? Then, we would remain
> consistent with Xen's naming conventions also on the function level.
Either name is fine by me. I just don't see any reason to rename GPA to
IPA as both have the same meaning.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-07-18 10:28 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-06 11:50 [PATCH v6 00/14] arm/mem_access: Walk guest page tables in SW if mem_access is active Sergej Proskurin
2017-07-06 11:50 ` [PATCH v6 01/14] arm/mem_access: Add and cleanup (TCR_|TTBCR_)* defines Sergej Proskurin
2017-07-06 11:50 ` [PATCH v6 02/14] arm/mem_access: Move PAGE_*_* macros to xen/page-defs.h Sergej Proskurin
2017-07-06 12:10 ` Jan Beulich
2017-07-06 14:53 ` Sergej Proskurin
2017-07-06 15:24 ` Jan Beulich
2017-07-06 15:34 ` Sergej Proskurin
2017-07-06 16:20 ` Jan Beulich
2017-07-07 8:27 ` Sergej Proskurin
2017-07-06 11:50 ` [PATCH v6 03/14] arm/mem_access: Add defines supporting PTs with varying page sizes Sergej Proskurin
2017-07-17 14:12 ` Julien Grall
2017-07-06 11:50 ` [PATCH v6 04/14] arm/lpae: Introduce lpae_is_page helper Sergej Proskurin
2017-07-06 11:50 ` [PATCH v6 05/14] arm/mem_access: Add short-descriptor pte typedefs and macros Sergej Proskurin
2017-07-06 11:50 ` [PATCH v6 06/14] arm/mem_access: Introduce GV2M_EXEC permission Sergej Proskurin
2017-07-06 11:50 ` [PATCH v6 07/14] arm/mem_access: Introduce BIT_ULL bit operation Sergej Proskurin
2017-07-06 11:50 ` [PATCH v6 08/14] arm/mem_access: Introduce GENMASK_ULL " Sergej Proskurin
2017-07-06 12:18 ` Jan Beulich
2017-07-06 14:38 ` Sergej Proskurin
2017-07-06 15:22 ` Jan Beulich
2017-07-06 15:34 ` Sergej Proskurin
2017-07-06 11:50 ` [PATCH v6 09/14] arm/guest_access: Move vgic_access_guest_memory to guest_access.h Sergej Proskurin
2017-07-17 15:38 ` Julien Grall
2017-07-18 9:49 ` Sergej Proskurin
2017-07-18 10:43 ` Julien Grall
2017-07-18 11:59 ` Sergej Proskurin
2017-07-18 12:12 ` Julien Grall
2017-07-18 12:20 ` Sergej Proskurin
2017-07-06 11:50 ` [PATCH v6 10/14] arm/guest_access: Rename vgic_access_guest_memory Sergej Proskurin
2017-07-17 15:43 ` Julien Grall
2017-07-18 8:42 ` Sergej Proskurin
2017-07-18 10:28 ` Julien Grall [this message]
2017-07-06 11:50 ` [PATCH v6 11/14] arm/mem_access: Add software guest-page-table walk Sergej Proskurin
2017-07-17 15:47 ` Julien Grall
2017-07-06 11:50 ` [PATCH v6 12/14] arm/mem_access: Add long-descriptor based gpt Sergej Proskurin
2017-07-17 16:18 ` Julien Grall
2017-07-06 11:50 ` [PATCH v6 13/14] arm/mem_access: Add short-descriptor " Sergej Proskurin
2017-07-17 16:26 ` Julien Grall
2017-07-06 11:50 ` [PATCH v6 14/14] arm/mem_access: Walk the guest's pt in software Sergej Proskurin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7fc5ef7d-01f9-27c7-4b76-c29d3f55535c@arm.com \
--to=julien.grall@arm.com \
--cc=proskurin@sec.in.tum.de \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).