Re: [PATCH for-4.21] x86/ucode: Fix missing printk() newline in ucode_probe_amd()

[Oleksii Kurochko <oleksii.kurochko@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1335 bytes --]


On 10/17/25 1:26 AM, Andrew Cooper wrote:
> Fixes: 630e8875ab36 ("x86/ucode: Perform extra SHA2 checks on AMD Fam17h/19h microcode")
> Signed-off-by: Andrew Cooper<andrew.cooper3@citrix.com>
> ---
> CC: Jan Beulich<JBeulich@suse.com>
> CC: Roger Pau Monné<roger.pau@citrix.com>
> CC: Oleksii Kurochko<oleksii.kurochko@gmail.com>
>
> For 4.21.  This is a formatting fix with basically 0 risk.
>
> It is encouraging that no-one has reported this bug so far, because it
> suggests that no-one has turned off digest checking and then looked at dmesg.

Release-Acked-by: Oleksii Kurochko<oleksii.kurochko@gmail.com>

Thanks.

~ Oleksii

> ---
>   xen/arch/x86/cpu/microcode/amd.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/x86/cpu/microcode/amd.c b/xen/arch/x86/cpu/microcode/amd.c
> index a5729229a403..59332da2b827 100644
> --- a/xen/arch/x86/cpu/microcode/amd.c
> +++ b/xen/arch/x86/cpu/microcode/amd.c
> @@ -519,7 +519,7 @@ void __init ucode_probe_amd(struct microcode_ops *ops)
>       if ( !opt_digest_check && boot_cpu_data.family >= 0x17 )
>       {
>           printk(XENLOG_WARNING
> -               "Microcode patch additional digest checks disabled");
> +               "Microcode patch additional digest checks disabled\n");
>           add_taint(TAINT_CPU_OUT_OF_SPEC);
>       }
>   

[-- Attachment #2: Type: text/html, Size: 2249 bytes --]