From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
Xen-devel <xen-devel@lists.xen.org>
Cc: "Kevin Tian" <kevin.tian@intel.com>,
"Wei Liu" <wei.liu2@citrix.com>,
"Jun Nakajima" <jun.nakajima@intel.com>,
"George Dunlap" <george.dunlap@eu.citrix.com>,
"Jan Beulich" <JBeulich@suse.com>,
"Suravee Suthikulpanit" <suravee.suthikulpanit@amd.com>,
"Brian Woods" <brian.woods@amd.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH 7/7] x86/hvm: Drop hvm_{vmx,svm} shorthands
Date: Thu, 30 Aug 2018 19:14:52 -0400 [thread overview]
Message-ID: <8155dfed-e90b-c6d0-2205-c5543d9833e9@oracle.com> (raw)
In-Reply-To: <b47d0426-de6d-a042-26d8-db36a6e7e5dc@oracle.com>
On 08/30/2018 07:11 PM, Boris Ostrovsky wrote:
> On 08/28/2018 01:39 PM, Andrew Cooper wrote:
>> By making {vmx,svm} in hvm_vcpu into an anonymous union (consistent with
>> domain side of things), the hvm_{vmx,svm} defines can be dropped, and all code
>> refer to the correctly-named fields. This means that the data hierachy is no
>> longer obscured from grep/cscope/tags/etc.
>>
>> Reformat one comment and switch one bool_t to bool while making changes.
>>
>> No functional change.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>>
> Do we still support pre-4.6 gcc?
Or 4.4.6? I don't remember.
-boris
> They have a bug that doesn't allow
> initializers for anonymous structs/unions. I don't know whether we have
> any for vmx/svm, but I thought I'd mention this just in case.
>
> Other than that, for SVM bits in patches 3,4,6 and 7
>
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-08-30 23:14 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-28 17:38 [PATCH 0/7] x86: Structure naming and consistency improvements Andrew Cooper
2018-08-28 17:39 ` [PATCH 1/7] x86/pv: Rename d->arch.pv_domain to d->arch.pv Andrew Cooper
2018-08-29 7:45 ` Wei Liu
2018-08-29 15:55 ` Jan Beulich
2018-08-28 17:39 ` [PATCH 2/7] x86/pv: Rename v->arch.pv_vcpu to v->arch.pv Andrew Cooper
2018-08-29 7:53 ` Wei Liu
2018-08-29 16:01 ` Jan Beulich
2018-08-28 17:39 ` [PATCH 3/7] xen/hvm: Rename d->arch.hvm_domain to d->arch.hvm Andrew Cooper
2018-08-28 18:56 ` Razvan Cojocaru
2018-08-29 7:56 ` Wei Liu
2018-08-30 1:34 ` Tian, Kevin
2018-08-30 14:39 ` Jan Beulich
2018-08-30 16:44 ` Julien Grall
2018-09-03 8:11 ` Paul Durrant
2018-08-28 17:39 ` [PATCH 4/7] x86/hvm: Rename v->arch.hvm_vcpu to v->arch.hvm Andrew Cooper
2018-08-28 18:59 ` Razvan Cojocaru
2018-08-29 7:57 ` Wei Liu
2018-08-30 1:34 ` Tian, Kevin
2018-08-30 14:52 ` Jan Beulich
2018-08-30 16:03 ` Andrew Cooper
2018-09-03 8:13 ` Paul Durrant
2018-08-28 17:39 ` [PATCH 5/7] x86/vtx: Rename arch_vmx_struct to vmx_vcpu Andrew Cooper
2018-08-29 8:03 ` Wei Liu
2018-08-29 11:17 ` Andrew Cooper
2018-08-29 13:16 ` Wei Liu
2018-08-30 1:36 ` Tian, Kevin
2018-08-30 14:54 ` Jan Beulich
2018-08-30 15:47 ` Andrew Cooper
2018-08-31 1:35 ` Tian, Kevin
2018-08-28 17:39 ` [PATCH 6/7] x86/svm: Rename arch_svm_struct to svm_vcpu Andrew Cooper
2018-08-30 14:54 ` Jan Beulich
2018-08-28 17:39 ` [PATCH 7/7] x86/hvm: Drop hvm_{vmx,svm} shorthands Andrew Cooper
2018-08-29 8:03 ` Wei Liu
2018-08-30 1:39 ` Tian, Kevin
2018-08-30 16:08 ` Andrew Cooper
2018-08-30 15:03 ` Jan Beulich
2018-08-30 23:11 ` Boris Ostrovsky
2018-08-30 23:14 ` Boris Ostrovsky [this message]
2018-08-30 23:18 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8155dfed-e90b-c6d0-2205-c5543d9833e9@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=brian.woods@amd.com \
--cc=george.dunlap@eu.citrix.com \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=roger.pau@citrix.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).