From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: wei.liu2@citrix.com, andrew.cooper3@citrix.com,
ian.jackson@eu.citrix.com, xen-devel@lists.xen.org,
jbeulich@suse.com, roger.pau@citrix.com
Subject: Re: [PATCH 03/10] pvh: Set online VCPU map to avail_vcpus
Date: Mon, 7 Nov 2016 10:52:15 -0500 [thread overview]
Message-ID: <8374b71e-dc72-286d-0a9c-4f999202e347@oracle.com> (raw)
In-Reply-To: <20161107153642.GK21570@char.us.oracle.com>
On 11/07/2016 10:36 AM, Konrad Rzeszutek Wilk wrote:
> On Sun, Nov 06, 2016 at 04:42:36PM -0500, Boris Ostrovsky wrote:
>> ACPI builder marks VCPUS set in vcpu_online map as enabled in MADT.
>> With ACPI-based CPU hotplug we only want VCPUs that are started by
>> the guest to be marked as such. Remaining VCPUs will be set to
> Oh, so this is a bug then? We always marked them as enabled?
> Is this mentioned somewhere in the ACPI docs?
>
> But what about guests that don't want to start their CPUs using
> ACPI but are using SMP MPtables?
This code is only applicable to PVH guests and it wasn't a bug because
until now I assumed PV-like CPU hotplug (where the guest would watch
xenstore). That required having all VCPUs marked as enabled in MADT and
the guest (well, Linux guest) would immediately offline them.
Now that we are going full-ACPI this is no longer the case.
>
>> "enable" by ACPI code during hotplug.
> . which ACPI code? The libacpi one? You may want to be specific.
> Or the QEMU code?
AML code in DSDT. I'll update the comment.
(No qemu --- this is PVH)
-boris
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-11-07 15:52 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-06 21:42 [PATCH 00/10] PVH VCPU hotplug support Boris Ostrovsky
2016-11-06 21:42 ` [PATCH 01/10] x86/domctl: Add XEN_DOMCTL_set_avail_vcpus Boris Ostrovsky
2016-11-07 15:30 ` Konrad Rzeszutek Wilk
2016-11-07 18:24 ` Boris Ostrovsky
2016-11-08 19:07 ` Daniel De Graaf
2016-11-06 21:42 ` [PATCH 02/10] acpi: Define ACPI IO registers for PVH guests Boris Ostrovsky
2016-11-06 21:42 ` [PATCH 03/10] pvh: Set online VCPU map to avail_vcpus Boris Ostrovsky
2016-11-07 15:36 ` Konrad Rzeszutek Wilk
2016-11-07 15:52 ` Boris Ostrovsky [this message]
2016-11-06 21:42 ` [PATCH 04/10] acpi: Power and Sleep ACPI buttons are not emulated Boris Ostrovsky
2016-11-07 15:38 ` Konrad Rzeszutek Wilk
2016-11-07 15:54 ` Boris Ostrovsky
2016-11-07 17:24 ` annie li
2016-11-06 21:42 ` [PATCH 05/10] acpi: Make pmtimer optional in FADT Boris Ostrovsky
2016-11-07 15:39 ` Konrad Rzeszutek Wilk
2016-11-06 21:42 ` [PATCH 06/10] acpi: PVH guests need _E02 method Boris Ostrovsky
2016-11-07 15:45 ` Konrad Rzeszutek Wilk
2016-11-07 16:08 ` Boris Ostrovsky
2016-11-07 16:08 ` Konrad Rzeszutek Wilk
2016-11-06 21:42 ` [PATCH 07/10] pvh/ioreq: Install handlers for ACPI-related PVH IO accesses Boris Ostrovsky
2016-11-07 9:39 ` Paul Durrant
2016-11-07 14:01 ` Boris Ostrovsky
2016-11-07 14:00 ` Paul Durrant
2016-11-06 21:42 ` [PATCH 08/10] pvh/acpi: Handle ACPI accesses for PVH guests Boris Ostrovsky
2016-11-07 9:51 ` Paul Durrant
2016-11-08 16:14 ` Boris Ostrovsky
2016-11-07 15:55 ` Konrad Rzeszutek Wilk
2016-11-07 16:20 ` Boris Ostrovsky
2016-11-07 16:47 ` Jan Beulich
2016-11-06 21:42 ` [PATCH 09/10] events/x86: Define SCI virtual interrupt Boris Ostrovsky
2016-11-07 16:05 ` Konrad Rzeszutek Wilk
2016-11-07 16:29 ` Boris Ostrovsky
2016-11-06 21:42 ` [PATCH 10/10] pvh: Send an SCI on VCPU hotplug event Boris Ostrovsky
2016-11-07 11:41 ` [PATCH 00/10] PVH VCPU hotplug support Andrew Cooper
2016-11-07 14:19 ` Boris Ostrovsky
2016-11-07 14:46 ` Andrew Cooper
2016-11-07 15:30 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8374b71e-dc72-286d-0a9c-4f999202e347@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=roger.pau@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).