From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH RFC] xen/mapcache: store dma information in revmapcache entries for debugging Date: Wed, 3 May 2017 10:55:31 +0200 Message-ID: <84b6b9c8-274c-5387-5bcd-d34584dd398c@redhat.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Stefano Stabellini , anthony.perard@citrix.com Cc: xen-devel@lists.xensource.com, crosthwaite.peter@gmail.com, qemu-devel@nongnu.org, x1917x@gmail.com, hrgstephen@gmail.com, rth@twiddle.net List-Id: xen-devel@lists.xenproject.org CgpPbiAwMy8wNS8yMDE3IDAyOjA4LCBTdGVmYW5vIFN0YWJlbGxpbmkgd3JvdGU6Cj4gVGhlIFhl biBtYXBjYWNoZSBpcyBhYmxlIHRvIGNyZWF0ZSBsb25nIHRlcm0gbWFwcGluZ3MsIHRoZXkgYXJl IGNhbGxlZAo+ICJsb2NrZWQiIG1hcHBpbmdzLiBUaGUgdGhpcmQgcGFyYW1ldGVyIG9mIHRoZSB4 ZW5fbWFwX2NhY2hlIGNhbGwKPiBzcGVjaWZpZXMgaWYgYSBtYXBwaW5nIGlzIGEgImxvY2tlZCIg bWFwcGluZy4KPiAKPiAKPiBGcm9tIHRoZSBRRU1VIHBvaW50IG9mIHZpZXcgdGhlcmUgYXJlIHR3 byBraW5kcyBvZiBsb25nIHRlcm0gbWFwcGluZ3M6Cj4gCj4gW2FdIGRldmljZSBtZW1vcnkgbWFw cGluZ3MsIHN1Y2ggYXMgb3B0aW9uIHJvbXMgYW5kIHZpZGVvIG1lbW9yeQo+IFtiXSBkbWEgbWFw cGluZ3MsIGNyZWF0ZWQgYnkgZG1hX21lbW9yeV9tYXAgJiBmcmllbmRzCj4gCj4gQWZ0ZXIgY2Vy dGFpbiBvcGVyYXRpb25zLCBiYWxsb29uaW5nIGEgVk0gaW4gcGFydGljdWxhciwgWGVuIGFza3Mg UUVNVQo+IGtpbmRseSB0byBkZXN0cm95IGFsbCBtYXBwaW5ncy4gSG93ZXZlciwgY2VydGFpbmx5 IFthXSBtYXBwaW5ncyBhcmUKPiBwcmVzZW50IGFuZCBjYW5ub3QgYmUgcmVtb3ZlZC4gVGhhdCdz IG5vdCBhIHByb2JsZW0gYXMgdGhleSBhcmUgbm90Cj4gYWZmZWN0ZWQgYnkgYmFsbG9vbm5pbmcu IFRoZSAqcmVhbCogcHJvYmxlbSBpcyB0aGF0IGlmIHRoZXJlIGFyZSBhbnkKPiBtYXBwaW5ncyBv ZiB0eXBlIFtiXSwgYW55IG91dHN0YW5kaW5nIGRtYSBvcGVyYXRpb25zIGNvdWxkIGZhaWwuIFRo aXMgaXMKPiBhIGtub3duIHNob3J0Y29taW5nLiBJbiBvdGhlciB3b3Jkcywgd2hlbiBYZW4gYXNr cyBRRU1VIHRvIGRlc3Ryb3kgYWxsCj4gbWFwcGluZ3MsIGl0IGlzIGFuIGVycm9yIGlmIGFueSBb Yl0gbWFwcGluZ3MgZXhpc3QuCj4gCj4gSG93ZXZlciB0b2RheSB3ZSBoYXZlIG5vIHdheSBvZiBk aXN0aW5ndWlzaGluZyBbYV0gZnJvbSBbYl0uIEJlY2F1c2Ugb2YKPiB0aGF0LCB3ZSBjYW5ub3Qg ZXZlbiBwcmludCBhIGRlY2VudCB3YXJuaW5nLgo+IAo+IFRoaXMgcGF0Y2ggaW50cm9kdWNlcyBh IG5ldyAiZG1hIiBib29sIGZpZWxkIHRvIE1hcENhY2hlUmV2IGVudGlyZXMsIHRvCj4gcmVtZW1i ZXIgaWYgYSBnaXZlbiBtYXBwaW5nIGlzIGZvciBkbWEgb3IgaXMgYSBsb25nIHRlcm0gZGV2aWNl IG1lbW9yeQo+IG1hcHBpbmcuIFdoZW4geGVuX2ludmFsaWRhdGVfbWFwX2NhY2hlIGlzIGNhbGxl ZCwgd2UgcHJpbnQgYSB3YXJuaW5nIGlmCj4gYW55IFtiXSBtYXBwaW5ncyBleGlzdC4gV2UgaWdu b3JlIFthXSBtYXBwaW5ncy4KPiAKPiBNYXBwaW5ncyBjcmVhdGVkIGJ5IHFlbXVfbWFwX3JhbV9w dHIgYXJlIGFzc3VtZWQgdG8gYmUgW2FdLCB3aGlsZQo+IG1hcHBpbmdzIGNyZWF0ZWQgYnkgYWRk cmVzc19zcGFjZV9tYXAtPnFlbXVfcmFtX3B0cl9sZW5ndGggYXJlIGFzc3VtZWQKPiB0byBiZSBb Yl0uCj4gCj4gVGhlIGdvYWwgb2YgdGhlIHBhdGNoIGlzIHRvIG1ha2UgZGVidWdnaW5nIGFuZCBz eXN0ZW0gdW5kZXJzdGFuZGluZwo+IGVhc2llci4KClN1cmUsIHdoeSBub3QuCgpBY2tlZC1ieTog UGFvbG8gQm9uemluaSA8cGJvbnppbmlAcmVkaGF0LmNvbT4KClBhb2xvCgo+IFNpZ25lZC1vZmYt Ynk6IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz4KPiAKPiBkaWZm IC0tZ2l0IGEvZXhlYy5jIGIvZXhlYy5jCj4gaW5kZXggZWFjNjA4NS4uODU3NjllMSAxMDA2NDQK PiAtLS0gYS9leGVjLmMKPiArKysgYi9leGVjLmMKPiBAQCAtMjA4NCwxMCArMjA4NCwxMCBAQCB2 b2lkICpxZW11X21hcF9yYW1fcHRyKFJBTUJsb2NrICpyYW1fYmxvY2ssIHJhbV9hZGRyX3QgYWRk cikKPiAgICAgICAgICAgKiBJbiB0aGF0IGNhc2UganVzdCBtYXAgdW50aWwgdGhlIGVuZCBvZiB0 aGUgcGFnZS4KPiAgICAgICAgICAgKi8KPiAgICAgICAgICBpZiAoYmxvY2stPm9mZnNldCA9PSAw KSB7Cj4gLSAgICAgICAgICAgIHJldHVybiB4ZW5fbWFwX2NhY2hlKGFkZHIsIDAsIDApOwo+ICsg ICAgICAgICAgICByZXR1cm4geGVuX21hcF9jYWNoZShhZGRyLCAwLCAwLCBmYWxzZSk7Cj4gICAg ICAgICAgfQo+ICAKPiAtICAgICAgICBibG9jay0+aG9zdCA9IHhlbl9tYXBfY2FjaGUoYmxvY2st Pm9mZnNldCwgYmxvY2stPm1heF9sZW5ndGgsIDEpOwo+ICsgICAgICAgIGJsb2NrLT5ob3N0ID0g eGVuX21hcF9jYWNoZShibG9jay0+b2Zmc2V0LCBibG9jay0+bWF4X2xlbmd0aCwgMSwgZmFsc2Up Owo+ICAgICAgfQo+ICAgICAgcmV0dXJuIHJhbWJsb2NrX3B0cihibG9jaywgYWRkcik7Cj4gIH0K PiBAQCAtMjExNywxMCArMjExNywxMCBAQCBzdGF0aWMgdm9pZCAqcWVtdV9yYW1fcHRyX2xlbmd0 aChSQU1CbG9jayAqcmFtX2Jsb2NrLCByYW1fYWRkcl90IGFkZHIsCj4gICAgICAgICAgICogSW4g dGhhdCBjYXNlIGp1c3QgbWFwIHRoZSByZXF1ZXN0ZWQgYXJlYS4KPiAgICAgICAgICAgKi8KPiAg ICAgICAgICBpZiAoYmxvY2stPm9mZnNldCA9PSAwKSB7Cj4gLSAgICAgICAgICAgIHJldHVybiB4 ZW5fbWFwX2NhY2hlKGFkZHIsICpzaXplLCAxKTsKPiArICAgICAgICAgICAgcmV0dXJuIHhlbl9t YXBfY2FjaGUoYWRkciwgKnNpemUsIDEsIHRydWUpOwo+ICAgICAgICAgIH0KPiAgCj4gLSAgICAg ICAgYmxvY2stPmhvc3QgPSB4ZW5fbWFwX2NhY2hlKGJsb2NrLT5vZmZzZXQsIGJsb2NrLT5tYXhf bGVuZ3RoLCAxKTsKPiArICAgICAgICBibG9jay0+aG9zdCA9IHhlbl9tYXBfY2FjaGUoYmxvY2st Pm9mZnNldCwgYmxvY2stPm1heF9sZW5ndGgsIDEsIHRydWUpOwo+ICAgICAgfQo+ICAKPiAgICAg IHJldHVybiByYW1ibG9ja19wdHIoYmxvY2ssIGFkZHIpOwo+IGRpZmYgLS1naXQgYS9ody9pMzg2 L3hlbi94ZW4tbWFwY2FjaGUuYyBiL2h3L2kzODYveGVuL3hlbi1tYXBjYWNoZS5jCj4gaW5kZXgg MzFkZWJkZi4uZmE0MjgyYSAxMDA2NDQKPiAtLS0gYS9ody9pMzg2L3hlbi94ZW4tbWFwY2FjaGUu Ywo+ICsrKyBiL2h3L2kzODYveGVuL3hlbi1tYXBjYWNoZS5jCj4gQEAgLTYyLDYgKzYyLDcgQEAg dHlwZWRlZiBzdHJ1Y3QgTWFwQ2FjaGVSZXYgewo+ICAgICAgaHdhZGRyIHBhZGRyX2luZGV4Owo+ ICAgICAgaHdhZGRyIHNpemU7Cj4gICAgICBRVEFJTFFfRU5UUlkoTWFwQ2FjaGVSZXYpIG5leHQ7 Cj4gKyAgICBib29sIGRtYTsKPiAgfSBNYXBDYWNoZVJldjsKPiAgCj4gIHR5cGVkZWYgc3RydWN0 IE1hcENhY2hlIHsKPiBAQCAtMjAyLDcgKzIwMyw3IEBAIHN0YXRpYyB2b2lkIHhlbl9yZW1hcF9i dWNrZXQoTWFwQ2FjaGVFbnRyeSAqZW50cnksCj4gIH0KPiAgCj4gIHN0YXRpYyB1aW50OF90ICp4 ZW5fbWFwX2NhY2hlX3VubG9ja2VkKGh3YWRkciBwaHlzX2FkZHIsIGh3YWRkciBzaXplLAo+IC0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1aW50OF90IGxvY2spCj4gKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVpbnQ4X3QgbG9jaywgYm9vbCBk bWEpCj4gIHsKPiAgICAgIE1hcENhY2hlRW50cnkgKmVudHJ5LCAqcGVudHJ5ID0gTlVMTDsKPiAg ICAgIGh3YWRkciBhZGRyZXNzX2luZGV4Owo+IEBAIC0yODksNiArMjkwLDcgQEAgdHJ5YWdhaW46 Cj4gICAgICBpZiAobG9jaykgewo+ICAgICAgICAgIE1hcENhY2hlUmV2ICpyZXZlbnRyeSA9IGdf bWFsbG9jMChzaXplb2YoTWFwQ2FjaGVSZXYpKTsKPiAgICAgICAgICBlbnRyeS0+bG9jaysrOwo+ ICsgICAgICAgIHJldmVudHJ5LT5kbWEgPSBkbWE7Cj4gICAgICAgICAgcmV2ZW50cnktPnZhZGRy X3JlcSA9IG1hcGNhY2hlLT5sYXN0X2VudHJ5LT52YWRkcl9iYXNlICsgYWRkcmVzc19vZmZzZXQ7 Cj4gICAgICAgICAgcmV2ZW50cnktPnBhZGRyX2luZGV4ID0gbWFwY2FjaGUtPmxhc3RfZW50cnkt PnBhZGRyX2luZGV4Owo+ICAgICAgICAgIHJldmVudHJ5LT5zaXplID0gZW50cnktPnNpemU7Cj4g QEAgLTMwMCwxMiArMzAyLDEyIEBAIHRyeWFnYWluOgo+ICB9Cj4gIAo+ICB1aW50OF90ICp4ZW5f bWFwX2NhY2hlKGh3YWRkciBwaHlzX2FkZHIsIGh3YWRkciBzaXplLAo+IC0gICAgICAgICAgICAg ICAgICAgICAgIHVpbnQ4X3QgbG9jaykKPiArICAgICAgICAgICAgICAgICAgICAgICB1aW50OF90 IGxvY2ssIGJvb2wgZG1hKQo+ICB7Cj4gICAgICB1aW50OF90ICpwOwo+ICAKPiAgICAgIG1hcGNh Y2hlX2xvY2soKTsKPiAtICAgIHAgPSB4ZW5fbWFwX2NhY2hlX3VubG9ja2VkKHBoeXNfYWRkciwg c2l6ZSwgbG9jayk7Cj4gKyAgICBwID0geGVuX21hcF9jYWNoZV91bmxvY2tlZChwaHlzX2FkZHIs IHNpemUsIGxvY2ssIGRtYSk7Cj4gICAgICBtYXBjYWNoZV91bmxvY2soKTsKPiAgICAgIHJldHVy biBwOwo+ICB9Cj4gQEAgLTQyNiw4ICs0MjgsMTAgQEAgdm9pZCB4ZW5faW52YWxpZGF0ZV9tYXBf Y2FjaGUodm9pZCkKPiAgICAgIG1hcGNhY2hlX2xvY2soKTsKPiAgCj4gICAgICBRVEFJTFFfRk9S RUFDSChyZXZlbnRyeSwgJm1hcGNhY2hlLT5sb2NrZWRfZW50cmllcywgbmV4dCkgewo+IC0gICAg ICAgIERQUklOVEYoIlRoZXJlIHNob3VsZCBiZSBubyBsb2NrZWQgbWFwcGluZ3MgYXQgdGhpcyB0 aW1lLCAiCj4gLSAgICAgICAgICAgICAgICAiYnV0ICJUQVJHRVRfRk1UX3BseCIgLT4gJXAgaXMg cHJlc2VudFxuIiwKPiArICAgICAgICBpZiAoIXJldmVudHJ5LT5kbWEpCj4gKyAgICAgICAgICAg IGNvbnRpbnVlOwo+ICsgICAgICAgIGZwcmludGYoc3RkZXJyLCAiTG9ja2VkIERNQSBtYXBwaW5n IHdoaWxlIGludmFsaWRhdGluZyBtYXBjYWNoZSEiCj4gKyAgICAgICAgICAgICAgICAiICJUQVJH RVRfRk1UX3BseCIgLT4gJXAgaXMgcHJlc2VudFxuIiwKPiAgICAgICAgICAgICAgICAgIHJldmVu dHJ5LT5wYWRkcl9pbmRleCwgcmV2ZW50cnktPnZhZGRyX3JlcSk7Cj4gICAgICB9Cj4gIAo+IGRp ZmYgLS1naXQgYS9pbmNsdWRlL3N5c2VtdS94ZW4tbWFwY2FjaGUuaCBiL2luY2x1ZGUvc3lzZW11 L3hlbi1tYXBjYWNoZS5oCj4gaW5kZXggYjhjOTNiOS4uMDFkYWFhZCAxMDA2NDQKPiAtLS0gYS9p bmNsdWRlL3N5c2VtdS94ZW4tbWFwY2FjaGUuaAo+ICsrKyBiL2luY2x1ZGUvc3lzZW11L3hlbi1t YXBjYWNoZS5oCj4gQEAgLTE3LDcgKzE3LDcgQEAgdHlwZWRlZiBod2FkZHIgKCpwaHlzX29mZnNl dF90b19nYWRkcl90KShod2FkZHIgc3RhcnRfYWRkciwKPiAgdm9pZCB4ZW5fbWFwX2NhY2hlX2lu aXQocGh5c19vZmZzZXRfdG9fZ2FkZHJfdCBmLAo+ICAgICAgICAgICAgICAgICAgICAgICAgICB2 b2lkICpvcGFxdWUpOwo+ICB1aW50OF90ICp4ZW5fbWFwX2NhY2hlKGh3YWRkciBwaHlzX2FkZHIs IGh3YWRkciBzaXplLAo+IC0gICAgICAgICAgICAgICAgICAgICAgIHVpbnQ4X3QgbG9jayk7Cj4g KyAgICAgICAgICAgICAgICAgICAgICAgdWludDhfdCBsb2NrLCBib29sIGRtYSk7Cj4gIHJhbV9h ZGRyX3QgeGVuX3JhbV9hZGRyX2Zyb21fbWFwY2FjaGUodm9pZCAqcHRyKTsKPiAgdm9pZCB4ZW5f aW52YWxpZGF0ZV9tYXBfY2FjaGVfZW50cnkodWludDhfdCAqYnVmZmVyKTsKPiAgdm9pZCB4ZW5f aW52YWxpZGF0ZV9tYXBfY2FjaGUodm9pZCk7Cj4gQEAgLTMxLDcgKzMxLDggQEAgc3RhdGljIGlu bGluZSB2b2lkIHhlbl9tYXBfY2FjaGVfaW5pdChwaHlzX29mZnNldF90b19nYWRkcl90IGYsCj4g IAo+ICBzdGF0aWMgaW5saW5lIHVpbnQ4X3QgKnhlbl9tYXBfY2FjaGUoaHdhZGRyIHBoeXNfYWRk ciwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGh3YWRkciBzaXplLAo+ IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdWludDhfdCBsb2NrKQo+ICsg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdWludDhfdCBsb2NrLAo+ICsgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYm9vbCBkbWEpCj4gIHsKPiAgICAgIGFi b3J0KCk7Cj4gIH0KPiAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0 cHM6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=