From: Marek Marczykowski <marmarek@mimuw.edu.pl>
To: xen-devel@lists.xensource.com
Cc: marmarek@mimuw.edu.pl
Subject: [PATCH] libxl: do not try to detach pci device when none attached
Date: Fri, 10 Jun 2011 01:33:28 +0200 [thread overview]
Message-ID: <88f67b423c89f4bd6048.1307662408@devel14> (raw)
# HG changeset patch
# User Marek Marczykowski <marmarek@mimuw.edu.pl>
# Date 1307662302 -7200
# Node ID 88f67b423c89f4bd604837b9eae2483dad5ebb0d
# Parent 4b392511ae0840fba66c40aa2788dc1ff402b6e8
libxl: do not try to detach pci device when none attached
Fixes SEGV on domain destroy
Signed-off-by: Marek Marczykowski <marmarek@mimuw.edu.pl>
diff --git a/tools/libxl/libxl_pci.c b/tools/libxl/libxl_pci.c
--- a/tools/libxl/libxl_pci.c
+++ b/tools/libxl/libxl_pci.c
@@ -1039,6 +1039,8 @@ int libxl_device_pci_shutdown(libxl_ctx
rc = libxl_device_pci_list_assigned(ctx, &pcidevs, domid, &num);
if ( rc )
return rc;
+ if ( num == 0 )
+ return 0;
for (i = 0; i < num; i++) {
/* Force remove on shutdown since, on HVM, qemu will not always
* respond to SCI interrupt because the guest kernel has shut down the
next reply other threads:[~2011-06-09 23:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-09 23:33 Marek Marczykowski [this message]
2011-06-10 10:44 ` [PATCH] libxl: do not try to detach pci device when none attached Stefano Stabellini
2011-06-10 10:48 ` Marek Marczykowski
2011-06-10 11:03 ` Stefano Stabellini
2011-06-10 11:14 ` Marek Marczykowski
2011-06-21 16:36 ` Ian Jackson
2011-06-21 16:34 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88f67b423c89f4bd6048.1307662408@devel14 \
--to=marmarek@mimuw.edu.pl \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).