From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Durrant Subject: Re: [PATCH v3 1/3] x86/HVM: drop hvm_fetch_from_guest_linear() Date: Thu, 6 Sep 2018 14:51:09 +0000 Message-ID: <8a8b2566526c4b5cb146cbbf8304e5bd@AMSPEX02CL03.citrite.net> References: <5B87CF6302000078001E37A6@prv1-mh.provo.novell.com> <5B91249102000078001E5F08@prv1-mh.provo.novell.com> <5B91259202000078001E5F17@prv1-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1fxvcm-0007IP-Hv for xen-devel@lists.xenproject.org; Thu, 06 Sep 2018 14:51:12 +0000 In-Reply-To: <5B91259202000078001E5F17@prv1-mh.provo.novell.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: 'Jan Beulich' , xen-devel Cc: Andrew Cooper , Olaf Hering , "Tim (Xen.org)" List-Id: xen-devel@lists.xenproject.org PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+IEZyb206IEphbiBCZXVsaWNoIFttYWlsdG86 SkJldWxpY2hAc3VzZS5jb21dCj4gU2VudDogMDYgU2VwdGVtYmVyIDIwMTggMTQ6MDMKPiBUbzog eGVuLWRldmVsIDx4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmc+Cj4gQ2M6IE9sYWYgSGVy aW5nIDxvbGFmQGFlcGZsZS5kZT47IEFuZHJldyBDb29wZXIKPiA8QW5kcmV3LkNvb3BlcjNAY2l0 cml4LmNvbT47IFBhdWwgRHVycmFudCA8UGF1bC5EdXJyYW50QGNpdHJpeC5jb20+Owo+IFRpbSAo WGVuLm9yZykgPHRpbUB4ZW4ub3JnPgo+IFN1YmplY3Q6IFtQQVRDSCB2MyAxLzNdIHg4Ni9IVk06 IGRyb3AgaHZtX2ZldGNoX2Zyb21fZ3Vlc3RfbGluZWFyKCkKPiAKPiBJdCBjYW4gZWFzaWx5IGJl IGV4cHJlc3NlZCB0aHJvdWdoIGh2bV9jb3B5X2Zyb21fZ3Vlc3RfbGluZWFyKCksIGFuZCBpbgo+ IHR3byBjYXNlcyB0aGlzIGV2ZW4gc2ltcGxpZmllcyBjYWxsZXJzLgo+IAo+IFN1Z2dlc3RlZC1i eTogUGF1bCBEdXJyYW50IDxwYXVsLmR1cnJhbnRAY2l0cml4LmNvbT4KPiBTaWduZWQtb2ZmLWJ5 OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+Cj4gUmV2aWV3ZWQtYnk6IEFuZHJldyBD b29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+Cj4gVGVzdGVkLWJ5OiBPbGFmIEhlcmlu ZyA8b2xhZkBhZXBmbGUuZGU+CgpSZXZpZXdlZC1ieTogUGF1bCBEdXJyYW50IDxwYXVsLmR1cnJh bnRAY2l0cml4LmNvbT4KCj4gLS0tCj4gdjI6IE1ha2Ugc3VyZSB0aGlzIGNvbXBpbGVzIHN0YW5k YWxvbmUuIFNsaWdodGx5IGFkanVzdCBjaGFuZ2UgaW4KPiAgICAgaHZtX3VkX2ludGVyY2VwdCgp Lgo+IAo+IC0tLSBhL3hlbi9hcmNoL3g4Ni9odm0vZW11bGF0ZS5jCj4gKysrIGIveGVuL2FyY2gv eDg2L2h2bS9lbXVsYXRlLmMKPiBAQCAtMTA2MCw2ICsxMDYwLDggQEAgc3RhdGljIGludCBfX2h2 bWVtdWxfcmVhZCgKPiAgICAgICAgICBwZmVjIHw9IFBGRUNfaW1wbGljaXQ7Cj4gICAgICBlbHNl IGlmICggaHZtZW11bF9jdHh0LT5zZWdfcmVnW3g4Nl9zZWdfc3NdLmRwbCA9PSAzICkKPiAgICAg ICAgICBwZmVjIHw9IFBGRUNfdXNlcl9tb2RlOwo+ICsgICAgaWYgKCBhY2Nlc3NfdHlwZSA9PSBo dm1fYWNjZXNzX2luc25fZmV0Y2ggKQo+ICsgICAgICAgIHBmZWMgfD0gUEZFQ19pbnNuX2ZldGNo Owo+IAo+ICAgICAgcmMgPSBodm1lbXVsX3ZpcnR1YWxfdG9fbGluZWFyKAo+ICAgICAgICAgIHNl Zywgb2Zmc2V0LCBieXRlcywgJnJlcHMsIGFjY2Vzc190eXBlLCBodm1lbXVsX2N0eHQsICZhZGRy KTsKPiBAQCAtMTA3MSw5ICsxMDczLDcgQEAgc3RhdGljIGludCBfX2h2bWVtdWxfcmVhZCgKPiAg ICAgICAgICAgKHZpby0+bW1pb19nbGEgPT0gKGFkZHIgJiBQQUdFX01BU0spKSApCj4gICAgICAg ICAgcmV0dXJuIGh2bWVtdWxfbGluZWFyX21taW9fcmVhZChhZGRyLCBieXRlcywgcF9kYXRhLCBw ZmVjLAo+IGh2bWVtdWxfY3R4dCwgMSk7Cj4gCj4gLSAgICByYyA9ICgoYWNjZXNzX3R5cGUgPT0g aHZtX2FjY2Vzc19pbnNuX2ZldGNoKSA/Cj4gLSAgICAgICAgICBodm1fZmV0Y2hfZnJvbV9ndWVz dF9saW5lYXIocF9kYXRhLCBhZGRyLCBieXRlcywgcGZlYywgJnBmaW5mbykgOgo+IC0gICAgICAg ICAgaHZtX2NvcHlfZnJvbV9ndWVzdF9saW5lYXIocF9kYXRhLCBhZGRyLCBieXRlcywgcGZlYywg JnBmaW5mbykpOwo+ICsgICAgcmMgPSBodm1fY29weV9mcm9tX2d1ZXN0X2xpbmVhcihwX2RhdGEs IGFkZHIsIGJ5dGVzLCBwZmVjLCAmcGZpbmZvKTsKPiAKPiAgICAgIHN3aXRjaCAoIHJjICkKPiAg ICAgIHsKPiBAQCAtMjUxMiw5ICsyNTEyLDEwIEBAIHZvaWQgaHZtX2VtdWxhdGVfaW5pdF9wZXJf aW5zbigKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGh2bV9hY2Nl c3NfaW5zbl9mZXRjaCwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICZodm1lbXVsX2N0eHQtPnNlZ19yZWdbeDg2X3NlZ19jc10sCj4gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAmYWRkcikgJiYKPiAtICAgICAgICAgICAgIGh2bV9mZXRj aF9mcm9tX2d1ZXN0X2xpbmVhcihodm1lbXVsX2N0eHQtPmluc25fYnVmLCBhZGRyLAo+IC0gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHNpemVvZihodm1lbXVsX2N0eHQt Pmluc25fYnVmKSwKPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBw ZmVjLCBOVUxMKSA9PSBIVk1UUkFOU19va2F5KSA/Cj4gKyAgICAgICAgICAgICBodm1fY29weV9m cm9tX2d1ZXN0X2xpbmVhcihodm1lbXVsX2N0eHQtPmluc25fYnVmLCBhZGRyLAo+ICsgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc2l6ZW9mKGh2bWVtdWxfY3R4dC0+aW5z bl9idWYpLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcGZlYyB8 IFBGRUNfaW5zbl9mZXRjaCwKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIE5VTEwpID09IEhWTVRSQU5TX29rYXkpID8KPiAgICAgICAgICAgICAgc2l6ZW9mKGh2bWVt dWxfY3R4dC0+aW5zbl9idWYpIDogMDsKPiAgICAgIH0KPiAgICAgIGVsc2UKPiAtLS0gYS94ZW4v YXJjaC94ODYvaHZtL2h2bS5jCj4gKysrIGIveGVuL2FyY2gveDg2L2h2bS9odm0uYwo+IEBAIC0z Mjg2LDE1ICszMjg2LDYgQEAgZW51bSBodm1fdHJhbnNsYXRpb25fcmVzdWx0IGh2bV9jb3B5X2Zy bwo+ICAgICAgICAgICAgICAgICAgICAgICAgUEZFQ19wYWdlX3ByZXNlbnQgfCBwZmVjLCBwZmlu Zm8pOwo+ICB9Cj4gCj4gLWVudW0gaHZtX3RyYW5zbGF0aW9uX3Jlc3VsdCBodm1fZmV0Y2hfZnJv bV9ndWVzdF9saW5lYXIoCj4gLSAgICB2b2lkICpidWYsIHVuc2lnbmVkIGxvbmcgYWRkciwgaW50 IHNpemUsIHVpbnQzMl90IHBmZWMsCj4gLSAgICBwYWdlZmF1bHRfaW5mb190ICpwZmluZm8pCj4g LXsKPiAtICAgIHJldHVybiBfX2h2bV9jb3B5KGJ1ZiwgYWRkciwgc2l6ZSwgY3VycmVudCwKPiAt ICAgICAgICAgICAgICAgICAgICAgIEhWTUNPUFlfZnJvbV9ndWVzdCB8IEhWTUNPUFlfbGluZWFy LAo+IC0gICAgICAgICAgICAgICAgICAgICAgUEZFQ19wYWdlX3ByZXNlbnQgfCBQRkVDX2luc25f ZmV0Y2ggfCBwZmVjLCBwZmluZm8pOwo+IC19Cj4gLQo+ICB1bnNpZ25lZCBsb25nIGNvcHlfdG9f dXNlcl9odm0odm9pZCAqdG8sIGNvbnN0IHZvaWQgKmZyb20sIHVuc2lnbmVkIGludAo+IGxlbikK PiAgewo+ICAgICAgaW50IHJjOwo+IEBAIC0zNzQwLDE2ICszNzMxLDE2IEBAIHZvaWQgaHZtX3Vk X2ludGVyY2VwdChzdHJ1Y3QgY3B1X3VzZXJfcmUKPiAgICAgIGlmICggb3B0X2h2bV9mZXAgKQo+ ICAgICAgewo+ICAgICAgICAgIGNvbnN0IHN0cnVjdCBzZWdtZW50X3JlZ2lzdGVyICpjcyA9ICZj dHh0LnNlZ19yZWdbeDg2X3NlZ19jc107Cj4gLSAgICAgICAgdWludDMyX3Qgd2FsayA9IChjdHh0 LnNlZ19yZWdbeDg2X3NlZ19zc10uZHBsID09IDMpCj4gLSAgICAgICAgICAgID8gUEZFQ191c2Vy X21vZGUgOiAwOwo+ICsgICAgICAgIHVpbnQzMl90IHdhbGsgPSAoKGN0eHQuc2VnX3JlZ1t4ODZf c2VnX3NzXS5kcGwgPT0gMykKPiArICAgICAgICAgICAgICAgICAgICAgICAgID8gUEZFQ191c2Vy X21vZGUgOiAwKSB8IFBGRUNfaW5zbl9mZXRjaDsKPiAgICAgICAgICB1bnNpZ25lZCBsb25nIGFk ZHI7Cj4gICAgICAgICAgY2hhciBzaWdbNV07IC8qIHVkMjsgLmFzY2lpICJ4ZW4iICovCj4gCj4g ICAgICAgICAgaWYgKCBodm1fdmlydHVhbF90b19saW5lYXJfYWRkcih4ODZfc2VnX2NzLCBjcywg cmVncy0+cmlwLAo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc2l6 ZW9mKHNpZyksIGh2bV9hY2Nlc3NfaW5zbl9mZXRjaCwKPiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGNzLCAmYWRkcikgJiYKPiAtICAgICAgICAgICAgIChodm1fZmV0 Y2hfZnJvbV9ndWVzdF9saW5lYXIoc2lnLCBhZGRyLCBzaXplb2Yoc2lnKSwKPiAtICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgd2FsaywgTlVMTCkgPT0gSFZNVFJBTlNf b2theSkgJiYKPiArICAgICAgICAgICAgIChodm1fY29weV9mcm9tX2d1ZXN0X2xpbmVhcihzaWcs IGFkZHIsIHNpemVvZihzaWcpLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIHdhbGssIE5VTEwpID09IEhWTVRSQU5TX29rYXkpICYmCj4gICAgICAgICAgICAgICAo bWVtY21wKHNpZywgIlx4Zlx4YnhlbiIsIHNpemVvZihzaWcpKSA9PSAwKSApCj4gICAgICAgICAg ewo+ICAgICAgICAgICAgICByZWdzLT5yaXAgKz0gc2l6ZW9mKHNpZyk7Cj4gLS0tIGEveGVuL2Fy Y2gveDg2L21tL3NoYWRvdy9jb21tb24uYwo+ICsrKyBiL3hlbi9hcmNoL3g4Ni9tbS9zaGFkb3cv Y29tbW9uLmMKPiBAQCAtMTY0LDggKzE2NCw5IEBAIGNvbnN0IHN0cnVjdCB4ODZfZW11bGF0ZV9v cHMgKnNoYWRvd19pbmkKPiAgICAgICAgICAoIWh2bV90cmFuc2xhdGVfdmlydHVhbF9hZGRyKAo+ ICAgICAgICAgICAgICB4ODZfc2VnX2NzLCByZWdzLT5yaXAsIHNpemVvZihzaF9jdHh0LT5pbnNu X2J1ZiksCj4gICAgICAgICAgICAgIGh2bV9hY2Nlc3NfaW5zbl9mZXRjaCwgc2hfY3R4dCwgJmFk ZHIpICYmCj4gLSAgICAgICAgICFodm1fZmV0Y2hfZnJvbV9ndWVzdF9saW5lYXIoCj4gLSAgICAg ICAgICAgICBzaF9jdHh0LT5pbnNuX2J1ZiwgYWRkciwgc2l6ZW9mKHNoX2N0eHQtPmluc25fYnVm KSwgMCwgTlVMTCkpCj4gKyAgICAgICAgICFodm1fY29weV9mcm9tX2d1ZXN0X2xpbmVhcigKPiAr ICAgICAgICAgICAgIHNoX2N0eHQtPmluc25fYnVmLCBhZGRyLCBzaXplb2Yoc2hfY3R4dC0+aW5z bl9idWYpLAo+ICsgICAgICAgICAgICAgUEZFQ19pbnNuX2ZldGNoLCBOVUxMKSkKPiAgICAgICAg ICA/IHNpemVvZihzaF9jdHh0LT5pbnNuX2J1ZikgOiAwOwo+IAo+ICAgICAgcmV0dXJuICZodm1f c2hhZG93X2VtdWxhdG9yX29wczsKPiBAQCAtMTk4LDggKzE5OSw5IEBAIHZvaWQgc2hhZG93X2Nv bnRpbnVlX2VtdWxhdGlvbihzdHJ1Y3Qgc2gKPiAgICAgICAgICAgICAgKCFodm1fdHJhbnNsYXRl X3ZpcnR1YWxfYWRkcigKPiAgICAgICAgICAgICAgICAgIHg4Nl9zZWdfY3MsIHJlZ3MtPnJpcCwg c2l6ZW9mKHNoX2N0eHQtPmluc25fYnVmKSwKPiAgICAgICAgICAgICAgICAgIGh2bV9hY2Nlc3Nf aW5zbl9mZXRjaCwgc2hfY3R4dCwgJmFkZHIpICYmCj4gLSAgICAgICAgICAgICAhaHZtX2ZldGNo X2Zyb21fZ3Vlc3RfbGluZWFyKAo+IC0gICAgICAgICAgICAgICAgIHNoX2N0eHQtPmluc25fYnVm LCBhZGRyLCBzaXplb2Yoc2hfY3R4dC0+aW5zbl9idWYpLCAwLCBOVUxMKSkKPiArICAgICAgICAg ICAgICFodm1fY29weV9mcm9tX2d1ZXN0X2xpbmVhcigKPiArICAgICAgICAgICAgICAgICBzaF9j dHh0LT5pbnNuX2J1ZiwgYWRkciwgc2l6ZW9mKHNoX2N0eHQtPmluc25fYnVmKSwKPiArICAgICAg ICAgICAgICAgICBQRkVDX2luc25fZmV0Y2gsIE5VTEwpKQo+ICAgICAgICAgICAgICA/IHNpemVv ZihzaF9jdHh0LT5pbnNuX2J1ZikgOiAwOwo+ICAgICAgICAgIHNoX2N0eHQtPmluc25fYnVmX2Vp cCA9IHJlZ3MtPnJpcDsKPiAgICAgIH0KPiAtLS0gYS94ZW4vYXJjaC94ODYvbW0vc2hhZG93L2h2 bS5jCj4gKysrIGIveGVuL2FyY2gveDg2L21tL3NoYWRvdy9odm0uYwo+IEBAIC0xMjIsMTAgKzEy MiwxMCBAQCBodm1fcmVhZChlbnVtIHg4Nl9zZWdtZW50IHNlZywKPiAgICAgIGlmICggcmMgfHwg IWJ5dGVzICkKPiAgICAgICAgICByZXR1cm4gcmM7Cj4gCj4gLSAgICBpZiAoIGFjY2Vzc190eXBl ID09IGh2bV9hY2Nlc3NfaW5zbl9mZXRjaCApCj4gLSAgICAgICAgcmMgPSBodm1fZmV0Y2hfZnJv bV9ndWVzdF9saW5lYXIocF9kYXRhLCBhZGRyLCBieXRlcywgMCwgJnBmaW5mbyk7Cj4gLSAgICBl bHNlCj4gLSAgICAgICAgcmMgPSBodm1fY29weV9mcm9tX2d1ZXN0X2xpbmVhcihwX2RhdGEsIGFk ZHIsIGJ5dGVzLCAwLCAmcGZpbmZvKTsKPiArICAgIHJjID0gaHZtX2NvcHlfZnJvbV9ndWVzdF9s aW5lYXIocF9kYXRhLCBhZGRyLCBieXRlcywKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgKGFjY2Vzc190eXBlID09IGh2bV9hY2Nlc3NfaW5zbl9mZXRjaAo+ICsgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgPyBQRkVDX2luc25fZmV0Y2ggOiAwKSwKPiAr ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJnBmaW5mbyk7Cj4gCj4gICAgICBz d2l0Y2ggKCByYyApCj4gICAgICB7Cj4gLS0tIGEveGVuL2luY2x1ZGUvYXNtLXg4Ni9odm0vc3Vw cG9ydC5oCj4gKysrIGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9odm0vc3VwcG9ydC5oCj4gQEAgLTEw MCw5ICsxMDAsNiBAQCBlbnVtIGh2bV90cmFuc2xhdGlvbl9yZXN1bHQgaHZtX2NvcHlfdG9fCj4g IGVudW0gaHZtX3RyYW5zbGF0aW9uX3Jlc3VsdCBodm1fY29weV9mcm9tX2d1ZXN0X2xpbmVhcigK PiAgICAgIHZvaWQgKmJ1ZiwgdW5zaWduZWQgbG9uZyBhZGRyLCBpbnQgc2l6ZSwgdWludDMyX3Qg cGZlYywKPiAgICAgIHBhZ2VmYXVsdF9pbmZvX3QgKnBmaW5mbyk7Cj4gLWVudW0gaHZtX3RyYW5z bGF0aW9uX3Jlc3VsdCBodm1fZmV0Y2hfZnJvbV9ndWVzdF9saW5lYXIoCj4gLSAgICB2b2lkICpi dWYsIHVuc2lnbmVkIGxvbmcgYWRkciwgaW50IHNpemUsIHVpbnQzMl90IHBmZWMsCj4gLSAgICBw YWdlZmF1bHRfaW5mb190ICpwZmluZm8pOwo+IAo+ICAvKgo+ICAgKiBHZXQgYSByZWZlcmVuY2Ug b24gdGhlIHBhZ2UgdW5kZXIgYW4gSFZNIHBoeXNpY2FsIG9yIGxpbmVhciBhZGRyZXNzLiAgSWYK PiAKPiAKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpY ZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRw czovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs