From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH 2/7] iommu: make use of type-safe BFN and MFN in exported functions Date: Tue, 10 Jul 2018 15:37:57 +0100 Message-ID: <8b87ff6f-0ba4-67d0-1405-afc6d43d8fa6@citrix.com> References: <20180212104714.1922-1-paul.durrant@citrix.com> <20180212104714.1922-3-paul.durrant@citrix.com> <5AAAA30A02000078001B2447@prv-mh.provo.novell.com> <5B44C3EE02000078001D2C11@prv1-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1fctnv-0005QQ-Od for xen-devel@lists.xenproject.org; Tue, 10 Jul 2018 14:39:47 +0000 In-Reply-To: <5B44C3EE02000078001D2C11@prv1-mh.provo.novell.com> Content-Language: en-GB List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Jan Beulich , George Dunlap Cc: Kevin Tian , Stefano Stabellini , Wei Liu , Tim Deegan , Ian Jackson , Julien Grall , Paul Durrant , Jun Nakajima , xen-devel List-Id: xen-devel@lists.xenproject.org T24gMTAvMDcvMTggMTU6MzQsIEphbiBCZXVsaWNoIHdyb3RlOgo+Pj4+IE9uIDEwLjA3LjE4IGF0 IDE2OjI5LCA8R2VvcmdlLkR1bmxhcEBldS5jaXRyaXguY29tPiB3cm90ZToKPj4gT24gVGh1LCBN YXIgMTUsIDIwMTggYXQgMzo0NCBQTSwgSmFuIEJldWxpY2ggPEpCZXVsaWNoQHN1c2UuY29tPiB3 cm90ZToKPj4+PiAtLS0gYS94ZW4vYXJjaC94ODYvbW0uYwo+Pj4+ICsrKyBiL3hlbi9hcmNoL3g4 Ni9tbS5jCj4+Pj4gQEAgLTI2NzYsMTMgKzI2NzYsMTIgQEAgc3RhdGljIGludCBfZ2V0X3BhZ2Vf dHlwZShzdHJ1Y3QgcGFnZV9pbmZvICpwYWdlLCAKPj4gdW5zaWduZWQgbG9uZyB0eXBlLAo+Pj4+ ICAgICAgICAgIHN0cnVjdCBkb21haW4gKmQgPSBwYWdlX2dldF9vd25lcihwYWdlKTsKPj4+PiAg ICAgICAgICBpZiAoIGQgJiYgaXNfcHZfZG9tYWluKGQpICYmIHVubGlrZWx5KG5lZWRfaW9tbXUo ZCkpICkKPj4+PiAgICAgICAgICB7Cj4+Pj4gLSAgICAgICAgICAgIGdmbl90IGdmbiA9IF9nZm4o bWZuX3RvX2dtZm4oZCwgbWZuX3gocGFnZV90b19tZm4ocGFnZSkpKSk7Cj4+Pj4gKyAgICAgICAg ICAgIGJmbl90IGJmbiA9IF9iZm4obWZuX3RvX2dtZm4oZCwgbWZuX3gocGFnZV90b19tZm4ocGFn ZSkpKSk7Cj4+Pj4KPj4+PiAgICAgICAgICAgICAgaWYgKCAoeCAmIFBHVF90eXBlX21hc2spID09 IFBHVF93cml0YWJsZV9wYWdlICkKPj4+PiAtICAgICAgICAgICAgICAgIGlvbW11X3JldCA9IGlv bW11X3VubWFwX3BhZ2UoZCwgZ2ZuX3goZ2ZuKSk7Cj4+Pj4gKyAgICAgICAgICAgICAgICBpb21t dV9yZXQgPSBpb21tdV91bm1hcF9wYWdlKGQsIGJmbik7Cj4+Pj4gICAgICAgICAgICAgIGVsc2Ug aWYgKCB0eXBlID09IFBHVF93cml0YWJsZV9wYWdlICkKPj4+PiAtICAgICAgICAgICAgICAgIGlv bW11X3JldCA9IGlvbW11X21hcF9wYWdlKGQsIGdmbl94KGdmbiksCj4+Pj4gLSAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBtZm5feChwYWdlX3RvX21mbihwYWdlKSks Cj4+Pj4gKyAgICAgICAgICAgICAgICBpb21tdV9yZXQgPSBpb21tdV9tYXBfcGFnZShkLCBiZm4s IHBhZ2VfdG9fbWZuKHBhZ2UpLAo+Pj4gQWxvbmcgdGhlIGxpbmVzIG9mIHdoYXQgSSd2ZSBzYWlk IGVhcmxpZXIgYWJvdXQgbWl4aW5nIGFkZHJlc3Mgc3BhY2VzLAo+Pj4gdGhpcyB3b3VsZCBwZXJo YXBzIG5vdCBzbyBtdWNoIG5lZWQgYSBjb21tZW50IChpdCdzIGEgMToxIG1hcHBpbmcKPj4+IGFm dGVyIGFsbCksIGJ1dCByYXRoZXIgbWFraW5nIG1vcmUgb2J2aW91cyB0aGF0IGl0J3MgYSAxOjEg bWFwcGluZy4KPj4+IFRoaXMgaW4gcGFydGljdWxhciB3b3VsZCBtZWFuIHRvIG1lIHRvIGxhdGNo IHBhZ2VfdG9fbWZuKHBhZ2UpIGludG8KPj4+IGEgKG5ldXRyYWxseSBuYW1lZCwgZS5nLiAiZnJh bWUiKSBsb2NhbCB2YXJpYWJsZSwgYW5kIHVzZSB0aGUgcmVzdWx0IGluCj4+PiBhIHdheSB0aGF0 IG1ha2VzIG9idmlvdXNseSBlc3BlY2lhbGx5IG9uIHRoZSAibWFwIiBwYXRoIHRoYXQgdGhpcwo+ Pj4gcmVhbGx5IHJlcXVlc3RzIGEgMToxIG1hcHBpbmcuIEJ5IGltcGxpY2F0aW9uIGZyb20gdGhl IDE6MSBtYXBwaW5nCj4+PiBpdCdsbCB0aGVuIChob3BlZnVsbHkpIGJlIGNsZWFyIHRvIHRoZSBy ZWFkZXIgdGhhdCB3aGljaCBleGFjdCBuYW1lCj4+PiBzcGFjZSBpcyB1c2VkIGRvZXNuJ3QgcmVh bGx5IG1hdHRlci4KPj4gSSdtIHNvcnJ5LCBJIGRvbid0IHRoaW5rIHRoaXMgaXMgYSBnb29kIGlk ZWEuCj4+Cj4+IEZpcnN0IG9mIGFsbCwgaXQgZG9lc24ndCBjb21tdW5pY2F0ZSB3aGF0IHlvdSB0 aGluayBpdCBkb2VzLiAgV2hhdAo+PiBoYXZpbmcgYW4gZXh0cmEgdmFyaWFibGUgY29tbXVuaWNh dGVzIGlzLCAiSSBhbSBjYWxjdWxhdGluZyBhbiBleHRyYQo+PiB2YWx1ZSB0aGF0IHdpbGwgYmUg dXNlZCBzb21ld2hlcmUiLiAgV2hlbiBJIHNhdyB0aGUgImludGVybWVkaWF0ZSIKPj4gdmFyaWFi bGVzIGFsbCBvdmVyIHRoZSBwbGFjZSwgSSBkaWRuJ3QgaW1tZWRpYXRlbHkgdGhpbmsgImFic3Ry YWN0Cj4+IHNwYWNlIGJlY2F1c2UgdGhlcmUncyBhIDEtMSBtYXBwaW5nIiwgSSB3YXMgc2ltcGx5 IGNvbmZ1c2VkLgo+Pgo+PiBPbiB0aGUgb3RoZXIgaGFuZCwgaXQgaXMgb2J2aW91cyB0byBtZSB0 aGF0IGlmIHlvdSAxKSBoYXZlIGRpZmZlcmVudAo+PiBraW5kcyBvZiB2YXJpYWJsZXMgKGdmbl90 LCBiZm5fdCwgJmMpIGFuZCAyKSB5b3UgY2FzdCBvbmUgZnJvbSB0aGUKPj4gb3RoZXIgZG9pbmcg c29tZSBtYXRoLCB0aGF0IHlvdSdyZSBjYXJlZnVsbHkgY2hhbmdpbmcgYWRkcmVzcyBzcGFjZXM7 Cj4+IGFuZCB0aGF0IGlmIHlvdSBkbyBfYmZuKGdmbiksIHRoYXQgeW91IGtub3cgeW91IGhhdmUg YSAxLTEgbWFwcGluZyAtLQo+PiBvciBhdCBsZWFzdCwgeW91IHZlcnkgbXVjaCBiZXR0ZXIgd2Vs bCBoYXZlIG9uZSwgb3IgeW91J3JlIGRvaW5nCj4+IHNvbWV0aGluZyB3cm9uZy4KPiBPa2F5IC0g ZGlmZmVyaW5nIG9waW5pb25zLCB3aGF0IGRvIHlvdSBkby4gVG8gbWUgYW4gZXhwcmVzc2lvbiBs aWtlCj4gX2JmbihnZm4pIGxvb2tzIGJ1Z2d5LiBBbmQgaWlyYyB3ZSd2ZSBoYWQgYnVncyBvZiB0 aGlzIGtpbmQgaW4gdGhlCj4gcGFzdCwgd2hpY2ggd291bGQgdGhlbiBjb250cmFkaWN0IHlvdXIg ImNhcmVmdWxseSBjaGFuZ2luZyBhZGRyZXNzCj4gc3BhY2VzIiBhc3N1bXB0aW9uLgo+Cj4gQXMg c2FpZCBpbiB0aGUgb3RoZXIgcmVwbHksIHNvbWV0aGluZyBsaWtlCj4gCWlvbW11X21hcF9wYWdl KC4uLiwgX2JmbihmcmFtZSksIGZyYW1lLCAuLi4pCj4gbWFrZXMgcHJldHR5IGNsZWFyIHRoYXQg YSAxOjEgbWFwcGluZyBpcyB3YW50ZWQuCgpUQkgsIEkgdGhpbmsgX2JmbihnZm4pIGlzIGJldHRl ciwgYnV0IGFueSBzdWNoIG1peGluZyBvZiBhZGRyZXNzIHNwYWNlcwpuZWVkcyBhIGNvbW1lbnQg ZXhwbGFpbmluZyB0aGUgY29ycmVjdG5lc3MsIGV2ZW4gaWYgaXQgaXMgYSBzaG9ydCAvKiAxOjEK bWFwcGluZyBoZXJlICovCgpJbmRpcmVjdGluZyB0aHJvdWdoIGFuIHVuc2lnbmVkIGxvbmcgKHBh cnRpY3VsYXJseSBvbmUgd2l0aCBhIGdlbmVyaWMKbmFtZSkgaXMgYSBtaXN1c2Ugb2YgdGhlIHR5 cGVzYWZlIGludGVyZmFjZSwgYmVjYXVzZSBhbGwgaXQgZG9lcyBpcwpzZXJ2ZSB0byBjb25mdXNl IHRoZSByZWFkZXIuCgp+QW5kcmV3CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5w cm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8v eGVuLWRldmVs