From: Lan Tianyu <tianyu.lan@intel.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: sstabellini@kernel.org, wei.liu2@citrix.com,
George.Dunlap@eu.citrix.com, andrew.cooper3@citrix.com,
ian.jackson@eu.citrix.com, Jan Beulich <JBeulich@suse.com>,
xen-devel@lists.xenproject.org
Subject: Re: [Resend PATCH 1/2] Xen/Keyhandler: Make keyhandler always run in tasklet
Date: Tue, 11 Oct 2016 09:42:45 +0800 [thread overview]
Message-ID: <8cb145d8-b653-d838-2a66-9f90a0cf3e79@intel.com> (raw)
In-Reply-To: <20161010135555.GE869@char.us.oracle.com>
On 2016年10月10日 21:55, Konrad Rzeszutek Wilk wrote:
> On Sat, Oct 08, 2016 at 11:26:44AM +0800, Lan Tianyu wrote:
>> On 2016年10月06日 20:52, Jan Beulich wrote:
>>>>>> On 30.09.16 at 04:19, <tianyu.lan@intel.com> wrote:
>>>> @@ -87,10 +89,10 @@ void handle_keypress(unsigned char key, struct cpu_user_regs *regs)
>>>> if ( key >= ARRAY_SIZE(key_table) || !(h = &key_table[key])->fn )
>>>> return;
>>>>
>>>> - if ( !in_irq() || h->irq_callback )
>>>> + if ( h->irq_callback )
>>>
>>> Please make subject/description reflect this: You don't _always_
>>> force the use of the tasklet.
>>
>> Ok. I also find register_irq_keyhandler() isn't called anywhere in
>> current code and that means none uses irq_callback. Can we remove it?
>
> But it is. See IRQ_KEYHANDLER
Oh. Yes. Thanks for your information.
--
Best regards
Tianyu Lan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-10-11 1:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-30 2:19 [Resend PATCH 0/2] Xen: Fix Xen hypervisor panic during dumping timer info on huge machine Lan Tianyu
2016-09-30 2:19 ` [Resend PATCH 1/2] Xen/Keyhandler: Make keyhandler always run in tasklet Lan Tianyu
2016-09-30 18:07 ` Konrad Rzeszutek Wilk
2016-10-08 3:17 ` Lan Tianyu
2016-10-06 12:52 ` Jan Beulich
2016-10-08 3:26 ` Lan Tianyu
2016-10-10 6:48 ` Jan Beulich
2016-10-10 13:55 ` Konrad Rzeszutek Wilk
2016-10-11 1:42 ` Lan Tianyu [this message]
2016-09-30 2:19 ` [Resend PATCH 2/2] Xen/timer: Process softirq during dumping timer info Lan Tianyu
2016-09-30 18:11 ` Konrad Rzeszutek Wilk
2016-10-06 12:56 ` Jan Beulich
2016-10-08 5:28 ` Lan Tianyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8cb145d8-b653-d838-2a66-9f90a0cf3e79@intel.com \
--to=tianyu.lan@intel.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=sstabellini@kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).