From: Mukesh Ojha <mojha@codeaurora.org>
To: Hariprasad Kelam <hariprasad.kelam@gmail.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Subject: Re: [Xen-devel] [PATCH] xen: xen-pciback: fix warning Using plain integer as NULL pointer
Date: Sun, 7 Apr 2019 00:33:29 +0530 [thread overview]
Message-ID: <8d19e62d-11cd-91dc-6c54-d688d2d67d00@codeaurora.org> (raw)
In-Reply-To: <20190406122912.GA403@hari-Inspiron-1545>
On 4/6/2019 5:59 PM, Hariprasad Kelam wrote:
> Changes passing function argument 0 to NULL to avoid below sparse
> warning
>
> CHECK drivers/xen/xen-pciback/xenbus.c
> drivers/xen/xen-pciback/xenbus.c:700:51: warning: Using plain integer as
> NULL pointer
>
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Cheers,
-Mukesh
> ---
> drivers/xen/xen-pciback/xenbus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/xen/xen-pciback/xenbus.c b/drivers/xen/xen-pciback/xenbus.c
> index 23f7f6e..833b2d2 100644
> --- a/drivers/xen/xen-pciback/xenbus.c
> +++ b/drivers/xen/xen-pciback/xenbus.c
> @@ -697,7 +697,7 @@ static int xen_pcibk_xenbus_probe(struct xenbus_device *dev,
> /* We need to force a call to our callback here in case
> * xend already configured us!
> */
> - xen_pcibk_be_watch(&pdev->be_watch, NULL, 0);
> + xen_pcibk_be_watch(&pdev->be_watch, NULL, NULL);
>
> out:
> return err;
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-04-07 5:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-06 12:29 [Xen-devel] [PATCH] xen: xen-pciback: fix warning Using plain integer as NULL pointer Hariprasad Kelam
2019-04-06 19:03 ` Mukesh Ojha
2019-04-06 19:03 ` Mukesh Ojha [this message]
2019-04-08 5:10 ` Juergen Gross
2019-04-08 5:10 ` [Xen-devel] " Juergen Gross
2019-04-24 18:48 ` Boris Ostrovsky
2019-04-24 18:48 ` [Xen-devel] " Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d19e62d-11cd-91dc-6c54-d688d2d67d00@codeaurora.org \
--to=mojha@codeaurora.org \
--cc=boris.ostrovsky@oracle.com \
--cc=gustavo@embeddedor.com \
--cc=hariprasad.kelam@gmail.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).