From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 2/5] x86emul: consolidate segment register handling
Date: Fri, 30 Sep 2016 11:39:06 +0100 [thread overview]
Message-ID: <8ddde315-23e0-0676-db7b-c33df9df0f3f@citrix.com> (raw)
In-Reply-To: <57D18725020000780010D268@prv-mh.provo.novell.com>
On 08/09/16 14:43, Jan Beulich wrote:
> @@ -2861,21 +2860,20 @@ x86_emulate(
> dst.val = src.val;
> break;
>
> - case 0x8c: /* mov Sreg,r/m */ {
> - struct segment_register reg;
> - enum x86_segment seg = decode_segment(modrm_reg);
> + case 0x8c: /* mov Sreg,r/m */
> + seg = decode_segment(modrm_reg);
> generate_exception_if(seg == decode_segment_failed, EXC_UD, -1);
> + store_seg:
store_seg is easy to confuse with load_seg. How about read_selector
instead?
It also occurs to me that you might have an easier time with both this
patch and patch 1 if you reversed their order. Either way, Reviewed-by:
Andrew Cooper <andrew.cooper3@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-09-30 10:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 13:36 [PATCH 0/5] x86: further insn emulator improvements Jan Beulich
2016-09-08 13:42 ` [PATCH 1/5] x86emul: support UMIP Jan Beulich
2016-09-30 10:32 ` Andrew Cooper
2016-09-30 12:23 ` Jan Beulich
2016-09-30 12:27 ` Andrew Cooper
2016-09-30 12:44 ` Jan Beulich
2016-09-08 13:43 ` [PATCH 2/5] x86emul: consolidate segment register handling Jan Beulich
2016-09-30 10:39 ` Andrew Cooper [this message]
2016-09-30 12:15 ` Jan Beulich
2016-09-30 12:16 ` Andrew Cooper
2016-09-08 13:44 ` [PATCH 3/5] x86emul: support RTM instructions Jan Beulich
2016-09-30 12:37 ` Andrew Cooper
2016-09-30 12:51 ` Jan Beulich
2016-09-08 13:45 ` [PATCH 4/5] x86/emulate: add support for {, v}movq xmm, xmm/m64 Jan Beulich
2016-09-08 13:56 ` Mihai Donțu
2016-09-30 10:43 ` Andrew Cooper
2016-09-08 13:46 ` [PATCH 5/5] x86/emulate: add support for {, v}movd {, x}mm, r/m32 and {, v}movq {, x}mm, r/m64 Jan Beulich
2016-09-30 11:59 ` Andrew Cooper
2016-09-30 12:11 ` Jan Beulich
2016-09-30 12:12 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ddde315-23e0-0676-db7b-c33df9df0f3f@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).