From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: tim@xen.org, sstabellini@kernel.org, wei.liu2@citrix.com,
George.Dunlap@eu.citrix.com, andrew.cooper3@citrix.com,
ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH v4 6/8] mm: Keep heap accessible to others while scrubbing
Date: Mon, 12 Jun 2017 13:11:47 -0400 [thread overview]
Message-ID: <8e2a2b6e-4a2e-e912-2cc4-b47a0e9f7f89@oracle.com> (raw)
In-Reply-To: <593E6D300200007800161D0D@prv-mh.provo.novell.com>
>> @@ -1175,6 +1258,8 @@ static void free_heap_pages(
>> if ( page_state_is(&pg[i], offlined) )
>> tainted = 1;
>>
>> + pg[i].u.free.scrub_state = 0;
> Is this really needed for every page in the buddy?
>
The concern here is that is we break the buddy (in alloc_heap_pages(),
for example) this may still be set. But perhaps I just should be careful
about clearing this on the head when a (sub-)buddy is added to the heap.
-boris
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-06-12 17:11 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 15:50 [PATCH v4 0/8] Memory scrubbing from idle loop Boris Ostrovsky
2017-05-19 15:50 ` [PATCH v4 1/8] mm: Place unscrubbed pages at the end of pagelist Boris Ostrovsky
2017-06-09 14:50 ` Jan Beulich
2017-06-09 20:07 ` Boris Ostrovsky
2017-06-12 6:50 ` Jan Beulich
2017-05-19 15:50 ` [PATCH v4 2/8] mm: Extract allocation loop from alloc_heap_pages() Boris Ostrovsky
2017-06-09 15:08 ` Jan Beulich
2017-05-19 15:50 ` [PATCH v4 3/8] mm: Scrub pages in alloc_heap_pages() if needed Boris Ostrovsky
2017-06-09 15:22 ` Jan Beulich
2017-06-09 20:55 ` Boris Ostrovsky
2017-06-12 6:54 ` Jan Beulich
2017-05-19 15:50 ` [PATCH v4 4/8] mm: Scrub memory from idle loop Boris Ostrovsky
2017-06-12 8:08 ` Jan Beulich
2017-06-12 17:01 ` Boris Ostrovsky
2017-06-12 21:28 ` Dario Faggioli
2017-06-13 8:19 ` Jan Beulich
2017-06-13 18:39 ` Boris Ostrovsky
2017-06-13 20:36 ` Dario Faggioli
2017-06-13 21:54 ` Boris Ostrovsky
2017-06-14 9:18 ` Jan Beulich
2017-06-13 8:12 ` Jan Beulich
2017-06-13 18:20 ` Boris Ostrovsky
2017-06-14 9:17 ` Jan Beulich
2017-05-19 15:50 ` [PATCH v4 5/8] spinlock: Introduce spin_lock_cb() Boris Ostrovsky
2017-06-12 8:23 ` Jan Beulich
2017-05-19 15:50 ` [PATCH v4 6/8] mm: Keep heap accessible to others while scrubbing Boris Ostrovsky
2017-06-12 8:30 ` Jan Beulich
2017-06-12 17:11 ` Boris Ostrovsky [this message]
2017-05-19 15:50 ` [PATCH v4 7/8] mm: Print number of unscrubbed pages in 'H' debug handler Boris Ostrovsky
2017-05-19 15:50 ` [PATCH v4 8/8] mm: Make sure pages are scrubbed Boris Ostrovsky
2017-06-12 8:43 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e2a2b6e-4a2e-e912-2cc4-b47a0e9f7f89@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).