From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH 3/4] xen/x86: Replace incorrect mandatory barriers with SMP barriers Date: Mon, 5 Dec 2016 13:29:55 +0000 Message-ID: <8f23ddf1-662d-8ac1-1970-2900dba377e1@citrix.com> References: <1480932317-22962-1-git-send-email-andrew.cooper3@citrix.com> <1480932317-22962-4-git-send-email-andrew.cooper3@citrix.com> <584561D30200007800124FEE@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <584561D30200007800124FEE@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich Cc: Xen-devel List-Id: xen-devel@lists.xenproject.org T24gMDUvMTIvMTYgMTE6NDcsIEphbiBCZXVsaWNoIHdyb3RlOgo+Pj4+IE9uIDA1LjEyLjE2IGF0 IDExOjA1LCA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4gd3JvdGU6Cj4+IC0tLSBhL3hlbi9h cmNoL3g4Ni9hY3BpL2NwdV9pZGxlLmMKPj4gKysrIGIveGVuL2FyY2gveDg2L2FjcGkvY3B1X2lk bGUuYwo+PiBAQCAtMzkxLDkgKzM5MSw5IEBAIHZvaWQgbXdhaXRfaWRsZV93aXRoX2hpbnRzKHVu c2lnbmVkIGludCBlYXgsIHVuc2lnbmVkIGludCBlY3gpCj4+ICAKPj4gICAgICBpZiAoIGJvb3Rf Y3B1X2hhcyhYODZfRkVBVFVSRV9DTEZMVVNIX01PTklUT1IpICkKPj4gICAgICB7Cj4+IC0gICAg ICAgIG1iKCk7Cj4+ICsgICAgICAgIHNtcF9tYigpOwo+PiAgICAgICAgICBjbGZsdXNoKCh2b2lk ICopJm13YWl0X3dha2V1cChjcHUpKTsKPj4gLSAgICAgICAgbWIoKTsKPj4gKyAgICAgICAgc21w X21iKCk7Cj4+ICAgICAgfQo+IEJvdGggbmVlZCB0byBzdGF5IGFzIHRoZXkgYXJlIGFmYWljdDog SW4gb3JkZXIgZm9yIHRoZSBjbGZsdXNoKCkgdG8gZG8KPiB3aGF0IHdlIHdhbnQgd2UgaGF2ZSB0 byBvcmRlciBpdCB3cnQgZWFybGllciBhcyB3ZWxsIGFzIGxhdGVyIHdyaXRlcywKPiByZWdhcmRs ZXNzIG9mIFNNUC1uZXNzLiBPciB3YWl0IC0gdGhlIFNETSBoYXMgY2hhbmdlZCBpbiB0aGF0Cj4g cmVzcGVjdCAoYW5kIGEgZm9vdG5vdGUgZGVzY3JpYmVzIHRoZSBlYXJsaWVyIHNwZWNpZmllZCBi ZWhhdmlvciBub3cpLgo+IEFNRCwgb3RvaCwgY29udGludWVzIHRvIHJlcXVpcmUgTUZFTkNFIGZv ciBvcmRlcmluZyBwdXJwb3Nlcy4KCm1iKCkgPT0gc21wX21iKCkuICBUaGV5IGFyZSBib3RoIG1m ZW5jZSBpbnN0cnVjdGlvbnMuCgpIb3dldmVyLCBpZiBBTUQgc3BlY2lmaWNhbGx5IHJlcXVpcmVz IG1mZW5jZSwgd2Ugc2hvdWxkIGV4cGxpY2l0bHkgdXNlCnRoYXQgcmF0aGVyIHRoYW4gcmVseWlu ZyBvbiB0aGUgaW1wbGVtZW50YXRpb24gZGV0YWlscyBvZiBzbXBfbWIoKS4KCj4KPj4gLS0tIGEv eGVuL2FyY2gveDg2L2NwdS9tY2hlY2svYW1kX25vbmZhdGFsLmMKPj4gKysrIGIveGVuL2FyY2gv eDg2L2NwdS9tY2hlY2svYW1kX25vbmZhdGFsLmMKPj4gQEAgLTE3NSw3ICsxNzUsNyBAQCBzdGF0 aWMgdm9pZCBtY2VfYW1kX3dvcmtfZm4odm9pZCAqZGF0YSkKPj4gIAkJCS8qIENvdW50ZXIgZW5h YmxlICovCj4+ICAJCQl2YWx1ZSB8PSAoMVVMTCA8PCA1MSk7Cj4+ICAJCQltY2Ffd3Jtc3IoTVNS X0lBMzJfTUN4X01JU0MoNCksIHZhbHVlKTsKPj4gLQkJCXdtYigpOwo+PiArCQkJc21wX3dtYigp Owo+PiAgCQl9Cj4+ICAJfQo+PiAgCj4+IEBAIC0yNDAsNyArMjQwLDcgQEAgdm9pZCBhbWRfbm9u ZmF0YWxfbWNoZWNrX2luaXQoc3RydWN0IGNwdWluZm9feDg2ICpjKQo+PiAgCQkJdmFsdWUgfD0g KDFVTEwgPDwgNTEpOwo+PiAgCQkJd3Jtc3JsKE1TUl9JQTMyX01DeF9NSVNDKDQpLCB2YWx1ZSk7 Cj4+ICAJCQkvKiBzZXJpYWxpemUgKi8KPj4gLQkJCXdtYigpOwo+PiArCQkJc21wX3dtYigpOwo+ PiAgCQkJcHJpbnRrKFhFTkxPR19JTkZPICJNQ0E6IFVzZSBodyB0aHJlc2hvbGRpbmcgdG8gYWRq dXN0IHBvbGxpbmcgZnJlcXVlbmN5XG4iKTsKPj4gIAkJfQo+PiAgCX0KPiBUaGVzZSB3aWxsIG5l ZWQgY29uZmlybWluZyBieSBBTUQgZW5naW5lZXJzLgoKSSB3YXMgdW5jZXJ0YWluIHdoZXRoZXIg dGhlc2Ugd2VyZSBuZWNlc3NhcnkgYXQgYWxsLCBidXQgYXMgaWRlbnRpZmllZAppbiB0aGUgY29t bWl0IG1lc3NhZ2UsIHRoaXMgaXMgbm8gZnVuY3Rpb25hbCBjaGFuZ2UgYXMgWGVuIGN1cnJlbnRs eSBoYXMKcm1iL3dtYiBhcyBwbGFpbiBiYXJyaWVycywgbm90IGZlbmNlIGluc3RydWN0aW9ucy4K Cj4KPj4gLS0tIGEveGVuL2FyY2gveDg2L2NwdS9tY2hlY2svYmFycmllci5jCj4+ICsrKyBiL3hl bi9hcmNoL3g4Ni9jcHUvbWNoZWNrL2JhcnJpZXIuYwo+PiBAQCAtMTIsNyArMTIsNyBAQCB2b2lk IG1jZV9iYXJyaWVyX2luaXQoc3RydWN0IG1jZV9zb2Z0aXJxX2JhcnJpZXIgKmJhcikKPj4gIHZv aWQgbWNlX2JhcnJpZXJfZGVjKHN0cnVjdCBtY2Vfc29mdGlycV9iYXJyaWVyICpiYXIpCj4+ICB7 Cj4+ICAgICAgYXRvbWljX2luYygmYmFyLT5vdXRnZW4pOwo+PiAtICAgIHdtYigpOwo+PiArICAg IHNtcF93bWIoKTsKPj4gICAgICBhdG9taWNfZGVjKCZiYXItPnZhbCk7Cj4+ICB9Cj4gVGhpcyBi ZWluZyB4ODYtc3BlY2lmaWMgY29kZSAtIGRvIHdlIG5lZWQgYSBiYXJyaWVyIGhlcmUgYXQgYWxs LAo+IGJldHdlZW4gdHdvIExPQ0tlZCBpbnN0cnVjdGlvbnM/IChTYW1lIGZvciB0d28gbW9yZSBj YXNlcyBmdXJ0aGVyCj4gZG93bi4pCgpIbW0sIEkgdGhpbmsgbm90LiAgVGhlIEMgc2VtYW50aWNz IGd1YXJhbnRlZXMgb3JkZXJpbmcgb2YgdGhlCmF0b21pY19pbmMoKSBhbmQgYXRvbWljX2RlYygp LCBhbmQgdGhleSBhcmUgYm90aCB3cml0ZXMgdG8gd2lsbCBiZQpzdHJpY3RseSBvcmRlcmVkLgoK Pgo+PiBAQCAtNDMzLDcgKzQzMyw3IEBAIG1jdGVsZW1fY29va2llX3QgbWN0ZWxlbV9jb25zdW1l X29sZGVzdF9iZWdpbihtY3RlbGVtX2NsYXNzX3Qgd2hpY2gpCj4+ICAJfQo+PiAgCj4+ICAJbWN0 ZWxlbV9wcm9jZXNzaW5nX2hvbGQodGVwKTsKPj4gLQl3bWIoKTsKPj4gKwlzbXBfd21iKCk7Cj4+ ICAJc3Bpbl91bmxvY2soJnByb2Nlc3NpbmdfbG9jayk7Cj4gRG9uJ3Qgd2UgaW1wbHkgdW5sb2Nr cyB0byBiZSB3cml0ZSBiYXJyaWVycz8KClRoZXkgYXJlLCBhcyBhbiB1bmxvY2sgaXMgbmVjZXNz YXJpbHkgYSB3cml0ZSwgY29tYmluZWQgd2l0aCB4ODYncwpvcmRlcmluZyBndWFyYW50ZWVzLgoK VGhlbiBhZ2FpbiwgSSBhbSBub3Qgc3VyZSBob3cgdGhpcyB3b3VsZCBpbnRlcmFjdCB3aXRoIFRT WCwgc28gYW0gbm90CnN1cmUgaWYgd2Ugc2hvdWxkIGFzc3VtZSBvciByZWx5IG9uIHN1Y2ggYmVo YXZpb3VyLgoKPgo+PiAtLS0gYS94ZW4vYXJjaC94ODYvaW9fYXBpYy5jCj4+ICsrKyBiL3hlbi9h cmNoL3g4Ni9pb19hcGljLmMKPj4gQEAgLTE0ODYsNyArMTQ4Niw3IEBAIHN0YXRpYyBpbnQgX19p bml0IHRpbWVyX2lycV93b3Jrcyh2b2lkKQo+PiAgICAgIHVuc2lnbmVkIGxvbmcgdDEsIGZsYWdz Owo+PiAgCj4+ICAgICAgdDEgPSBwaXQwX3RpY2tzOwo+PiAtICAgIG1iKCk7Cj4+ICsgICAgc21w X21iKCk7Cj4+ICAKPj4gICAgICBsb2NhbF9zYXZlX2ZsYWdzKGZsYWdzKTsKPj4gICAgICBsb2Nh bF9pcnFfZW5hYmxlKCk7Cj4+IEBAIC0xNTAxLDcgKzE1MDEsNyBAQCBzdGF0aWMgaW50IF9faW5p dCB0aW1lcl9pcnFfd29ya3Modm9pZCkKPj4gICAgICAgKiBtaWdodCBoYXZlIGNhY2hlZCBvbmUg RXh0SU5UIGludGVycnVwdC4gIEZpbmFsbHksIGF0Cj4+ICAgICAgICogbGVhc3Qgb25lIHRpY2sg bWF5IGJlIGxvc3QgZHVlIHRvIGRlbGF5cy4KPj4gICAgICAgKi8KPj4gLSAgICBtYigpOwo+PiAr ICAgIHNtcF9tYigpOwo+PiAgICAgIGlmIChwaXQwX3RpY2tzIC0gdDEgPiA0KQo+PiAgICAgICAg ICByZXR1cm4gMTsKPiBJIHRoaW5rIHRoZXNlIHR3byBjYW4gYmUgYmFycmllcigpLgoKVGhlc2Ug d2VyZSBvcmlnaW5hbGx5IGluIHRoZSBwcmV2aW91cyBwYXRjaCwgYnV0IEkgd2Fzbid0IHNvIGNl cnRhaW4gYW5kCm1vdmVkIHRoZW0gYmFjayBoZXJlLgoKVGhpbmtpbmcgYWJvdXQgaXQgZnVydGhl ciwgcGl0MF90aWNrcyBpcyBvbmx5IGV2ZXIgdXBkYXRlZCBieSB0aGUKY3VycmVudCBjcHUsIHNv IHNvLWxvbmcgYXMgdGhlIGNvbXBpbGVyIGRvZXNuJ3QgZWxpZGUgdGhlIHJlYWQsIGl0CnNob3Vs ZCBiZSBmaW5lLgoKPgo+PiBAQCAtMTI0LDcgKzEyNCw3IEBAIHN0YXRpYyB2b2lkIHN5bmNocm9u aXplX3RzY19tYXN0ZXIodW5zaWduZWQgaW50IHNsYXZlKQo+PiAgICAgIGZvciAoIGkgPSAxOyBp IDw9IDU7IGkrKyApCj4+ICAgICAgewo+PiAgICAgICAgICB0c2NfdmFsdWUgPSByZHRzY19vcmRl cmVkKCk7Cj4+IC0gICAgICAgIHdtYigpOwo+PiArICAgICAgICBzbXBfd21iKCk7Cj4+ICAgICAg ICAgIGF0b21pY19pbmMoJnRzY19jb3VudCk7Cj4gU2FtZSBxdWVzdGlvbiBhcyBhYm92ZSB3cnQg dGhlIGZvbGxvd2luZyBMT0NLZWQgaW5zdHJ1Y3Rpb24uCgpJJ20gbm90IHN1cmUgdGhlIGxvY2tl ZCBpbnN0cnVjdGlvbiBpcyByZWxldmFudCBoZXJlLiAgQydzCm9yZGVyaW5nLW1vZGVsIGlzIHN1 ZmZpY2llbnQgdG8gbWFrZSB0aGlzIGNvcnJlY3QuCgo+Cj4+IC0tLSBhL3hlbi9kcml2ZXJzL3Bh c3N0aHJvdWdoL2FtZC9pb21tdV9pbml0LmMKPj4gKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91 Z2gvYW1kL2lvbW11X2luaXQuYwo+PiBAQCAtNTU5LDcgKzU1OSw3IEBAIHN0YXRpYyB2b2lkIHBh cnNlX2V2ZW50X2xvZ19lbnRyeShzdHJ1Y3QgYW1kX2lvbW11ICppb21tdSwgdTMyIGVudHJ5W10p Cj4+ICAgICAgICAgICAgICByZXR1cm47Cj4+ICAgICAgICAgIH0KPj4gICAgICAgICAgdWRlbGF5 KDEpOwo+PiAtICAgICAgICBybWIoKTsKPj4gKyAgICAgICAgc21wX3JtYigpOwo+PiAgICAgICAg ICBjb2RlID0gZ2V0X2ZpZWxkX2Zyb21fcmVnX3UzMihlbnRyeVsxXSwgSU9NTVVfRVZFTlRfQ09E RV9NQVNLLAo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBJT01NVV9F VkVOVF9DT0RFX1NISUZUKTsKPj4gICAgICB9Cj4+IEBAIC02NjQsNyArNjY0LDcgQEAgdm9pZCBw YXJzZV9wcHJfbG9nX2VudHJ5KHN0cnVjdCBhbWRfaW9tbXUgKmlvbW11LCB1MzIgZW50cnlbXSkK Pj4gICAgICAgICAgICAgIHJldHVybjsKPj4gICAgICAgICAgfQo+PiAgICAgICAgICB1ZGVsYXko MSk7Cj4+IC0gICAgICAgIHJtYigpOwo+PiArICAgICAgICBzbXBfcm1iKCk7Cj4+ICAgICAgICAg IGNvZGUgPSBnZXRfZmllbGRfZnJvbV9yZWdfdTMyKGVudHJ5WzFdLCBJT01NVV9QUFJfTE9HX0NP REVfTUFTSywKPj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgSU9NTVVf UFBSX0xPR19DT0RFX1NISUZUKTsKPj4gICAgICB9Cj4gRG9uJ3QgdGhlc2UgZmFsbCBpbnRvIHRo ZSAicmVkdWNlZC1jYWNoZWFiaWxpdHkgbWVtb3J5IG1hcHBpbmdzIgo+IGNhdGVnb3J5PyBPciBp ZiB0aGUgbWFwcGluZ3MgdGhlc2UgcmVhZHMgZ28gdGhyb3VnaCBhcmUgVUMsCj4gYXJlbid0IHRo ZXkgdW5uZWVkZWQgYWx0b2dldGhlcj8gSW4gYW55IGV2ZW50IHRoaXMgd291bGQgYmV0dGVyIGJl Cj4gYSBzZXBhcmF0ZSBwYXRjaCBDYy1lZCB0byB0aGUgQU1EIElPTU1VIG1haW50YWluZXJzLgoK SSBjYW4ndCBmaW5kIGFueSByZXF1aXJlbWVudHMgaW4gdGhlIEFNRCBJT01NVSBzcGVjIGFib3V0 IHRoZQpjYWNoZWFiaWxpdHkgb2YgbWFwcGluZ3MuCgpXZSB1c2UgVUMgbWFwcGluZ3MsIGFsdGhv dWdoIGZyYW5rbHkgZm9yIHRoZSBzdGFydGluZyBtZW1zZXQgYWxvbmUsIHdlCnNob3VsZCBwcm9i YWJseSBiZXR0ZXIgdXNpbmcgV0IgZm9sbG93ZWQgYnkgYW4gZXhwbGljaXQgY2FjaGUgZmx1c2gs CnRoZW4gc3dpdGNoaW5nIHRvIFVDLgoKV2l0aCBVQyBtYXBwaW5ncywgd2UgZG9uJ3QgbmVlZCBh bnkgYmFycmllcnMgYXQgYWxsLiAgSSB3aWxsIHN1Ym1pdCBhCnBhdGNoIHNlcGFyYXRlbHkgcmVt b3ZpbmcgdGhlbS4KCn5BbmRyZXcKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5v cmcKaHR0cHM6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=