From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Cc: Doug Goldstein <cardoe@cardoe.com>
Subject: Re: [PATCH 3/4] automation: also specify xen binary as artifact on x86_64
Date: Tue, 20 Nov 2018 17:35:54 +0000 [thread overview]
Message-ID: <8fcfa8d1-4f54-3a3c-d95a-1a56b64afa7c@citrix.com> (raw)
In-Reply-To: <20181119213102.8939-4-wei.liu2@citrix.com>
On 19/11/2018 21:31, Wei Liu wrote:
> diff --git a/automation/scripts/build b/automation/scripts/build
> index a1f9a5da56..d4aceb745f 100755
> --- a/automation/scripts/build
> +++ b/automation/scripts/build
> @@ -28,6 +28,10 @@ make -j$(nproc) dist
>
> # Extract artifacts to avoid getting rewritten by customised builds
> cp xen/.config xen-config
> +mkdir binaries
> +if [[ "x${XEN_TARGET_ARCH}" == "xx86_64" ]]; then
Either quote the strings, or use the pre-x trick, but you don't need to
do both together.
~Andrew
> + cp xen/xen binaries/xen
> +fi
>
> # Build all the configs we care about
> case ${XEN_TARGET_ARCH} in
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-11-20 17:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 21:30 [PATCH 0/4] automation: QEMU-based smoke test Wei Liu
2018-11-19 21:30 ` [PATCH 1/4] automation: introduce CONTAINER_NO_PULL for containerize Wei Liu
2018-11-20 16:35 ` Doug Goldstein
2018-11-19 21:31 ` [PATCH 2/4] automation: stash default config file for artifact extraction Wei Liu
2018-11-20 16:38 ` Doug Goldstein
2018-11-19 21:31 ` [PATCH 3/4] automation: also specify xen binary as artifact on x86_64 Wei Liu
2018-11-20 16:39 ` Doug Goldstein
2018-11-20 17:35 ` Andrew Cooper [this message]
2018-11-20 18:21 ` Wei Liu
2018-11-19 21:31 ` [PATCH 4/4] automation: add qemu smoke test Wei Liu
2018-11-20 16:41 ` Doug Goldstein
2018-11-20 16:47 ` Wei Liu
2018-11-19 21:40 ` [PATCH 0/4] automation: QEMU-based " Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8fcfa8d1-4f54-3a3c-d95a-1a56b64afa7c@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=cardoe@cardoe.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).