From: Julien Grall <julien.grall@arm.com>
To: George Dunlap <george.dunlap@citrix.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH] xen/grant_table: Remove stall comment on top of map_grant_ref
Date: Thu, 1 Nov 2018 12:49:46 +0000 [thread overview]
Message-ID: <9186589c-b61c-a6b9-690c-55ec103a081b@arm.com> (raw)
In-Reply-To: <37c4e0f2-9083-911f-7e08-7525c392d279@citrix.com>
Hi George,
On 01/11/2018 11:03, George Dunlap wrote:
> On 11/01/2018 10:16 AM, Julien Grall wrote:
>> Remove the 2 part comment on top of map_grant_ref:
>> - The first part mention the return value which has been void since
>> 2006!
>> - The second part mention a local variable 'addr' which does not
>> exist anymore.
>>
>> Signed-off-by: Julien Grall <julien.grall@arm.com>
>
> Nit: s/stall/stale/; in title
I will fix this on commit.
Cheers,
>
> -George
>
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
prev parent reply other threads:[~2018-11-01 12:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-01 10:16 [PATCH] xen/grant_table: Remove stall comment on top of map_grant_ref Julien Grall
2018-11-01 10:21 ` Andrew Cooper
2018-11-01 11:03 ` George Dunlap
2018-11-01 12:49 ` Julien Grall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9186589c-b61c-a6b9-690c-55ec103a081b@arm.com \
--to=julien.grall@arm.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).