* [PATCH] libxl: fix xcflags assignment in libxl__domain_suspend
@ 2013-01-31 15:11 Olaf Hering
2013-02-05 11:34 ` Ian Campbell
0 siblings, 1 reply; 2+ messages in thread
From: Olaf Hering @ 2013-01-31 15:11 UTC (permalink / raw)
To: xen-devel
# HG changeset patch
# User Olaf Hering <olaf@aepfle.de>
# Date 1359645080 -3600
# Node ID 91fe6b42c7d4010ada78617d18133137d7194d9b
# Parent 6727070b4129cf852199b66b6a81042ee6966a98
libxl: fix xcflags assignment in libxl__domain_suspend
Currently ->xcflags remains 1 because the braces are placed incorrectly.
Put each logical unit into its own braces to fix assigment to xcflags.
Signed-off-by: Olaf Hering <olaf@aepfle.de>
diff -r 6727070b4129 -r 91fe6b42c7d4 tools/libxl/libxl_dom.c
--- a/tools/libxl/libxl_dom.c
+++ b/tools/libxl/libxl_dom.c
@@ -1238,9 +1238,9 @@ void libxl__domain_suspend(libxl__egc *e
abort();
}
- dss->xcflags = (live) ? XCFLAGS_LIVE : 0
- | (debug) ? XCFLAGS_DEBUG : 0
- | (dss->hvm) ? XCFLAGS_HVM : 0;
+ dss->xcflags = (live ? XCFLAGS_LIVE : 0)
+ | (debug ? XCFLAGS_DEBUG : 0)
+ | (dss->hvm ? XCFLAGS_HVM : 0);
dss->suspend_eventchn = -1;
dss->guest_responded = 0;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] libxl: fix xcflags assignment in libxl__domain_suspend
2013-01-31 15:11 [PATCH] libxl: fix xcflags assignment in libxl__domain_suspend Olaf Hering
@ 2013-02-05 11:34 ` Ian Campbell
0 siblings, 0 replies; 2+ messages in thread
From: Ian Campbell @ 2013-02-05 11:34 UTC (permalink / raw)
To: Olaf Hering; +Cc: xen-devel@lists.xen.org
On Thu, 2013-01-31 at 15:11 +0000, Olaf Hering wrote:
> # HG changeset patch
> # User Olaf Hering <olaf@aepfle.de>
> # Date 1359645080 -3600
> # Node ID 91fe6b42c7d4010ada78617d18133137d7194d9b
> # Parent 6727070b4129cf852199b66b6a81042ee6966a98
> libxl: fix xcflags assignment in libxl__domain_suspend
>
> Currently ->xcflags remains 1 because the braces are placed incorrectly.
> Put each logical unit into its own braces to fix assigment to xcflags.
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
Acked + applied , thanks.
>
> diff -r 6727070b4129 -r 91fe6b42c7d4 tools/libxl/libxl_dom.c
> --- a/tools/libxl/libxl_dom.c
> +++ b/tools/libxl/libxl_dom.c
> @@ -1238,9 +1238,9 @@ void libxl__domain_suspend(libxl__egc *e
> abort();
> }
>
> - dss->xcflags = (live) ? XCFLAGS_LIVE : 0
> - | (debug) ? XCFLAGS_DEBUG : 0
> - | (dss->hvm) ? XCFLAGS_HVM : 0;
> + dss->xcflags = (live ? XCFLAGS_LIVE : 0)
> + | (debug ? XCFLAGS_DEBUG : 0)
> + | (dss->hvm ? XCFLAGS_HVM : 0);
>
> dss->suspend_eventchn = -1;
> dss->guest_responded = 0;
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-02-05 11:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-31 15:11 [PATCH] libxl: fix xcflags assignment in libxl__domain_suspend Olaf Hering
2013-02-05 11:34 ` Ian Campbell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).