From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>, Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH] libxl: fix ARM build after 54ed251dc7
Date: Thu, 16 Aug 2018 08:41:55 +0100 [thread overview]
Message-ID: <9297c93c-5fcc-a817-578d-71ec0bdb49bb@citrix.com> (raw)
In-Reply-To: <5B751E7902000078001DEB43@prv1-mh.provo.novell.com>
On 16/08/2018 07:49, Jan Beulich wrote:
> Commit "tools: Rework xc_domain_create() to take a full
> xen_domctl_createdomain" failed to replace one further instance of
> xc_config in libxl__arch_domain_save_config().
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> I have no environment set up to do cross tool stack builds, so the patch
> is solely based on osstest report and code inspection.
Nor do I sadly, and we don't yet have this working in Travis/gitlab
which is that testing missed it.
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> --- a/tools/libxl/libxl_arm.c
> +++ b/tools/libxl/libxl_arm.c
> @@ -125,7 +125,7 @@ int libxl__arch_domain_save_config(libxl__gc *gc,
> return ERROR_FAIL;
> }
>
> - state->clock_frequency = xc_config->clock_frequency;
> + state->clock_frequency = config->arch.clock_frequency;
>
> return 0;
> }
>
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-08-16 7:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 6:49 [PATCH] libxl: fix ARM build after 54ed251dc7 Jan Beulich
2018-08-16 7:41 ` Andrew Cooper [this message]
2018-08-16 12:45 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9297c93c-5fcc-a817-578d-71ec0bdb49bb@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).