* [PATCH] libxl: fix ARM build after 54ed251dc7
@ 2018-08-16 6:49 Jan Beulich
2018-08-16 7:41 ` Andrew Cooper
0 siblings, 1 reply; 3+ messages in thread
From: Jan Beulich @ 2018-08-16 6:49 UTC (permalink / raw)
To: xen-devel; +Cc: Andrew Cooper, Wei Liu, Ian Jackson
Commit "tools: Rework xc_domain_create() to take a full
xen_domctl_createdomain" failed to replace one further instance of
xc_config in libxl__arch_domain_save_config().
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
I have no environment set up to do cross tool stack builds, so the patch
is solely based on osstest report and code inspection.
--- a/tools/libxl/libxl_arm.c
+++ b/tools/libxl/libxl_arm.c
@@ -125,7 +125,7 @@ int libxl__arch_domain_save_config(libxl__gc *gc,
return ERROR_FAIL;
}
- state->clock_frequency = xc_config->clock_frequency;
+ state->clock_frequency = config->arch.clock_frequency;
return 0;
}
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] libxl: fix ARM build after 54ed251dc7
2018-08-16 6:49 [PATCH] libxl: fix ARM build after 54ed251dc7 Jan Beulich
@ 2018-08-16 7:41 ` Andrew Cooper
2018-08-16 12:45 ` Wei Liu
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Cooper @ 2018-08-16 7:41 UTC (permalink / raw)
To: Jan Beulich, xen-devel; +Cc: Ian Jackson, Wei Liu
On 16/08/2018 07:49, Jan Beulich wrote:
> Commit "tools: Rework xc_domain_create() to take a full
> xen_domctl_createdomain" failed to replace one further instance of
> xc_config in libxl__arch_domain_save_config().
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> I have no environment set up to do cross tool stack builds, so the patch
> is solely based on osstest report and code inspection.
Nor do I sadly, and we don't yet have this working in Travis/gitlab
which is that testing missed it.
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> --- a/tools/libxl/libxl_arm.c
> +++ b/tools/libxl/libxl_arm.c
> @@ -125,7 +125,7 @@ int libxl__arch_domain_save_config(libxl__gc *gc,
> return ERROR_FAIL;
> }
>
> - state->clock_frequency = xc_config->clock_frequency;
> + state->clock_frequency = config->arch.clock_frequency;
>
> return 0;
> }
>
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] libxl: fix ARM build after 54ed251dc7
2018-08-16 7:41 ` Andrew Cooper
@ 2018-08-16 12:45 ` Wei Liu
0 siblings, 0 replies; 3+ messages in thread
From: Wei Liu @ 2018-08-16 12:45 UTC (permalink / raw)
To: Andrew Cooper; +Cc: xen-devel, Wei Liu, Ian Jackson, Jan Beulich
On Thu, Aug 16, 2018 at 08:41:55AM +0100, Andrew Cooper wrote:
> On 16/08/2018 07:49, Jan Beulich wrote:
> > Commit "tools: Rework xc_domain_create() to take a full
> > xen_domctl_createdomain" failed to replace one further instance of
> > xc_config in libxl__arch_domain_save_config().
> >
> > Signed-off-by: Jan Beulich <jbeulich@suse.com>
> > ---
> > I have no environment set up to do cross tool stack builds, so the patch
> > is solely based on osstest report and code inspection.
>
> Nor do I sadly, and we don't yet have this working in Travis/gitlab
> which is that testing missed it.
>
> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-16 12:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-16 6:49 [PATCH] libxl: fix ARM build after 54ed251dc7 Jan Beulich
2018-08-16 7:41 ` Andrew Cooper
2018-08-16 12:45 ` Wei Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).