From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dulloor Subject: Re: [PATCH] libxc bitmap utils and vcpu-affinity Date: Tue, 23 Mar 2010 12:41:04 -0400 Message-ID: <940bcfd21003230941p216c1bb4u60e469d41dda51a@mail.gmail.com> References: <4BA8A1BC0200007800036662@vpn.id2.novell.com> <940bcfd21003230940w7c7d87eas7e1300cfdb633c4c@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <940bcfd21003230940w7c7d87eas7e1300cfdb633c4c@mail.gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: "xen-devel@lists.xensource.com" , Jan Beulich List-Id: xen-devel@lists.xenproject.org I meant utils for **xenctl_cpumap** On Tue, Mar 23, 2010 at 12:40 PM, Dulloor wrote: > Fine, I agree with you both. Attached is a patch adding utils for > xenctl_bitmap (to libxc) and using the same in vcpu_(get|set)affinity. > For the guest-numa interface, I will see if I can use xenctl_cpumap. > > -dulloor > > On Tue, Mar 23, 2010 at 7:05 AM, Keir Fraser = wrote: >> On 23/03/2010 10:10, "Jan Beulich" wrote: >> >>>>>> Dulloor 22.03.10 18:44 >>> >>>> Motivation for using xenctl_cpumask in Xen interfaces : >>>> - xenctl_cpumap is just 4 bytes smaller than static xenctl_cpumask for >>>> 128 cpus (128 would be good for quite some time). However, the new >>> >>> I don't buy this (we're already building for 256 CPUs, looking forward >>> to further bump this in the not too distant future), and I'm generally >>> opposed to introducing hard coded limits in a public interface. >> >> We should use xenctl_cpumask everywhere for specifying physical CPU bitm= aps, >> even into guest NUMA interfaces if appropriate. I don't really care if i= t is >> a bit harder to use than a static bitmap. >> >> =A0-- Keir >> >> >> >