xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 2/2] x86: drop cpu_has_sse{,2}
Date: Fri, 9 Dec 2016 13:00:31 +0000	[thread overview]
Message-ID: <96f3912f-f6ec-7a49-4a2f-74faff2f8941@citrix.com> (raw)
In-Reply-To: <584AA97F02000078001273AE@prv-mh.provo.novell.com>

On 09/12/16 11:54, Jan Beulich wrote:
> Commit dc88221c97 ("x86: rename XMM* features to SSE*") pointlessly
> added them - these features are always available on 64-bit CPUs. (Let's
> not assume this for MMX though in at least the insn emulator.)
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

This isn't necessarily true when compiled for 32bit in the userspace
harness.

What about just defining #define cpu_has_sse{,2} as a literal 1?

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2016-12-09 13:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-09 11:44 [PATCH 0/2] x86emul: feature flag handling adjustments Jan Beulich
2016-12-09 11:53 ` [PATCH 1/2] x86emul: derive vcpu_must_have() from vcpu_has() Jan Beulich
2016-12-09 12:53   ` Andrew Cooper
2016-12-09 11:54 ` [PATCH 2/2] x86: drop cpu_has_sse{,2} Jan Beulich
2016-12-09 13:00   ` Andrew Cooper [this message]
2016-12-09 13:28     ` Jan Beulich
2016-12-09 14:15       ` Andrew Cooper
2016-12-09 14:33         ` Jan Beulich
2016-12-09 14:56           ` Andrew Cooper
2016-12-09 15:19             ` Jan Beulich
2016-12-09 15:27               ` Jan Beulich
2016-12-15  9:57                 ` Ping: " Jan Beulich
2016-12-15 12:03                   ` Andrew Cooper
2016-12-15 14:52                     ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=96f3912f-f6ec-7a49-4a2f-74faff2f8941@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).