From: Julien Grall <julien.grall@arm.com>
To: Jan Beulich <JBeulich@suse.com>, Daniel Kiper <daniel.kiper@oracle.com>
Cc: Juergen Gross <JGross@suse.com>,
sstabellini@kernel.org, andrew.cooper3@citrix.com,
cardoe@cardoe.com, pgnet.dev@gmail.com, ning.sun@intel.com,
david.vrabel@citrix.com, xen-devel@lists.xenproject.org,
qiaowei.ren@intel.com, gang.wei@intel.com, fu.wei@linaro.org
Subject: Re: [PATCH v9 06/13] efi: create new early memory allocator
Date: Wed, 5 Oct 2016 11:30:59 -0700 [thread overview]
Message-ID: <974f11bb-c223-6b4d-483d-03a80b9a0b30@arm.com> (raw)
In-Reply-To: <57EE50AE02000078001141A5@prv-mh.provo.novell.com>
Hi Jan,
Sorry for the late answer, I have been traveling the past 2 weeks.
On 30/09/2016 02:46, Jan Beulich wrote:
>>>> On 29.09.16 at 23:42, <daniel.kiper@oracle.com> wrote:
>> +#else
>> +static void __init free_ebmalloc_unused_mem(void)
>> +{
>> +}
>> +#endif
>
> Did you build test this for ARM? The function ought to be unused,
> as ...
>
>> @@ -1251,6 +1301,8 @@ void __init efi_init_memory(void)
>> } *extra, *extra_head = NULL;
>> #endif
>>
>> + free_ebmalloc_unused_mem();
>
> ... the whole function here doesn't get built on ARM.
>
> Julien - we're still awaiting your input on general aspects here.
efi_init_memory would need to be called during Xen boot on ARM. I am not
sure where as I we don't yet have runtime support on ARM.
Other than that, the patch looks good to me.
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-10-05 18:31 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-29 21:42 [PATCH v9 00/13] x86: multiboot2 protocol support Daniel Kiper
2016-09-29 21:42 ` [PATCH v9 01/13] x86: add " Daniel Kiper
2016-09-29 21:42 ` [PATCH v9 02/13] efi: create efi_enabled() Daniel Kiper
2016-09-29 21:42 ` [PATCH v9 03/13] x86: allow EFI reboot method neither on EFI platforms Daniel Kiper
2016-09-29 21:42 ` [PATCH v9 04/13] x86: properly calculate xen ELF end of image address Daniel Kiper
2016-09-30 9:43 ` Jan Beulich
2016-09-29 21:42 ` [PATCH v9 05/13] efi: build xen.gz with EFI code Daniel Kiper
2016-09-29 21:42 ` [PATCH v9 06/13] efi: create new early memory allocator Daniel Kiper
2016-09-30 9:46 ` Jan Beulich
2016-09-30 10:49 ` Daniel Kiper
2016-10-05 7:02 ` Daniel Kiper
2016-10-05 15:45 ` Julien Grall
2016-10-05 18:30 ` Julien Grall [this message]
2016-10-06 12:21 ` Jan Beulich
2016-10-11 13:39 ` Julien Grall
2016-10-12 11:45 ` Jan Beulich
2016-10-12 12:51 ` Julien Grall
2016-10-12 12:59 ` Jan Beulich
2016-10-24 9:03 ` Daniel Kiper
2016-10-24 9:57 ` Jan Beulich
2016-11-03 13:48 ` Daniel Kiper
2016-11-10 10:34 ` Daniel Kiper
2016-10-31 13:32 ` Julien Grall
2016-09-29 21:42 ` [PATCH v9 07/13] x86: add multiboot2 protocol support for EFI platforms Daniel Kiper
2016-11-23 18:52 ` Andrew Cooper
2016-11-24 11:08 ` Jan Beulich
2016-11-24 21:44 ` Daniel Kiper
2016-11-25 7:50 ` Jan Beulich
2016-11-30 13:45 ` Daniel Kiper
2016-11-30 13:59 ` Jan Beulich
2016-11-30 17:21 ` Daniel Kiper
2016-11-24 21:31 ` Daniel Kiper
2016-09-29 21:42 ` [PATCH v9 08/13] x86/boot: implement early command line parser in C Daniel Kiper
2016-09-29 21:42 ` [PATCH v9 09/13] x86: change default load address from 1 MiB to 2 MiB Daniel Kiper
2016-09-30 10:02 ` Jan Beulich
2016-09-29 21:42 ` [PATCH v9 10/13] x86/setup: use XEN_IMG_OFFSET instead of Daniel Kiper
2016-09-29 21:42 ` [PATCH v9 11/13] x86: make Xen early boot code relocatable Daniel Kiper
2016-09-29 21:42 ` [PATCH v9 12/13] x86/boot: rename sym_phys() to sym_offs() Daniel Kiper
2016-09-29 21:42 ` [PATCH v9 13/13] x86: add multiboot2 protocol support for relocatable images Daniel Kiper
2016-09-30 10:03 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=974f11bb-c223-6b4d-483d-03a80b9a0b30@arm.com \
--to=julien.grall@arm.com \
--cc=JBeulich@suse.com \
--cc=JGross@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=cardoe@cardoe.com \
--cc=daniel.kiper@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=fu.wei@linaro.org \
--cc=gang.wei@intel.com \
--cc=ning.sun@intel.com \
--cc=pgnet.dev@gmail.com \
--cc=qiaowei.ren@intel.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).