From: George Dunlap <george.dunlap@citrix.com>
To: Paul Durrant <Paul.Durrant@citrix.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Anthony Perard <anthony.perard@citrix.com>,
Ian Jackson <Ian.Jackson@citrix.com>,
Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH v4 4/6] tools/dm_restrict: Unshare mount and IPC namespaces on Linux
Date: Tue, 6 Nov 2018 10:29:31 +0000 [thread overview]
Message-ID: <97ad088b-c61b-ff67-d9aa-008e1678a8ca@citrix.com> (raw)
In-Reply-To: <48cdd789994e421faaf825a7d9b50aa0@AMSPEX02CL03.citrite.net>
On 11/06/2018 09:16 AM, Paul Durrant wrote:
>> diff --git a/tools/libxl/libxl_netbsd.c b/tools/libxl/libxl_netbsd.c
>> index 2edfb00641..dce3f1fdce 100644
>> --- a/tools/libxl/libxl_netbsd.c
>> +++ b/tools/libxl/libxl_netbsd.c
>> @@ -124,3 +124,8 @@ int libxl__pci_topology_init(libxl__gc *gc,
>> {
>> return ERROR_NI;
>> }
>> +
>> +void libxl__local_dm_preexec_restrict(libxl__gc *gc, int stderrfd)
>> +{
>> + return;
>> +}
>
> This is a void function whereas the caller always appears to expect an int return value, regardless of OS.
Indeed, this would probably break the build on NetBSD. Good catch.
-George
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-11-06 10:29 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 18:07 [PATCH v4 1/6] docs/qemu-deprivilege: Revise and update with status and future plans George Dunlap
2018-11-05 18:07 ` [PATCH v4 2/6] SUPPORT.md: Add qemu-depriv section George Dunlap
2018-11-06 9:08 ` Paul Durrant
2018-11-06 12:14 ` George Dunlap
2018-11-06 11:50 ` Ian Jackson
2018-11-05 18:07 ` [PATCH v4 3/6] tools/dm_restrict: Ask QEMU to chroot George Dunlap
2018-11-06 9:14 ` Paul Durrant
2018-11-06 10:28 ` George Dunlap
2018-11-06 10:53 ` Paul Durrant
2018-11-06 11:11 ` Anthony PERARD
2018-11-06 11:12 ` Paul Durrant
2018-11-05 18:07 ` [PATCH v4 4/6] tools/dm_restrict: Unshare mount and IPC namespaces on Linux George Dunlap
2018-11-06 9:16 ` Paul Durrant
2018-11-06 10:29 ` George Dunlap [this message]
2018-11-05 18:07 ` [PATCH v4 5/6] tools/dm_depriv: Add first cut RLIMITs George Dunlap
2018-11-06 9:22 ` Paul Durrant
2018-11-06 10:39 ` George Dunlap
2018-11-06 11:52 ` Ian Jackson
2018-11-05 18:07 ` [PATCH v4 6/6] RFC: test/depriv: Add a tool to check process-level depriv George Dunlap
2018-11-06 9:34 ` Paul Durrant
2018-11-06 10:43 ` George Dunlap
2018-11-05 18:08 ` [PATCH v4 1/6] docs/qemu-deprivilege: Revise and update with status and future plans George Dunlap
2018-11-06 9:07 ` Paul Durrant
2018-11-06 11:06 ` Anthony PERARD
2018-11-06 11:50 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97ad088b-c61b-ff67-d9aa-008e1678a8ca@citrix.com \
--to=george.dunlap@citrix.com \
--cc=Ian.Jackson@citrix.com \
--cc=Paul.Durrant@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).