From: Julien Grall <julien.grall@arm.com>
To: Mirela Simonovic <mirela.simonovic@aggios.com>, xen-devel@lists.xen.org
Cc: edgar.iglesias@xilinx.com, sstabellini@kernel.org
Subject: Re: [PATCH v4 05/10] xen/arm: Setup virtual paging for non-boot CPUs on hotplug/resume
Date: Tue, 29 May 2018 14:27:16 +0100 [thread overview]
Message-ID: <987d2bd3-2ebd-d855-16e8-d6d2a6ffe23e@arm.com> (raw)
In-Reply-To: <20180515114419.7296-6-mirela.simonovic@aggios.com>
Hi,
On 15/05/18 12:44, Mirela Simonovic wrote:
> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
> index d43c3aa896..924226f63c 100644
> --- a/xen/arch/arm/p2m.c
> +++ b/xen/arch/arm/p2m.c
> @@ -8,6 +8,8 @@
> #include <xen/iocap.h>
> #include <xen/mem_access.h>
> #include <xen/xmalloc.h>
> +#include <xen/cpu.h>
> +#include <xen/notifier.h>
> #include <public/vm_event.h>
> #include <asm/flushtlb.h>
> #include <asm/event.h>
> @@ -1451,10 +1453,12 @@ err:
> return page;
> }
>
> -static void __init setup_virt_paging_one(void *data)
> +/* VTCR value to be configured by all CPUs. Set only once by the boot CPU */
> +static uint64_t __read_mostly vtcr;
This should be uint32_t as VTCR is a 32-bit register. The rest looks
good to me.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-05-29 13:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-15 11:44 [PATCH v4 00/10] xen/arm64: Suspend preconditions and CPU hotplug fixes Mirela Simonovic
2018-05-15 11:44 ` [PATCH v4 01/10] xen/arm64: Added handling of the trapped access to OSLSR register Mirela Simonovic
2018-05-29 13:19 ` Julien Grall
2018-05-30 9:48 ` Mirela Simonovic
2018-05-30 9:53 ` Mirela Simonovic
2018-05-31 11:17 ` Julien Grall
2018-05-15 11:44 ` [PATCH v4 02/10] xen/arm: Ignore write to GICD_ISACTIVERn registers (vgic-v2) Mirela Simonovic
2018-05-15 11:44 ` [PATCH v4 03/10] xen/arm: Implement CPU_OFF PSCI call (physical interface) Mirela Simonovic
2018-05-15 11:44 ` [PATCH v4 04/10] xen/arm: Remove __initdata and __init to enable CPU hotplug Mirela Simonovic
2018-05-15 11:44 ` [PATCH v4 05/10] xen/arm: Setup virtual paging for non-boot CPUs on hotplug/resume Mirela Simonovic
2018-05-29 13:27 ` Julien Grall [this message]
2018-05-15 11:44 ` [PATCH v4 06/10] xen/common: Restore IRQ affinity when hotplugging a pCPU Mirela Simonovic
2018-05-15 11:44 ` [PATCH v4 07/10] xen/arm: Release maintenance interrupt when CPU is hot-unplugged Mirela Simonovic
2018-05-15 11:44 ` [PATCH v4 08/10] xen/arm: Disable timers and release their interrupts on CPU hot-unplug Mirela Simonovic
2018-05-29 13:32 ` Julien Grall
2018-05-15 11:44 ` [PATCH v4 09/10] xen/arm: Free memory allocated for sibling/core maps " Mirela Simonovic
2018-05-29 13:34 ` Julien Grall
2018-05-15 11:44 ` [PATCH v4 10/10] xen/arm: Enable errata for secondary CPU on hotplug after the boot Mirela Simonovic
2018-05-29 13:35 ` Julien Grall
2018-05-28 10:15 ` [PATCH v4 00/10] xen/arm64: Suspend preconditions and CPU hotplug fixes Mirela Simonovic
2018-05-29 13:14 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=987d2bd3-2ebd-d855-16e8-d6d2a6ffe23e@arm.com \
--to=julien.grall@arm.com \
--cc=edgar.iglesias@xilinx.com \
--cc=mirela.simonovic@aggios.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).