From: Ross Lagerwall <ross.lagerwall@citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: xen-devel@lists.xen.org
Subject: Re: [PATCH v2 LIVEPATCH-BUILD-TOOLS] Fix patch creation with GCC 6.1+
Date: Mon, 12 Dec 2016 15:24:59 +0000 [thread overview]
Message-ID: <99a1b808-1f47-aef7-8dde-e06dbb8be3d3@citrix.com> (raw)
In-Reply-To: <20161212150120.GF21593@char.us.oracle.com>
On 12/12/2016 03:01 PM, Konrad Rzeszutek Wilk wrote:
> On Mon, Dec 12, 2016 at 02:55:51PM +0000, Ross Lagerwall wrote:
>> GCC 6.1+ fixed https://gcc.gnu.org/bugzilla/show_bug.cgi?id=192 which
>> means that .rodata.str1.[0-9]+ sections are now split by function. We
>> could probably be smarter about including just the sections we need, but
>> for now, simply include the string sections for all functions as is done
>> for previous versions of GCC.
>
> Are there plans to push this to the upstream kpatch repo? Or did
> they do it in some other way?
There isn't an upstream change for this. I _think_ the reason is that
differences in the way that the Linux kernel is built (e.g. without
-fPIC), and the way that the kpatch module is created means that kpatch
is not affected by this.
>>
>> Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
>> Reported-by: M A Young <m.a.young@durham.ac.uk>
>> ---
>>
>> Changed in v2:
>> * Clarified commit message.
>
> Thanks. Two little nitpicks - feel free to either ignore them
> or take them into account.
>
> Either way:
>
> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Pushed with the suggested changes. Thanks.
--
Ross Lagerwall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-12-12 15:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-12 14:55 [PATCH v2 LIVEPATCH-BUILD-TOOLS] Fix patch creation with GCC 6.1+ Ross Lagerwall
2016-12-12 15:01 ` Konrad Rzeszutek Wilk
2016-12-12 15:24 ` Ross Lagerwall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99a1b808-1f47-aef7-8dde-e06dbb8be3d3@citrix.com \
--to=ross.lagerwall@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).