From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
Cc: ian.jackson@eu.citrix.com, wei.liu2@citrix.com
Subject: Re: [PATCH 1/4] interface: avoid redefinition of __XEN_INTERFACE_VERSION__
Date: Tue, 28 Feb 2017 10:57:33 +0000 [thread overview]
Message-ID: <9a70e9ed-7861-d4e8-d8ed-ad1f4fd127e7@citrix.com> (raw)
In-Reply-To: <20170228103500.30803-2-jgross@suse.com>
On 28/02/17 10:34, Juergen Gross wrote:
> In stubdom environment __XEN_INTERFACE_VERSION__ is sometimes defined
> on the command line of the build instruction. This conflicts with
> xen-compat.h defining it unconditionally if __XEN__ or __XEN_TOOLS__
> is set.
>
> Just use #undef in this case to avoid the resulting warning.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> xen/include/public/xen-compat.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/xen/include/public/xen-compat.h b/xen/include/public/xen-compat.h
> index b673653..9453439 100644
> --- a/xen/include/public/xen-compat.h
> +++ b/xen/include/public/xen-compat.h
> @@ -31,6 +31,7 @@
>
> #if defined(__XEN__) || defined(__XEN_TOOLS__)
> /* Xen is built with matching headers and implements the latest interface. */
> +#undef __XEN_INTERFACE_VERSION__
> #define __XEN_INTERFACE_VERSION__ __XEN_LATEST_INTERFACE_VERSION__
> #elif !defined(__XEN_INTERFACE_VERSION__)
> /* Guests which do not specify a version get the legacy interface. */
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-02-28 10:57 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 10:34 [PATCH 0/4] build enhancements related to qemu Juergen Gross
2017-02-28 10:34 ` [PATCH 1/4] interface: avoid redefinition of __XEN_INTERFACE_VERSION__ Juergen Gross
2017-02-28 10:57 ` Andrew Cooper [this message]
2017-02-28 11:10 ` Ian Jackson
2017-02-28 12:40 ` Juergen Gross
2017-02-28 11:11 ` Jan Beulich
[not found] ` <58B568FD020000780013E159@suse.com>
2017-02-28 12:24 ` Juergen Gross
2017-02-28 12:46 ` Jan Beulich
[not found] ` <58B57F3A020000780013E285@suse.com>
2017-02-28 13:10 ` Juergen Gross
2017-02-28 13:13 ` Ian Jackson
2017-02-28 13:52 ` Juergen Gross
2017-02-28 13:33 ` Jan Beulich
2017-02-28 10:34 ` [PATCH 2/4] tools: add pkg-config file for libxc Juergen Gross
2017-02-28 11:13 ` Ian Jackson
2017-02-28 12:32 ` Juergen Gross
2017-02-28 12:52 ` Wei Liu
2017-02-28 13:01 ` Ian Jackson
2017-02-28 10:34 ` [PATCH 3/4] tools: use a dedicated build directory for qemu Juergen Gross
2017-02-28 11:13 ` Ian Jackson
2017-02-28 12:33 ` Juergen Gross
2017-02-28 13:14 ` Ian Jackson
2017-02-28 13:18 ` Juergen Gross
2017-02-28 10:35 ` [PATCH 4/4] tools: set pkg-config path when configuring qemu Juergen Gross
2017-02-28 11:08 ` Ian Jackson
2017-02-28 11:11 ` Juergen Gross
2017-02-28 11:14 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a70e9ed-7861-d4e8-d8ed-ad1f4fd127e7@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jgross@suse.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).